From: Aaron Lu <aaron.lu@amd.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
Date: Fri, 13 Jan 2012 14:32:27 +0800 [thread overview]
Message-ID: <20120113063226.GC2701@ladygaga> (raw)
In-Reply-To: <8A2FC72B45BB5A4C9F801431E06AE48F1166942B@039-SN1MPN1-005.039d.mgd.msft.net>
Hi,
On Fri, Jan 13, 2012 at 03:39:53AM +0000, Huang Changming-R66093 wrote:
>
>
> > -----Original Message-----
> > From: Aaron Lu [mailto:aaron.lu@amd.com]
> > Sent: Friday, January 13, 2012 11:27 AM
> > To: Huang Changming-R66093
> > Cc: linux-mmc@vger.kernel.org; Chris Ball
> > Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> >
> > Hi,
> >
> > On Fri, Jan 13, 2012 at 02:24:46AM +0000, Huang Changming-R66093 wrote:
> > > Hi, Chris,
> > > Could you have any comment about this patch?
> > > Can it go into 3.3 or 3.4?
> > >
> > > > -----Original Message-----
> > > > From: Huang Changming-R66093
> > > > Sent: Friday, December 09, 2011 10:54 AM
> > > > To: linux-mmc@vger.kernel.org
> > > > Cc: Huang Changming-R66093; Chris Ball
> > > > Subject: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> > > >
> > > > From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > > >
> > > > When f_init is zero, the SDHC can't work correctly. So f_min will
> > > > replace f_init, when f_init is zero.
> >
> > What about setting f_init before your call to mmc_power_up?
> f_init is initialized only by mmc_rescan_try_freq, and mmc_power_up will use it.
> But mmc_power_up will called not only by mmc_rescan_try_freq, but also by other functions.
> You will see it in my previous email about it.
>
Yes, I know there are other callers for mmc_power_up.
Either you set host->f_init in mmc_power_up, or you set it before you
call mmc_power_up. I prefer the latter one but I'm not sure which one
should be used. Maybe Chris can comment on this.
next prev parent reply other threads:[~2012-01-13 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 2:53 [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() r66093
2011-12-09 2:53 ` [PATCH 2/4 v3] MMC/SD: Add callback function to detect card r66093
2011-12-09 2:53 ` [PATCH 3/4 v4] SDHCI: add sdhci_get_cd callback to detect the card r66093
2011-12-09 2:53 ` [PATCH 4/4 v3] ESDHC: add callback esdhc_of_get_cd to detect card r66093
2012-01-13 2:25 ` Huang Changming-R66093
2012-01-13 2:24 ` [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() Huang Changming-R66093
2012-01-13 3:26 ` Aaron Lu
2012-01-13 3:39 ` Huang Changming-R66093
2012-01-13 6:32 ` Aaron Lu [this message]
2012-01-13 6:48 ` Huang Changming-R66093
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 8:12 r66093
2012-10-30 23:08 ` Ulf Hansson
2012-10-31 2:23 ` Huang Changming-R66093
2012-10-31 4:21 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113063226.GC2701@ladygaga \
--to=aaron.lu@amd.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.