From: Joerg Roedel <Joerg.Roedel@amd.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>, Arik Nemtsov <arik@wizery.com>,
Raja Govindraj <govindraj.raja@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] ARM: OMAP3: fix build on !CONFIG_IOMMU_API
Date: Fri, 13 Jan 2012 12:07:28 +0100 [thread overview]
Message-ID: <20120113110728.GC2275@amd.com> (raw)
In-Reply-To: <1326288491-25146-1-git-send-email-ohad@wizery.com>
On Wed, Jan 11, 2012 at 03:28:11PM +0200, Ohad Ben-Cohen wrote:
> omap3isp depends on CONFIG_IOMMU_API, so avoid registering its
> device (and defining its configuration structs) on !CONFIG_IOMMU_API.
>
> This is generally nice to have, but more importantly, it fixes:
>
> arch/arm/plat-omap/include/plat/iommu.h: In function 'dev_to_omap_iommu':
> arch/arm/plat-omap/include/plat/iommu.h:135: error: 'struct
> dev_archdata' has no member named 'iommu'
> arch/arm/mach-omap2/devices.c: In function 'omap3_init_camera':
> arch/arm/mach-omap2/devices.c:222: error: 'struct dev_archdata' has no
> member named 'iommu'
> make[1]: *** [arch/arm/mach-omap2/devices.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
Will apply it as soon as the merge window closes.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: Joerg.Roedel@amd.com (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP3: fix build on !CONFIG_IOMMU_API
Date: Fri, 13 Jan 2012 12:07:28 +0100 [thread overview]
Message-ID: <20120113110728.GC2275@amd.com> (raw)
In-Reply-To: <1326288491-25146-1-git-send-email-ohad@wizery.com>
On Wed, Jan 11, 2012 at 03:28:11PM +0200, Ohad Ben-Cohen wrote:
> omap3isp depends on CONFIG_IOMMU_API, so avoid registering its
> device (and defining its configuration structs) on !CONFIG_IOMMU_API.
>
> This is generally nice to have, but more importantly, it fixes:
>
> arch/arm/plat-omap/include/plat/iommu.h: In function 'dev_to_omap_iommu':
> arch/arm/plat-omap/include/plat/iommu.h:135: error: 'struct
> dev_archdata' has no member named 'iommu'
> arch/arm/mach-omap2/devices.c: In function 'omap3_init_camera':
> arch/arm/mach-omap2/devices.c:222: error: 'struct dev_archdata' has no
> member named 'iommu'
> make[1]: *** [arch/arm/mach-omap2/devices.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
Will apply it as soon as the merge window closes.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-01-13 11:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 13:28 [PATCH] ARM: OMAP3: fix build on !CONFIG_IOMMU_API Ohad Ben-Cohen
2012-01-11 13:28 ` Ohad Ben-Cohen
2012-01-12 12:07 ` Laurent Pinchart
2012-01-12 12:07 ` Laurent Pinchart
2012-01-13 11:07 ` Joerg Roedel [this message]
2012-01-13 11:07 ` Joerg Roedel
2012-01-13 15:54 ` Ohad Ben-Cohen
2012-01-13 15:54 ` Ohad Ben-Cohen
2012-01-13 16:46 ` Joerg Roedel
2012-01-13 16:46 ` Joerg Roedel
2012-01-13 16:48 ` Ohad Ben-Cohen
2012-01-13 16:48 ` Ohad Ben-Cohen
2012-01-13 17:26 ` Tony Lindgren
2012-01-13 17:26 ` Tony Lindgren
2012-01-16 11:03 ` Joerg Roedel
2012-01-16 11:03 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113110728.GC2275@amd.com \
--to=joerg.roedel@amd.com \
--cc=arik@wizery.com \
--cc=govindraj.raja@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.