Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

[Jean-Francois Moine <moinejf@free.fr>]

On Fri,  6 Jan 2012 19:14:41 +0100
Sylwester Nawrocki <snjw23@gmail.com> wrote:

> The JPEG compression quality value can currently be read using the
> VIDIOC_G_JPEGCOMP ioctl. As the quality field of struct v4l2_jpgecomp
> is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY
> control, so after the deprecation period VIDIOC_G_JPEGCOMP ioctl
> handler can be removed, leaving the control the only user interface
> for retrieving the compression quality.
	[snip]

This patch works, but, to follow the general control mechanism in gspca,
it should be better to remove the variable 'quality' of 'struct sd' and
to replace all 'sd->quality' by 'sd->ctrls[QUALITY].val'.

Then, initialization

	sd->quality = QUALITY_DEF;

in sd_config() is no more useful, and there is no need to have a
getjpegqual() function, the control descriptor for QUALITY having just:

	.set_control = setjpegqual

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/