Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

On 01/14/2012 07:24 PM, Jean-Francois Moine wrote:
> 
> Setting the JPEG quality in sonixj has been removed when automatic
> quality adjustment has been added (git commit b96cfc33e7). At this
> time, I let the JPEG get function, but it could have been removed as
> well: I don't think the users are interested by this quality, and the
> applications may find it looking at the quantization tables of the
> images.
> 
> Otherwise, letting the users/applications to set this quality is
> dangerous: if the quality is too high, the images cannot be fully
> transmitted because their size is too big for the USB 1.1 channel.
> 
> So, IMO, you should let the sonixj as it is, and I will remove the
> get_jepgcomp.

I see, indeed the quantization tables provide much more precise 
information. I've dropped the sonixj patch from the series then.

--
Thanks,
Sylwester