[PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

[PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

[Jason Dravet]

This patch makes it clear that the problem is in the BIOS of the computer and not the kernel.  This patch applies to kernel 3.2.1.
 
Reported-by: Greg White <pcguy11@live.com>
Signed-off-by: Jason Dravet <dravet@hotmail.com>
Tested-by: Greg White <pcguy11@live.com>
 
--- dir.orig    2012-01-14 18:58:20.026745884 -0600
+++ dir.c    2012-01-14 19:52:33.011444581 -0600
@@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
              (path == NULL) ? sd->s_name :
              strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
                     sd->s_name));
+        WARN(1, KERN_WARNING
+             "Your BIOS is broken.  Please contact your computer manufacturer.");
         kfree(path);
     }
 
 

 		 	   		  

Re: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

[Dave Jones]

On Sun, Jan 15, 2012 at 09:16:13AM -0600, Jason Dravet wrote:
 > 
 > This patch makes it clear that the problem is in the BIOS of the computer and not the kernel.  This patch applies to kernel 3.2.1.
 >  
 > Reported-by: Greg White <pcguy11@live.com>
 > Signed-off-by: Jason Dravet <dravet@hotmail.com>
 > Tested-by: Greg White <pcguy11@live.com>
 >  
 > --- dir.orig    2012-01-14 18:58:20.026745884 -0600
 > +++ dir.c    2012-01-14 19:52:33.011444581 -0600
 > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
 >               (path == NULL) ? sd->s_name :
 >               strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
 >                      sd->s_name));
 > +        WARN(1, KERN_WARNING
 > +             "Your BIOS is broken.  Please contact your computer manufacturer.");
 >          kfree(path);
 >      }
 
That certainly isn't always the case. Incorrectly written drivers
have also taken this codepath before now.

	Dave

RE: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

[Jason Dravet]

>  > This patch makes it clear that the problem is in the BIOS of 
the computer and not the kernel.  This patch applies to kernel 3.2.1.
>  >  
>  > --- dir.orig    2012-01-14 18:58:20.026745884 -0600
>  > +++ dir.c    2012-01-14 19:52:33.011444581 -0600
>  > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
>  >               (path == NULL) ? sd->s_name :
>  >               strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
>  >                      sd->s_name));
>  > +        WARN(1, KERN_WARNING
>  > +             "Your BIOS is broken.  Please contact your computer manufacturer.");
>  >          kfree(path);
>  >      }
>  
> That certainly isn't always the case. Incorrectly written drivers
> have also taken this codepath before now.
> 
> 	Dave

Then how do you tell when the problem is the BIOS or a driver?
Jason