From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check that plane/pipe is disabled before removing the fb
Date: Tue, 17 Jan 2012 11:09:21 +0100 [thread overview]
Message-ID: <20120117100921.GA4093@phenom.ffwll.local> (raw)
In-Reply-To: <1326754873-2021-1-git-send-email-chris@chris-wilson.co.uk>
On Mon, Jan 16, 2012 at 11:01:13PM +0000, Chris Wilson wrote:
> Staring at an error state such as:
>
> PGTBL_ER: 0x00000400
> Display B: Invalid tiling
> fence[0] = 05001001
> valid, x-tiled, pitch: 512, start: 0x05000000, size: 1048576
> Pinned [2]:
> 00000000 131072 0001 0001 00000000 P uncached
> 00020000 4096000 0041 0000 00000000 P uncached (name: 1)
> Plane [1]:
> CNTR: c0000000 # enabled | gamma
> STRIDE: 00001400
> SIZE: 03ff04ff
> POS: 00000000
> ADDR: 05000000
>
> Suggests that we did not clear the DSPBCNTR prior to unpinning the
> framebuffer and reusing the GTT space. Impossible! Unless our DPMS
> bookkeeping ran afoul again...
>
> In the meantime add an assertion that the plane is decoupled from the
> framebuffer prior to release.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-01-17 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 18:22 [PATCH] drm/i915: Check that plane/pipe is disabled before removing the fb Chris Wilson
2012-01-16 22:48 ` Daniel Vetter
2012-01-16 23:01 ` Chris Wilson
2012-01-17 10:09 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117100921.GA4093@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.