All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	"Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
	Christoph Hellwig <hch@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Roland McGrath <roland@hack.frob.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Anton Arapov <anton@redhat.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v9 3.2 7/9] tracing: uprobes trace_event interface
Date: Tue, 17 Jan 2012 12:22:39 +0100	[thread overview]
Message-ID: <20120117112239.GA23859@elte.hu> (raw)
In-Reply-To: <20120117102231.GB15447@linux.vnet.ibm.com>


Srikar, rebased commits like this one:

  c5af743: rcu: Introduce raw SRCU read-side primitives

are absolutely inacceptable:

 commit c5af7439f322db86e347991e184b95dd80676967
 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
 Date:   Sun Oct 9 15:13:11 2011 -0700

    rcu: Introduce raw SRCU read-side primitives

    ...

    Requested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

If you pull a commit from Paul into your tree then you must 
never rebase it. If you applied Paul's commit out of email then 
you should add a Signed-off-by, not a Tested-by tag at the end.

Also, please test whether it works when merged to latest -tip, 
there's been various RCU changes in this area. AFAICS these 
read-side primitives are already upstream via:

  0c53dd8b3140: rcu: Introduce raw SRCU read-side primitives

so pulling your tree would break the build.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	"Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
	Christoph Hellwig <hch@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Roland McGrath <roland@hack.frob.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Anton Arapov <anton@redhat.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v9 3.2 7/9] tracing: uprobes trace_event interface
Date: Tue, 17 Jan 2012 12:22:39 +0100	[thread overview]
Message-ID: <20120117112239.GA23859@elte.hu> (raw)
In-Reply-To: <20120117102231.GB15447@linux.vnet.ibm.com>


Srikar, rebased commits like this one:

  c5af743: rcu: Introduce raw SRCU read-side primitives

are absolutely inacceptable:

 commit c5af7439f322db86e347991e184b95dd80676967
 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
 Date:   Sun Oct 9 15:13:11 2011 -0700

    rcu: Introduce raw SRCU read-side primitives

    ...

    Requested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

If you pull a commit from Paul into your tree then you must 
never rebase it. If you applied Paul's commit out of email then 
you should add a Signed-off-by, not a Tested-by tag at the end.

Also, please test whether it works when merged to latest -tip, 
there's been various RCU changes in this area. AFAICS these 
read-side primitives are already upstream via:

  0c53dd8b3140: rcu: Introduce raw SRCU read-side primitives

so pulling your tree would break the build.

Thanks,

	Ingo

  parent reply	other threads:[~2012-01-17 11:22 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-10 11:48 [PATCH v9 3.2 0/9] Uprobes patchset with perf probe support Srikar Dronamraju
2012-01-10 11:48 ` Srikar Dronamraju
2012-01-10 11:48 ` [PATCH v9 3.2 1/9] uprobes: Install and remove breakpoints Srikar Dronamraju
2012-01-10 11:48   ` Srikar Dronamraju
2012-01-25 14:39   ` Denys Vlasenko
2012-01-25 14:39     ` Denys Vlasenko
2012-01-25 16:31     ` Oleg Nesterov
2012-01-25 16:31       ` Oleg Nesterov
2012-01-25 15:13   ` Denys Vlasenko
2012-01-25 15:13     ` Denys Vlasenko
2012-01-25 15:32     ` Denys Vlasenko
2012-01-25 15:32       ` Denys Vlasenko
2012-01-26 14:14       ` Masami Hiramatsu
2012-01-26 14:14         ` Masami Hiramatsu
2012-01-26 18:28         ` Denys Vlasenko
2012-01-26 18:28           ` Denys Vlasenko
2012-01-30  9:51           ` Masami Hiramatsu
2012-01-30  9:51             ` Masami Hiramatsu
2012-01-26 13:38     ` Masami Hiramatsu
2012-01-26 13:38       ` Masami Hiramatsu
2012-01-26 13:45   ` Masami Hiramatsu
2012-01-26 13:45     ` Masami Hiramatsu
2012-01-10 11:48 ` [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception Srikar Dronamraju
2012-01-10 11:48   ` Srikar Dronamraju
2012-01-18  8:39   ` Anton Arapov
2012-01-18  8:39     ` Anton Arapov
2012-01-18  9:02     ` Srikar Dronamraju
2012-01-18  9:02       ` Srikar Dronamraju
2012-01-18 10:18       ` Mike Frysinger
2012-01-18 10:47         ` Srikar Dronamraju
2012-01-18 10:47           ` Srikar Dronamraju
2012-01-18 11:01           ` Mike Frysinger
2012-01-20 22:57             ` Mike Frysinger
2012-01-20 22:57               ` Mike Frysinger
2012-01-25  8:12               ` Srikar Dronamraju
2012-01-25  8:12                 ` Srikar Dronamraju
2012-01-10 11:48 ` [PATCH v9 3.2 3/9] uprobes: slot allocation Srikar Dronamraju
2012-01-10 11:48   ` Srikar Dronamraju
2012-01-10 11:49 ` [PATCH v9 3.2 4/9] uprobes: counter to optimize probe hits Srikar Dronamraju
2012-01-10 11:49   ` Srikar Dronamraju
2012-01-10 11:49 ` [PATCH v9 3.2 5/9] tracing: modify is_delete, is_return from ints to bool Srikar Dronamraju
2012-01-10 11:49   ` Srikar Dronamraju
2012-01-10 11:49 ` [PATCH v9 3.2 6/9] tracing: Extract out common code for kprobes/uprobes traceevents Srikar Dronamraju
2012-01-10 11:49   ` Srikar Dronamraju
2012-01-10 11:49 ` [PATCH v9 3.2 7/9] tracing: uprobes trace_event interface Srikar Dronamraju
2012-01-10 11:49   ` Srikar Dronamraju
2012-01-16 13:11   ` Jiri Olsa
2012-01-16 13:11     ` Jiri Olsa
2012-01-16 14:45     ` Srikar Dronamraju
2012-01-16 14:45       ` Srikar Dronamraju
2012-01-16 15:33       ` Jiri Olsa
2012-01-16 15:33         ` Jiri Olsa
2012-01-16 16:41         ` Srikar Dronamraju
2012-01-16 16:41           ` Srikar Dronamraju
2012-01-17  9:28     ` Ingo Molnar
2012-01-17  9:28       ` Ingo Molnar
2012-01-17 10:22       ` Srikar Dronamraju
2012-01-17 10:22         ` Srikar Dronamraju
2012-01-17 10:59         ` Ingo Molnar
2012-01-17 10:59           ` Ingo Molnar
2012-01-17 11:03           ` Srikar Dronamraju
2012-01-17 11:03             ` Srikar Dronamraju
2012-01-17 11:22         ` Ingo Molnar [this message]
2012-01-17 11:22           ` Ingo Molnar
2012-01-17 11:57           ` Srikar Dronamraju
2012-01-17 11:57             ` Srikar Dronamraju
2012-01-17 12:23             ` Ingo Molnar
2012-01-17 12:23               ` Ingo Molnar
2012-01-17 12:27               ` Ingo Molnar
2012-01-17 12:27                 ` Ingo Molnar
2012-01-17 12:11         ` Ingo Molnar
2012-01-17 12:11           ` Ingo Molnar
2012-01-17 12:21         ` Ingo Molnar
2012-01-17 12:21           ` Ingo Molnar
2012-01-18 10:07           ` Srikar Dronamraju
2012-01-18 10:07             ` Srikar Dronamraju
2012-01-10 11:49 ` [PATCH v9 3.2 8/9] perf: rename target_module to target Srikar Dronamraju
2012-01-10 11:49   ` Srikar Dronamraju
2012-01-16  8:34 ` [PATCH v9 3.2 0/9] Uprobes patchset with perf probe support Ingo Molnar
2012-01-16  8:34   ` Ingo Molnar
2012-01-16 15:17   ` Srikar Dronamraju
2012-01-16 15:17     ` Srikar Dronamraju
2012-01-17  9:39     ` Ingo Molnar
2012-01-17  9:39       ` Ingo Molnar
2012-01-25 14:11       ` Peter Zijlstra
2012-01-25 14:11         ` Peter Zijlstra
2012-01-26 11:10         ` Ingo Molnar
2012-01-26 11:10           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120117112239.GA23859@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=anton@redhat.com \
    --cc=hch@infradead.org \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=roland@hack.frob.com \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.