From: Greg KH <gregkh@suse.de>
To: Shreshtha Kumar SAHU <shreshthakumar.sahu@stericsson.com>
Cc: linux-serial@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amba-pl011: do not disable RTS during shutdown
Date: Tue, 17 Jan 2012 07:41:23 -0800 [thread overview]
Message-ID: <20120117154123.GA13296@suse.de> (raw)
In-Reply-To: <1326796189-21722-1-git-send-email-shreshthakumar.sahu@stericsson.com>
On Tue, Jan 17, 2012 at 03:59:49PM +0530, Shreshtha Kumar SAHU wrote:
> From: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
>
> In present driver, shutdown clears RTS in CR register. But the
> documentation "Documentation/serial/driver" suggests not to
> disable RTS in shutdown(). Also RTS is preserved between shutdown
> and startup calls, i.e. it is restored in startup if it was enabled
> during shutdown. So that if autorts is set and RTS is set using
> pl011_set_mctrl then it should continue even after shutdown->startup
> sequence. And hence during set_termios it will enable RTS only if RTS
> bit is set in UARTx_CR register. For throttling/unthrottling user
> should call pl011_set_mctrl.
>
> Change-Id: I743f33fb10e7e655657cd5dae1ec585e914a65bc
What is this field, and why would we want it in the kernel.org
changelogs?
Please remove it. Same goes for your other patch.
greg k-h
next prev parent reply other threads:[~2012-01-17 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 10:29 [PATCH] amba-pl011: do not disable RTS during shutdown Shreshtha Kumar SAHU
2012-01-17 10:29 ` Shreshtha Kumar SAHU
2012-01-17 15:41 ` Greg KH [this message]
2012-01-17 18:40 ` Russell King
2012-01-18 9:36 ` Shreshtha Kumar SAHU
2012-01-18 9:45 ` Shreshtha Kumar SAHU
2012-01-18 10:10 ` Russell King
2012-01-18 10:23 ` Shreshtha Kumar SAHU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117154123.GA13296@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=shreshthakumar.sahu@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.