* [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
@ 2012-01-17 20:48 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2012-01-17 20:48 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, kernel-janitors
kmemcheck complains that ->redirect_genid doesn't get initialized.
Presumably it should be set to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index 86f13c67..49ce5f4 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -447,6 +447,7 @@ relookup:
p->rate_last = 0;
p->pmtu_expires = 0;
p->pmtu_orig = 0;
+ p->redirect_genid = 0;
memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
@ 2012-01-17 20:48 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2012-01-17 20:48 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, kernel-janitors
kmemcheck complains that ->redirect_genid doesn't get initialized.
Presumably it should be set to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index 86f13c67..49ce5f4 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -447,6 +447,7 @@ relookup:
p->rate_last = 0;
p->pmtu_expires = 0;
p->pmtu_orig = 0;
+ p->redirect_genid = 0;
memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
2012-01-17 20:48 ` Dan Carpenter
@ 2012-01-17 20:52 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2012-01-17 20:52 UTC (permalink / raw)
To: dan.carpenter
Cc: eric.dumazet, kuznet, jmorris, yoshfuji, kaber, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 17 Jan 2012 23:48:43 +0300
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
It's a "don't care" until we actually get a redirect, but I've applied
your patch nonetheless.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
@ 2012-01-17 20:52 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2012-01-17 20:52 UTC (permalink / raw)
To: dan.carpenter
Cc: eric.dumazet, kuznet, jmorris, yoshfuji, kaber, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 17 Jan 2012 23:48:43 +0300
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
It's a "don't care" until we actually get a redirect, but I've applied
your patch nonetheless.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
2012-01-17 20:52 ` David Miller
@ 2012-01-17 20:58 ` Eric Dumazet
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Dumazet @ 2012-01-17 20:58 UTC (permalink / raw)
To: David Miller
Cc: dan.carpenter, kuznet, jmorris, yoshfuji, kaber, netdev,
kernel-janitors
Le mardi 17 janvier 2012 à 15:52 -0500, David Miller a écrit :
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Tue, 17 Jan 2012 23:48:43 +0300
>
> > kmemcheck complains that ->redirect_genid doesn't get initialized.
> > Presumably it should be set to zero.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> It's a "don't care" until we actually get a redirect, but I've applied
> your patch nonetheless.
>
;)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
@ 2012-01-17 20:58 ` Eric Dumazet
0 siblings, 0 replies; 8+ messages in thread
From: Eric Dumazet @ 2012-01-17 20:58 UTC (permalink / raw)
To: David Miller
Cc: dan.carpenter, kuznet, jmorris, yoshfuji, kaber, netdev,
kernel-janitors
Le mardi 17 janvier 2012 à 15:52 -0500, David Miller a écrit :
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Tue, 17 Jan 2012 23:48:43 +0300
>
> > kmemcheck complains that ->redirect_genid doesn't get initialized.
> > Presumably it should be set to zero.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> It's a "don't care" until we actually get a redirect, but I've applied
> your patch nonetheless.
>
;)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
2012-01-17 20:48 ` Dan Carpenter
@ 2012-01-17 20:57 ` Eric Dumazet
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Dumazet @ 2012-01-17 20:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, kernel-janitors
Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
> index 86f13c67..49ce5f4 100644
> --- a/net/ipv4/inetpeer.c
> +++ b/net/ipv4/inetpeer.c
> @@ -447,6 +447,7 @@ relookup:
> p->rate_last = 0;
> p->pmtu_expires = 0;
> p->pmtu_orig = 0;
> + p->redirect_genid = 0;
> memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
>
>
We dont really care, since we force redirect_learned.a4 to be 0
Only place we care is in ip_rt_redirect() and its done properly there.
Lets shutup kmemcheck.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
@ 2012-01-17 20:57 ` Eric Dumazet
0 siblings, 0 replies; 8+ messages in thread
From: Eric Dumazet @ 2012-01-17 20:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, kernel-janitors
Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
> index 86f13c67..49ce5f4 100644
> --- a/net/ipv4/inetpeer.c
> +++ b/net/ipv4/inetpeer.c
> @@ -447,6 +447,7 @@ relookup:
> p->rate_last = 0;
> p->pmtu_expires = 0;
> p->pmtu_orig = 0;
> + p->redirect_genid = 0;
> memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
>
>
We dont really care, since we force redirect_learned.a4 to be 0
Only place we care is in ip_rt_redirect() and its done properly there.
Lets shutup kmemcheck.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-01-17 20:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 20:48 [patch] inetpeer: initialize ->redirect_genid in inet_getpeer() Dan Carpenter
2012-01-17 20:48 ` Dan Carpenter
2012-01-17 20:52 ` David Miller
2012-01-17 20:52 ` David Miller
2012-01-17 20:58 ` Eric Dumazet
2012-01-17 20:58 ` Eric Dumazet
2012-01-17 20:57 ` Eric Dumazet
2012-01-17 20:57 ` Eric Dumazet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.