From: Al Viro <viro@ZenIV.linux.org.uk>
To: N?meth M?rton <nm127@freemail.hu>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Linus Walleij <linus.walleij@stericsson.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: PATCH] use void __iomem * pointers for ioread32()/iowrite32()
Date: Wed, 18 Jan 2012 06:18:15 +0000 [thread overview]
Message-ID: <20120118061815.GY23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4F16611E.3050303@freemail.hu>
On Wed, Jan 18, 2012 at 07:05:18AM +0100, N?meth M?rton wrote:
> From: M?rton N?meth <nm127@freemail.hu>
>
> The address pointer of ioread32()/iowrite32() functions are
> of type "void __iomem *". Use matching variable type.
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 68fa55e..84b7f28 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
> static int pch_irq_type(struct irq_data *d, unsigned int type)
> {
> u32 im;
> - u32 __iomem *im_reg;
> + void __iomem *im_reg;
NAK. Please, learn what "function with pointer to (possibly qualified) void"
means. It's fairly basic C, so any (post-K&R) textbook would do.
next prev parent reply other threads:[~2012-01-18 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 10:32 [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage Németh Márton
2012-01-17 8:14 ` Linus Walleij
2012-01-17 8:32 ` Németh Márton
2012-01-17 9:01 ` Linus Walleij
2012-01-17 20:43 ` [PATCH 1/2 v2] " Németh Márton
2012-01-17 22:49 ` [PATCH 1/2] " Grant Likely
2012-01-18 6:05 ` PATCH] use void __iomem * pointers for ioread32()/iowrite32() Németh Márton
2012-01-18 6:18 ` Al Viro [this message]
2012-01-18 21:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118061815.GY23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.