From: "Németh Márton" <nm127@freemail.hu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage
Date: Tue, 17 Jan 2012 09:32:33 +0100 [thread overview]
Message-ID: <4F153221.3080509@freemail.hu> (raw)
In-Reply-To: <CACRpkdZ0osKrjTXsV96J5ckj=wC=OieHL7UTfjtm8ibHRuL6=A@mail.gmail.com>
Hi Linux,
Linus Walleij wrote:
> 2012/1/15 Németh Márton <nm127@freemail.hu>:
>
>> From: Márton Németh <nm127@freemail.hu>
>>
>> The __iomem annotation is to be used together with pointers used
>> as iowrite32() parameter. For more details see [1] and [2].
> (...)
>> - u32 *im_reg;
>> + u32 __iomem *im_reg;
>
> Does it work to just say void __iomem *im_reg?
>
> We usually don't type addresses.
You are right, the correct one should be "void __iomem *im_reg;" .
Should I resend a patch for this?
Márton Németh
next prev parent reply other threads:[~2012-01-17 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 10:32 [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage Németh Márton
2012-01-17 8:14 ` Linus Walleij
2012-01-17 8:32 ` Németh Márton [this message]
2012-01-17 9:01 ` Linus Walleij
2012-01-17 20:43 ` [PATCH 1/2 v2] " Németh Márton
2012-01-17 22:49 ` [PATCH 1/2] " Grant Likely
2012-01-18 6:05 ` PATCH] use void __iomem * pointers for ioread32()/iowrite32() Németh Márton
2012-01-18 6:18 ` Al Viro
2012-01-18 21:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F153221.3080509@freemail.hu \
--to=nm127@freemail.hu \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.