From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Huang Shijie <b32955@freescale.com>,
vinod.koul@intel.com, artem.bityutskiy@intel.com,
shijie8@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, LW@KARO-electronics.de,
alsa-devel@alsa-project.org, b29396@freescale.com
Subject: Re: [PATCH 00/10] patch set about the MXS-DMA
Date: Thu, 19 Jan 2012 10:45:13 +0100 [thread overview]
Message-ID: <20120119094513.GB2630@pengutronix.de> (raw)
In-Reply-To: <20120119091034.GH2247@S2101-09.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
> > [2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slave_sg().
>
> For the sake of bitsec, at least patches #7 and #8 need to be one patch.
> That said, if I apply the series and then check out the commit at patch
> #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break.
I'd say patch 6-10 should be squashed, simply. My personal preference is
to change #9 to simply read the register when needed and do not expand
the struct, but this is a minor thing.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
b29396@freescale.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, artem.bityutskiy@intel.com,
shijie8@gmail.com, linux-arm-kernel@lists.infradead.org,
LW@KARO-electronics.de
Subject: Re: [PATCH 00/10] patch set about the MXS-DMA
Date: Thu, 19 Jan 2012 10:45:13 +0100 [thread overview]
Message-ID: <20120119094513.GB2630@pengutronix.de> (raw)
In-Reply-To: <20120119091034.GH2247@S2101-09.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
> > [2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slave_sg().
>
> For the sake of bitsec, at least patches #7 and #8 need to be one patch.
> That said, if I apply the series and then check out the commit at patch
> #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break.
I'd say patch 6-10 should be squashed, simply. My personal preference is
to change #9 to simply read the register when needed and do not expand
the struct, but this is a minor thing.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/10] patch set about the MXS-DMA
Date: Thu, 19 Jan 2012 10:45:13 +0100 [thread overview]
Message-ID: <20120119094513.GB2630@pengutronix.de> (raw)
In-Reply-To: <20120119091034.GH2247@S2101-09.ap.freescale.net>
> > [2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slave_sg().
>
> For the sake of bitsec, at least patches #7 and #8 need to be one patch.
> That said, if I apply the series and then check out the commit at patch
> #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break.
I'd say patch 6-10 should be squashed, simply. My personal preference is
to change #9 to simply read the register when needed and do not expand
the struct, but this is a minor thing.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120119/89b7a925/attachment.sig>
next prev parent reply other threads:[~2012-01-19 9:45 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 6:15 [PATCH 00/10] patch set about the MXS-DMA Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` [PATCH 01/10] MXS-DMA : move the mxs-dma.h to a more common place Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 8:58 ` Wolfram Sang
2012-01-19 8:58 ` Wolfram Sang
2012-01-19 8:58 ` Wolfram Sang
2012-01-19 8:58 ` Wolfram Sang
2012-01-19 11:20 ` Mark Brown
2012-01-19 11:20 ` Mark Brown
2012-01-19 11:20 ` Mark Brown
2012-01-19 13:04 ` Shawn Guo
2012-01-19 13:04 ` Shawn Guo
2012-01-19 13:04 ` Shawn Guo
2012-01-19 6:15 ` [PATCH 02/10] MXS-DMA : change the header Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:15 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 03/10] MXS-MMC : change the DMA header file Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 04/10] MTD/GPMI " Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 05/10] ASoc " Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 06/10] MXS-DMA : add more flags for MXS-DMA Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 9:02 ` Russell King - ARM Linux
2012-01-19 9:02 ` Russell King - ARM Linux
2012-01-19 9:02 ` Russell King - ARM Linux
2012-01-19 9:31 ` Huang Shijie
2012-01-19 9:31 ` Huang Shijie
2012-01-19 9:31 ` Huang Shijie
2012-01-19 9:31 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 07/10] MXS-DMA : change the last parameter of mxs_dma_prep_slave_sg() Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 08/10] MXS-MMC : use the new DMA flags Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 09/10] MTD/GPMI : add a new field `gpmi_version` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` [PATCH 10/10] MTD/GPMI : change the code for new DMA interface Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 6:16 ` Huang Shijie
2012-01-19 9:10 ` [PATCH 00/10] patch set about the MXS-DMA Shawn Guo
2012-01-19 9:10 ` Shawn Guo
2012-01-19 9:10 ` Shawn Guo
2012-01-19 9:45 ` Wolfram Sang [this message]
2012-01-19 9:45 ` Wolfram Sang
2012-01-19 9:45 ` Wolfram Sang
2012-01-20 3:29 ` Huang Shijie
2012-01-20 3:29 ` Huang Shijie
2012-01-20 3:29 ` Huang Shijie
2012-01-20 3:29 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119094513.GB2630@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=artem.bityutskiy@intel.com \
--cc=b29396@freescale.com \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.