From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
To: Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Fri, 20 Jan 2012 17:01:28 +0100 [thread overview]
Message-ID: <20120120160128.GF2205@amd.com> (raw)
In-Reply-To: <201201191727.10176.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
On Thu, Jan 19, 2012 at 05:27:09PM +0100, Laurent Pinchart wrote:
> > Well, u64 is a catch-all datatype which should suit all drivers. Is this
> > a problem at ARM?
>
> No, it's not a problem for ARM, at least to my knowledge. It just struck me as
> weird, as we have specific data types for other kinds of addresses (such as
> dma_addr_t).
Okay, I looked at the definition and dma_addr_t seems like a good fit.
To be consistent we should change the iova type of the map/unmap
functions to dma_addr_t too.
Regards,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joerg.roedel@amd.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>, Stuart Yoder <b08248@gmail.com>,
Scott Wood <scottwood@freescale.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Fri, 20 Jan 2012 17:01:28 +0100 [thread overview]
Message-ID: <20120120160128.GF2205@amd.com> (raw)
In-Reply-To: <201201191727.10176.laurent.pinchart@ideasonboard.com>
On Thu, Jan 19, 2012 at 05:27:09PM +0100, Laurent Pinchart wrote:
> > Well, u64 is a catch-all datatype which should suit all drivers. Is this
> > a problem at ARM?
>
> No, it's not a problem for ARM, at least to my knowledge. It just struck me as
> weird, as we have specific data types for other kinds of addresses (such as
> dma_addr_t).
Okay, I looked at the definition and dma_addr_t seems like a good fit.
To be consistent we should change the iova type of the map/unmap
functions to dma_addr_t too.
Regards,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-01-20 16:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 14:30 [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware Joerg Roedel
2012-01-19 14:30 ` [PATCH 1/5] iommu: Add domain-attribute handlers Joerg Roedel
2012-01-19 14:30 ` [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Joerg Roedel
2012-01-19 15:46 ` Laurent Pinchart
2012-01-19 16:07 ` Joerg Roedel
2012-01-19 16:27 ` Laurent Pinchart
[not found] ` <201201191727.10176.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2012-01-20 5:44 ` Hiroshi Doyu
2012-01-20 5:44 ` Hiroshi Doyu
2012-01-20 16:01 ` Joerg Roedel [this message]
2012-01-20 16:01 ` Joerg Roedel
[not found] ` <20120120160128.GF2205-5C7GfCeVMHo@public.gmane.org>
2012-02-01 9:37 ` Sethi Varun-B16395
2012-02-01 9:37 ` Sethi Varun-B16395
2012-01-26 18:26 ` Scott Wood
2012-01-26 18:26 ` Scott Wood
[not found] ` <1326983405-319-3-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2012-01-19 17:16 ` Sethi Varun-B16395
2012-01-19 17:16 ` Sethi Varun-B16395
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D038749-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-01-20 16:03 ` Joerg Roedel
2012-01-20 16:03 ` Joerg Roedel
2012-01-26 18:25 ` Scott Wood
2012-01-26 18:31 ` Joerg Roedel
2012-01-26 18:42 ` Scott Wood
[not found] ` <4F219E82.106-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-26 18:51 ` Joerg Roedel
2012-01-26 18:51 ` Joerg Roedel
2012-01-26 19:00 ` Scott Wood
[not found] ` <4F21A2D5.6000204-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-26 19:44 ` Joerg Roedel
2012-01-26 19:44 ` Joerg Roedel
2012-01-26 20:02 ` Scott Wood
[not found] ` <4F21B152.3010103-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-27 11:01 ` Joerg Roedel
2012-01-27 11:01 ` Joerg Roedel
2012-01-27 21:22 ` Scott Wood
[not found] ` <4F2315A3.80909-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-30 14:24 ` Joerg Roedel
2012-01-30 14:24 ` Joerg Roedel
2012-01-30 20:21 ` Scott Wood
[not found] ` <20120126185101.GJ19255-5C7GfCeVMHo@public.gmane.org>
2012-01-30 6:27 ` Sethi Varun-B16395
2012-01-30 6:27 ` Sethi Varun-B16395
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D041E81-RL0Hj/+nBVDAtPZc1oz0FK4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-01-30 14:30 ` Joerg Roedel
2012-01-30 14:30 ` Joerg Roedel
2012-01-19 14:30 ` [PATCH 3/5] iommu/vt-d: " Joerg Roedel
2012-01-19 14:30 ` [PATCH 4/5] iommu/omap: " Joerg Roedel
2012-01-19 14:30 ` [PATCH 5/5] iommu/msm: " Joerg Roedel
[not found] ` <1326983405-319-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2012-01-20 6:14 ` [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware Hiroshi Doyu
2012-01-20 6:14 ` Hiroshi Doyu
[not found] ` <20120120.081403.2268989617582455160.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-20 16:05 ` joerg.roedel-5C7GfCeVMHo
2012-01-20 16:05 ` joerg.roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120160128.GF2205@amd.com \
--to=joerg.roedel-5c7gfcevmho@public.gmane.org \
--cc=davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.