From: Andrew Morton <akpm@linux-foundation.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()
Date: Fri, 20 Jan 2012 16:04:08 -0800 [thread overview]
Message-ID: <20120120160408.9aa3b5fd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120120235508.GA17260@phenom.dumpdata.com>
On Fri, 20 Jan 2012 18:55:08 -0500
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote:
> > On Fri, 20 Jan 2012 11:09:38 -0500
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> >
> > > >
> > > > > Did you test this patch with a large amount of minors?
> > > >
> > > > Sorry I didn't do runtime test.
> > >
> > > Please do.
> >
> > The poor guy probably doesn't know how to test it and surely it would
> > be quite a lot of work for him to do so.
> >
> > Overall, it would be much more efficient if the tester of this code is
> > someone who is set up to easily apply the patch and test it. ie: the
> > code maintainer(s).
>
> <grins>
>
> This patch aside - Andrew how do you deal with a large amount of patches
> and make sure they are tested?
Not very well :(
> Is there a weekly Test Tuesday where you
> kick off your automated tests and dilligently look for any variations?
> Or is it more of compile the kernel with X features and run it for a week
> doing normal (and abnormal!) things to see if it falls over?
I build all the patches I have along with all of linux-next and boot
the thing, then use the resulting kernel for a few hours compilation
testing, then shove it all into linux-next where I naively hope that
someone else is testing things.
The coverage which is obtained this way is pretty poor.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()
Date: Fri, 20 Jan 2012 16:04:08 -0800 [thread overview]
Message-ID: <20120120160408.9aa3b5fd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120120235508.GA17260@phenom.dumpdata.com>
On Fri, 20 Jan 2012 18:55:08 -0500
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote:
> > On Fri, 20 Jan 2012 11:09:38 -0500
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> >
> > > >
> > > > > Did you test this patch with a large amount of minors?
> > > >
> > > > Sorry I didn't do runtime test.
> > >
> > > Please do.
> >
> > The poor guy probably doesn't know how to test it and surely it would
> > be quite a lot of work for him to do so.
> >
> > Overall, it would be much more efficient if the tester of this code is
> > someone who is set up to easily apply the patch and test it. ie: the
> > code maintainer(s).
>
> <grins>
>
> This patch aside - Andrew how do you deal with a large amount of patches
> and make sure they are tested?
Not very well :(
> Is there a weekly Test Tuesday where you
> kick off your automated tests and dilligently look for any variations?
> Or is it more of compile the kernel with X features and run it for a week
> doing normal (and abnormal!) things to see if it falls over?
I build all the patches I have along with all of linux-next and boot
the thing, then use the resulting kernel for a few hours compilation
testing, then shove it all into linux-next where I naively hope that
someone else is testing things.
The coverage which is obtained this way is pretty poor.
next prev parent reply other threads:[~2012-01-21 0:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 15:15 [PATCH] percpu: use bitmap_clear Akinobu Mita
2012-01-20 15:15 ` [Ocfs2-devel] [PATCH] ocfs2: use find_last_bit Akinobu Mita
2012-01-20 15:15 ` Akinobu Mita
2012-01-20 15:15 ` [PATCH] ocfs2: use bitmap_weight() Akinobu Mita
2012-01-20 15:15 ` [Ocfs2-devel] " Akinobu Mita
2012-01-20 15:15 ` [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear() Akinobu Mita
2012-01-20 15:15 ` Akinobu Mita
2012-01-20 15:27 ` Akinobu Mita
2012-01-20 15:27 ` Akinobu Mita
2012-01-20 15:28 ` Konrad Rzeszutek Wilk
2012-01-20 15:28 ` Konrad Rzeszutek Wilk
2012-01-20 15:41 ` Akinobu Mita
2012-01-20 15:41 ` Akinobu Mita
2012-01-20 16:09 ` Konrad Rzeszutek Wilk
2012-01-20 16:09 ` Konrad Rzeszutek Wilk
2012-01-20 23:11 ` Andrew Morton
2012-01-20 23:11 ` Andrew Morton
2012-01-20 23:55 ` Konrad Rzeszutek Wilk
2012-01-20 23:55 ` Konrad Rzeszutek Wilk
2012-01-21 0:04 ` Andrew Morton [this message]
2012-01-21 0:04 ` Andrew Morton
2012-01-20 15:15 ` [PATCH] hpsa: use find_first_zero_bit Akinobu Mita
2012-01-20 15:41 ` scameron
2012-01-20 15:15 ` [PATCH] sysctl: use bitmap library functions Akinobu Mita
2012-01-20 15:19 ` [PATCH] percpu: use bitmap_clear Christoph Lameter
2012-01-20 17:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120160408.9aa3b5fd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.