[lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Guenter Roeck]

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/wm831x-hwmon.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/wm831x-hwmon.c b/drivers/hwmon/wm831x-hwmon.c
index 23b44de..07cb25a 100644
--- a/drivers/hwmon/wm831x-hwmon.c
+++ b/drivers/hwmon/wm831x-hwmon.c
@@ -117,8 +117,10 @@ static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_chip_temp, NULL,
 			  WM831X_AUX_CHIP_TEMP);
 static SENSOR_DEVICE_ATTR(temp1_label, S_IRUGO, show_label, NULL,
 			  WM831X_AUX_CHIP_TEMP);
-/* Report as a voltage since conversion depends on external components
- * and that's what the ABI wants. */
+/*
+ * Report as a voltage since conversion depends on external components
+ * and that's what the ABI wants.
+ */
 static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_voltage, NULL,
 			  WM831X_AUX_BATT_TEMP);
 static SENSOR_DEVICE_ATTR(temp2_label, S_IRUGO, show_label, NULL,
-- 
1.7.5.4


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Mark Brown]

On Thu, Jan 19, 2012 at 03:56:16PM -0800, Guenter Roeck wrote:
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

I suspect you might not get a lot of the acks you're waiting for as you
didn't CC folks...

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Guenter Roeck]

On Sat, Jan 21, 2012 at 08:31:48AM -0500, Mark Brown wrote:
> On Thu, Jan 19, 2012 at 03:56:16PM -0800, Guenter Roeck wrote:
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> I suspect you might not get a lot of the acks you're waiting for as you
> didn't CC folks...
> 
I tried to add Cc: whenever there was a maintainer listed, but with that many patches
I may have overlooked some. As for this one, you are the author, but you have not
listed yourself as maintainer. Maybe you overlooked it, but how am I to know ?

I could have added authors and/or previous committers to the Cc: list, but then I
had to make the experience that some people don't like to be copied on patches and get
mad if they are.

There is always a trade-off to make. I don't like to upset people if I can avoid it
(and believe me, I do upset people all the time ;). If I don't get Acks, the patches
will just have to wait for 3.4.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Mark Brown]

On Sat, Jan 21, 2012 at 09:03:05AM -0800, Guenter Roeck wrote:

I've reflowed your text into 80 columns.

> On Sat, Jan 21, 2012 at 08:31:48AM -0500, Mark Brown wrote:

> > I suspect you might not get a lot of the acks you're waiting for as you
> > didn't CC folks...

> I tried to add Cc: whenever there was a maintainer listed, but with
> that many patches I may have overlooked some. As for this one, you are
> the author, but you have not listed yourself as maintainer. Maybe you
> overlooked it, but how am I to know ?

TBH given that I wrote the driver, work for the relevant silicon vendor
and am generally pretty active it seems odd that you would see the lack
of a MAINTAINERS entry as a lack of interest.  The people who get
annoyed about getting CCed on stuff are those doing obviously generic
janatorial work rather than those who have spent time on the particular
bit of code - if you rely on MAINTAINERS you're going to miss a lot of
people.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Guenter Roeck]

On Sat, Jan 21, 2012 at 12:47:00PM -0500, Mark Brown wrote:
> On Sat, Jan 21, 2012 at 09:03:05AM -0800, Guenter Roeck wrote:
> 
> I've reflowed your text into 80 columns.
> 
> > On Sat, Jan 21, 2012 at 08:31:48AM -0500, Mark Brown wrote:
> 
> > > I suspect you might not get a lot of the acks you're waiting for as you
> > > didn't CC folks...
> 
> > I tried to add Cc: whenever there was a maintainer listed, but with
> > that many patches I may have overlooked some. As for this one, you are
> > the author, but you have not listed yourself as maintainer. Maybe you
> > overlooked it, but how am I to know ?
> 
> TBH given that I wrote the driver, work for the relevant silicon vendor
> and am generally pretty active it seems odd that you would see the lack
> of a MAINTAINERS entry as a lack of interest.  The people who get
> annoyed about getting CCed on stuff are those doing obviously generic
> janatorial work rather than those who have spent time on the particular
> bit of code - if you rely on MAINTAINERS you're going to miss a lot of
> people.

Mark,

I don't see it as lack of interest. Sorry if you got that impression.
But I don't keep a per-driver list of active people either, and I would
need one for purposes like this one. It appears, given your input, that
having such a list on top of MAINTAINERS would be good to have, so
I'll start to create one now. This should ensure you (and hopefully others)
won't be missed in the future.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 82/82] hwmon: (wm831x-hwmon) Fix multi-line comments

[Mark Brown]

On Sat, Jan 21, 2012 at 10:11:07AM -0800, Guenter Roeck wrote:

> I don't see it as lack of interest. Sorry if you got that impression.
> But I don't keep a per-driver list of active people either, and I would
> need one for purposes like this one. It appears, given your input, that
> having such a list on top of MAINTAINERS would be good to have, so
> I'll start to create one now. This should ensure you (and hopefully others)
> won't be missed in the future.

I'd just send patches to MAINTAINERS if you find it useful to have
something, few people will object if you do that.  It rarely gets
updated for individual drivers because normally it's not needed.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors