From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()
Date: Sat, 21 Jan 2012 17:07:30 +0100 [thread overview]
Message-ID: <201201211707.30144.michael@walle.cc> (raw)
In-Reply-To: <1326523557-6818-5-git-send-email-sjg@chromium.org>
Hi Simon,
Am Samstag 14 Januar 2012, 07:45:52 schrieb Simon Glass:
> diff --git a/common/cmd_source.c b/common/cmd_source.c
> index 481241c..32fff5c 100644
> --- a/common/cmd_source.c
> +++ b/common/cmd_source.c
> @@ -179,7 +179,7 @@ source (ulong addr, const char *fit_uname)
> if (*line) {
> debug ("** exec: \"%s\"\n",
> line);
> - if (builtin_run_command(line, 0) < 0)
{
> + if (run_command(line, 0) < 0) {
> rcode = 1;
> break;
> }
> @@ -189,7 +189,7 @@ source (ulong addr, const char *fit_uname)
> ++next;
> }
> if (rcode == 0 && *line)
> - rcode = (builtin_run_command(line, 0) >= 0);
> + rcode = (run_command(line, 0) >= 0);
> }
> #endif
> free (cmd);
Please have a look at this file. There is already a conditional on
CONFIG_SYS_HUSH_PARSER, which can be removed, since it is now handled in
run_command(). Do not forget to remove the hush.h include, too.
Could you move this script handling into an own function into common/main.c?
This way others can easily execute whole scripts without duplicating this
code. I'm planning to submit support for a board which needs exactly that, so
there will be at least one board which make use of this.
Mike proposed source_commands() as a function name. My original patch named it
run_script(). Dunno whats a better name.
Feel free to reuse/incorporate my patch at
http://patchwork.ozlabs.org/patch/137122/
into your patchset ;)
--
michael
next prev parent reply other threads:[~2012-01-21 16:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 6:45 [U-Boot] [PATCH v4 0/9] Unified command execution in one place Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 1/9] Remove CMD_PXE's static on run_command() Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 2/9] Rename run_command() to builtin_run_command() Simon Glass
2012-02-05 3:19 ` Mike Frysinger
2012-02-14 22:32 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 3/9] Rename run_command2() to run_command() Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command() Simon Glass
2012-01-21 16:07 ` Michael Walle [this message]
2012-02-14 22:42 ` Simon Glass
2012-02-15 6:05 ` Simon Glass
2012-02-15 19:44 ` Michael Walle
2012-02-15 22:15 ` Simon Glass
2012-02-05 3:23 ` Mike Frysinger
2012-02-14 22:40 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 5/9] Don't include standard parser if hush is used Simon Glass
2012-02-05 3:20 ` Mike Frysinger
2012-02-14 22:33 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 6/9] Create a single cmd_call() function to handle command execution Simon Glass
2012-02-05 3:22 ` Mike Frysinger
2012-02-14 22:38 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 7/9] Remove interleave of non-U-Boot code in hush Simon Glass
2012-02-05 3:25 ` Mike Frysinger
2012-01-14 6:45 ` [U-Boot] [PATCH v4 8/9] Add cmd_process() to process commands in one place Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 9/9] Convert cmd_usage() calls in common to use a return value Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201211707.30144.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.