From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()
Date: Wed, 15 Feb 2012 20:44:49 +0100 [thread overview]
Message-ID: <201202152044.49164.michael@walle.cc> (raw)
In-Reply-To: <CAPnjgZ0JhSYRx4eP0K1-4_2zGsOZTUwNv86jiM01T24pEXiw+w@mail.gmail.com>
Am Mittwoch 15 Februar 2012, 07:05:24 schrieb Simon Glass:
> Unfortunately I think that this approach is a little broken. We are running
> a command sequence from getenv(), but while processing it, we might update
> the environment variable. Worse, we actually overwrite the newlines in the
> variable as we process it.
Isn't it as easy as copying the current content and processing that instead?
--
Michael
next prev parent reply other threads:[~2012-02-15 19:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 6:45 [U-Boot] [PATCH v4 0/9] Unified command execution in one place Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 1/9] Remove CMD_PXE's static on run_command() Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 2/9] Rename run_command() to builtin_run_command() Simon Glass
2012-02-05 3:19 ` Mike Frysinger
2012-02-14 22:32 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 3/9] Rename run_command2() to run_command() Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command() Simon Glass
2012-01-21 16:07 ` Michael Walle
2012-02-14 22:42 ` Simon Glass
2012-02-15 6:05 ` Simon Glass
2012-02-15 19:44 ` Michael Walle [this message]
2012-02-15 22:15 ` Simon Glass
2012-02-05 3:23 ` Mike Frysinger
2012-02-14 22:40 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 5/9] Don't include standard parser if hush is used Simon Glass
2012-02-05 3:20 ` Mike Frysinger
2012-02-14 22:33 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 6/9] Create a single cmd_call() function to handle command execution Simon Glass
2012-02-05 3:22 ` Mike Frysinger
2012-02-14 22:38 ` Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 7/9] Remove interleave of non-U-Boot code in hush Simon Glass
2012-02-05 3:25 ` Mike Frysinger
2012-01-14 6:45 ` [U-Boot] [PATCH v4 8/9] Add cmd_process() to process commands in one place Simon Glass
2012-01-14 6:45 ` [U-Boot] [PATCH v4 9/9] Convert cmd_usage() calls in common to use a return value Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202152044.49164.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.