* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
@ 2012-01-22 21:11 ` Guenter Roeck
2012-01-22 23:02 ` Guenter Roeck
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2012-01-22 21:11 UTC (permalink / raw)
To: lm-sensors
On Sun, Jan 22, 2012 at 01:43:08PM -0500, Mike Gorchak wrote:
> Hi All,
>
> I've recently found that lm-sensors doesn't have support for Global Mixed-mode
> Technology Inc. (GMT) G781 and G7811 temperature sensors.
>
> Overview datasheets are available on manufacturer's site: http://www.gmt.com.tw
> / , registers datasheet is available here: www.datasheetcatalog.org/datasheets2
> /35/350422_1.pdf
>
> It seems that this device is registers compatible with ADM1032. SMBus
> manufacturer id 0x47, device ids 0x01 and 0x03.
>
Should be safe to add support to the lm90 driver. Jean, any thoughts/comments ?
I seem to be unable to find a datasheet for G7811, though. We would need that to know
its I2C bus address, and for the correct device id (0x03 ?).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
2012-01-22 21:11 ` Guenter Roeck
@ 2012-01-22 23:02 ` Guenter Roeck
2012-01-23 6:02 ` Mike Gorchak
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2012-01-22 23:02 UTC (permalink / raw)
To: lm-sensors
On Sun, Jan 22, 2012 at 04:11:36PM -0500, Guenter Roeck wrote:
> On Sun, Jan 22, 2012 at 01:43:08PM -0500, Mike Gorchak wrote:
> > Hi All,
> >
> > I've recently found that lm-sensors doesn't have support for Global Mixed-mode
> > Technology Inc. (GMT) G781 and G7811 temperature sensors.
> >
> > Overview datasheets are available on manufacturer's site: http://www.gmt.com.tw
> > / , registers datasheet is available here: www.datasheetcatalog.org/datasheets2
> > /35/350422_1.pdf
> >
> > It seems that this device is registers compatible with ADM1032. SMBus
> > manufacturer id 0x47, device ids 0x01 and 0x03.
> >
> Should be safe to add support to the lm90 driver. Jean, any thoughts/comments ?
>
> I seem to be unable to find a datasheet for G7811, though. We would need that to know
> its I2C bus address, and for the correct device id (0x03 ?).
>
Hi Mike,
never mind; no idea if G7811 ever really existed. I found version 1.3 of the datasheet which
describes both G781 and G781-1. Can you test the driver and sensors-detect if I send you
a pointer to the code ?
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
2012-01-22 21:11 ` Guenter Roeck
2012-01-22 23:02 ` Guenter Roeck
@ 2012-01-23 6:02 ` Mike Gorchak
2012-01-23 7:06 ` Guenter Roeck
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Mike Gorchak @ 2012-01-23 6:02 UTC (permalink / raw)
To: lm-sensors
Hello, Guenter!
GR> never mind; no idea if G7811 ever really existed. I found version 1.3
GR> of the datasheet which describes both G781 and G781-1. Can you test the
GR> driver and sensors-detect if I send you a pointer to the code ?
It seems that this patch is ok, except for one thing.
Let me explain what I did. I added support for ACPI SMBus connected to
Embedded Controller to the lm-sensors (for a netbook without proper ACPI
support). There are two G781 sensors connected to this bus, one to the
address 0x4C and one to the 0x4D. Both sensors have 0x01 as device id. But
patch assumes that only G781-1 can be connected to the 0x4D address.
Thanks for the fast answer! :)
With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (2 preceding siblings ...)
2012-01-23 6:02 ` Mike Gorchak
@ 2012-01-23 7:06 ` Guenter Roeck
2012-01-23 7:13 ` Mike Gorchak
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2012-01-23 7:06 UTC (permalink / raw)
To: lm-sensors
On Mon, Jan 23, 2012 at 01:02:20AM -0500, Mike Gorchak wrote:
> Hello, Guenter!
>
> GR> never mind; no idea if G7811 ever really existed. I found version 1.3
> GR> of the datasheet which describes both G781 and G781-1. Can you test the
> GR> driver and sensors-detect if I send you a pointer to the code ?
>
> It seems that this patch is ok, except for one thing.
>
> Let me explain what I did. I added support for ACPI SMBus connected to
> Embedded Controller to the lm-sensors (for a netbook without proper ACPI
> support). There are two G781 sensors connected to this bus, one to the
> address 0x4C and one to the 0x4D. Both sensors have 0x01 as device id. But
> patch assumes that only G781-1 can be connected to the 0x4D address.
>
> Thanks for the fast answer! :)
>
> With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
>
Hi Mike,
can you send me the output of i2cdump for both chips ?
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (3 preceding siblings ...)
2012-01-23 7:06 ` Guenter Roeck
@ 2012-01-23 7:13 ` Mike Gorchak
2012-01-23 7:16 ` Mike Gorchak
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Mike Gorchak @ 2012-01-23 7:13 UTC (permalink / raw)
To: lm-sensors
Hello, Guenter!
GR>>> never mind; no idea if G7811 ever really existed. I found version 1.3
GR>>> of the datasheet which describes both G781 and G781-1. Can you test
GR>>> the driver and sensors-detect if I send you a pointer to the code ?
??>>
??>> It seems that this patch is ok, except for one thing.
??>>
??>> Let me explain what I did. I added support for ACPI SMBus connected to
??>> Embedded Controller to the lm-sensors (for a netbook without proper
??>> ACPI support). There are two G781 sensors connected to this bus, one
??>> to the address 0x4C and one to the 0x4D. Both sensors have 0x01 as
??>> device id. But patch assumes that only G781-1 can be connected to the
??>> 0x4D address.
??>>
??>> Thanks for the fast answer! :)
??>>
??>> With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
??>>
GR> Hi Mike,
GR> can you send me the output of i2cdump for both chips ?
Of course, but output is produced by another utility with similair behavior.
Found device presence at address 0x4C
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | 14 23 00 00 04 73 C0 73 C0 00 04 73 C0 73 C0 14
.#...s.s...s.s..
10 | 30 00 00 00 00 14 14 14 14 73 14 14 14 14 14 14
0........s......
20 | 73 0A 00 14 14 14 14 14 14 14 14 14 14 14 14 14
s...............
30 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
40 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
50 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
60 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
70 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
80 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
90 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
A0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
B0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
C0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
D0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
E0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14
................
F0 | 14 06 FF 00 FF 00 00 FF 14 14 14 14 14 14 47 01
..............G.
Found device presence at address 0x4D
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | 11 0D 80 00 08 55 00 55 00 00 08 55 00 55 00 11
.....U.U...U.U..
10 | D0 00 00 00 00 11 11 11 11 55 11 11 11 11 11 11
.........U......
20 | 55 0A 00 11 11 11 11 11 11 11 11 11 11 11 11 11
U...............
30 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
40 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
50 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
60 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
70 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
80 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
90 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
A0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
B0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
C0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
D0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
E0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11
................
F0 | 11 06 FF 00 FF E0 00 FF 11 11 11 11 11 11 47 01
..............G.
Thanks!
With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (4 preceding siblings ...)
2012-01-23 7:13 ` Mike Gorchak
@ 2012-01-23 7:16 ` Mike Gorchak
2012-01-23 7:55 ` Jean Delvare
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Mike Gorchak @ 2012-01-23 7:16 UTC (permalink / raw)
To: lm-sensors
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
Hello, Guenter!
GR> can you send me the output of i2cdump for both chips ?
Sorry for the previous message, it looks like dump has been clobbered. The
same in the attachment.
With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
[-- Attachment #2: ec_smbus.txt --]
[-- Type: text/plain, Size: 7430 bytes --]
Found SMBUS0
Found Smart Battery Charger at address 0x09
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
10 | -- 01 -- 32 -- -- -- -- -- -- -- -- -- -- -- -- -.-2------------
20 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
30 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
40 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
50 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
60 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
70 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
80 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
90 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
A0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
B0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
C0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
D0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
E0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
F0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
Found Smart Battery Selector/Manager at address 0x0A
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | -- 01 11 -- 11 -- -- -- -- -- -- -- -- -- -- -- -..-.-----------
10 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
20 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
30 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
40 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
50 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
60 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
70 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
80 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
90 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
A0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
B0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
C0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
D0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
E0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
F0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
Found Smart Battery at address 0x0B
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | EF 53 0A 01 00 FF -- -- 41 8A 1D 25 0A 63 63 22 .S....--A..%.cc"
10 | 3E 25 28 FF DC C0 47 2F 3E 30 10 B2 A2 -- -- -- >%(...G/>0...---
20 | 0A 0B 04 03 -- -- -- -- -- -- -- -- -- -- -- 0D ....-----------.
30 | 08 04 -- -- -- -- -- -- -- -- -- -- 00 00 02 C0 ..----------....
40 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- FF ---------------.
50 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
60 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
70 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
80 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
90 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
A0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
B0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
C0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
D0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
E0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
F0 | -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- ----------------
Found Sensor Chip at address 0x4C
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | 14 23 00 00 04 73 C0 73 C0 00 04 73 C0 73 C0 14 .#...s.s...s.s..
10 | 30 00 00 00 00 14 14 14 14 73 14 14 14 14 14 14 0........s......
20 | 73 0A 00 14 14 14 14 14 14 14 14 14 14 14 14 14 s...............
30 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
40 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
50 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
60 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
70 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
80 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
90 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
A0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
B0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
C0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
D0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
E0 | 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 14 ................
F0 | 14 06 FF 00 FF 00 00 FF 14 14 14 14 14 14 47 01 ..............G.
Found Sensor Chip at address 0x4D
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
------------------------------------------------------------------------
00 | 11 0D 80 00 08 55 00 55 00 00 08 55 00 55 00 11 .....U.U...U.U..
10 | D0 00 00 00 00 11 11 11 11 55 11 11 11 11 11 11 .........U......
20 | 55 0A 00 11 11 11 11 11 11 11 11 11 11 11 11 11 U...............
30 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
40 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
50 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
60 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
70 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
80 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
90 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
A0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
B0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
C0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
D0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
E0 | 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 11 ................
F0 | 11 06 FF 00 FF E0 00 FF 11 11 11 11 11 11 47 01 ..............G.
[-- Attachment #3: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (5 preceding siblings ...)
2012-01-23 7:16 ` Mike Gorchak
@ 2012-01-23 7:55 ` Jean Delvare
2012-01-23 7:59 ` Mike Gorchak
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Jean Delvare @ 2012-01-23 7:55 UTC (permalink / raw)
To: lm-sensors
On Mon, 23 Jan 2012 08:02:20 +0200, Mike Gorchak wrote:
> Hello, Guenter!
>
> GR> never mind; no idea if G7811 ever really existed. I found version 1.3
> GR> of the datasheet which describes both G781 and G781-1. Can you test the
> GR> driver and sensors-detect if I send you a pointer to the code ?
>
> It seems that this patch is ok, except for one thing.
>
> Let me explain what I did. I added support for ACPI SMBus connected to
> Embedded Controller to the lm-sensors (for a netbook without proper ACPI
> support). There are two G781 sensors connected to this bus, one to the
> address 0x4C and one to the 0x4D. Both sensors have 0x01 as device id. But
> patch assumes that only G781-1 can be connected to the 0x4D address.
If they followed a naming logic similar to National Semiconductor, G781
will have address 0x4C and G781-1 will have address 0x4D. They are
basically the exact same chip except for the address, so the driver
doesn't even need to know, other than the fact that both addresses 0x4C
and 0x4D are possible.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (6 preceding siblings ...)
2012-01-23 7:55 ` Jean Delvare
@ 2012-01-23 7:59 ` Mike Gorchak
2012-01-23 8:36 ` Jean Delvare
2012-01-23 9:11 ` Jean Delvare
9 siblings, 0 replies; 11+ messages in thread
From: Mike Gorchak @ 2012-01-23 7:59 UTC (permalink / raw)
To: lm-sensors
Hello, Jean!
GR>>> never mind; no idea if G7811 ever really existed. I found version 1.3
GR>>> of the datasheet which describes both G781 and G781-1. Can you test
GR>>> the driver and sensors-detect if I send you a pointer to the code ?
??>> It seems that this patch is ok, except for one thing.
??>> Let me explain what I did. I added support for ACPI SMBus connected to
??>> Embedded Controller to the lm-sensors (for a netbook without proper
??>> ACPI support). There are two G781 sensors connected to this bus, one
??>> to the address 0x4C and one to the 0x4D. Both sensors have 0x01 as
??>> device id. But patch assumes that only G781-1 can be connected to the
??>> 0x4D address.
JD> If they followed a naming logic similar to National Semiconductor, G781
JD> will have address 0x4C and G781-1 will have address 0x4D. They are
JD> basically the exact same chip except for the address, so the driver
JD> doesn't even need to know, other than the fact that both addresses 0x4C
JD> and 0x4D are possible.
Now driver checks only for 0x03 device id at address 0x4D, which is not
correct. 0x01 device id can be present at 0x4D address too. That's all I'd
like to say :)
With best regards, Mike Gorchak. E-mail: lestat@i.com.ua
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (7 preceding siblings ...)
2012-01-23 7:59 ` Mike Gorchak
@ 2012-01-23 8:36 ` Jean Delvare
2012-01-23 9:11 ` Jean Delvare
9 siblings, 0 replies; 11+ messages in thread
From: Jean Delvare @ 2012-01-23 8:36 UTC (permalink / raw)
To: lm-sensors
On Sun, 22 Jan 2012 13:11:36 -0800, Guenter Roeck wrote:
> On Sun, Jan 22, 2012 at 01:43:08PM -0500, Mike Gorchak wrote:
> > Hi All,
> >
> > I've recently found that lm-sensors doesn't have support for Global Mixed-mode
> > Technology Inc. (GMT) G781 and G7811 temperature sensors.
> >
> > Overview datasheets are available on manufacturer's site: http://www.gmt.com.tw
> > / , registers datasheet is available here: www.datasheetcatalog.org/datasheets2
> > /35/350422_1.pdf
> >
> > It seems that this device is registers compatible with ADM1032. SMBus
> > manufacturer id 0x47, device ids 0x01 and 0x03.
>
> Should be safe to add support to the lm90 driver. Jean, any thoughts/comments ?
Indeed the G781 seems compatible with the other chips supported by the
lm90 driver, adding support to that driver sounds good. I'll gladly
review any patch.
> I seem to be unable to find a datasheet for G7811, though. We would need that to know
> its I2C bus address, and for the correct device id (0x03 ?).
GMT have a product sheet for the G7811 so it probably exists:
http://www.gmt.com.tw/product/datasheet/EDS-7811.pdf
Not enough to check for compatibility or write a proper driver though.
But its lack of remote sensor means it can't be fully compatible with
the ADM1032 anyway. Until we receive a formal support request and get a
datasheet (or at the very least a register dump) I think we can just
ignore the G7811.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors.
2012-01-22 18:43 [lm-sensors] Support for SMBus based GMT G781 and G7811 temperature sensors Mike Gorchak
` (8 preceding siblings ...)
2012-01-23 8:36 ` Jean Delvare
@ 2012-01-23 9:11 ` Jean Delvare
9 siblings, 0 replies; 11+ messages in thread
From: Jean Delvare @ 2012-01-23 9:11 UTC (permalink / raw)
To: lm-sensors
On Mon, 23 Jan 2012 09:59:43 +0200, Mike Gorchak wrote:
> Hello, Jean!
>
> GR>>> never mind; no idea if G7811 ever really existed. I found version 1.3
> GR>>> of the datasheet which describes both G781 and G781-1. Can you test
> GR>>> the driver and sensors-detect if I send you a pointer to the code ?
> ??>> It seems that this patch is ok, except for one thing.
> ??>> Let me explain what I did. I added support for ACPI SMBus connected to
> ??>> Embedded Controller to the lm-sensors (for a netbook without proper
> ??>> ACPI support). There are two G781 sensors connected to this bus, one
> ??>> to the address 0x4C and one to the 0x4D. Both sensors have 0x01 as
> ??>> device id. But patch assumes that only G781-1 can be connected to the
> ??>> 0x4D address.
> JD> If they followed a naming logic similar to National Semiconductor, G781
> JD> will have address 0x4C and G781-1 will have address 0x4D. They are
> JD> basically the exact same chip except for the address, so the driver
> JD> doesn't even need to know, other than the fact that both addresses 0x4C
> JD> and 0x4D are possible.
>
> Now driver checks only for 0x03 device id at address 0x4D, which is not
> correct. 0x01 device id can be present at 0x4D address too. That's all I'd
> like to say :)
Yes, yes, I agree and I'm sure Guenter does as well. Just give me a
moment to review his two patches, and then wait for him to wake up, get
dressed, have coffee or whatever, and resubmit ;)
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 11+ messages in thread