* [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places
@ 2012-01-23 3:18 Axel Lin
2012-01-23 9:39 ` Leon Romanovsky
2012-01-23 10:21 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-01-23 3:18 UTC (permalink / raw)
To: alsa-devel
Cc: Arnaud, Mark Brown, Leon Romanovsky, Andrey Danin, Liam Girdwood,
Patard
Fix below build warning when CONFIG_HOTPLUG is not set.
CC sound/soc/codecs/alc5623.o
sound/soc/codecs/alc5623.c:1062: warning: ‘alc5623_i2c_remove’ defined but not used
CC sound/soc/codecs/alc5632.o
sound/soc/codecs/alc5632.c:1112: warning: ‘alc5632_i2c_remove’ defined but not used
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/alc5623.c | 4 ++--
sound/soc/codecs/alc5632.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
index 3feee56..08f2419 100644
--- a/sound/soc/codecs/alc5623.c
+++ b/sound/soc/codecs/alc5623.c
@@ -992,7 +992,7 @@ static struct snd_soc_codec_driver soc_codec_device_alc5623 = {
* low = 0x1a
* high = 0x1b
*/
-static int alc5623_i2c_probe(struct i2c_client *client,
+static __devinit int alc5623_i2c_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct alc5623_platform_data *pdata;
@@ -1059,7 +1059,7 @@ static int alc5623_i2c_probe(struct i2c_client *client,
return ret;
}
-static int alc5623_i2c_remove(struct i2c_client *client)
+static __devexit int alc5623_i2c_remove(struct i2c_client *client)
{
snd_soc_unregister_codec(&client->dev);
return 0;
diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
index 390e437..af9c27a 100644
--- a/sound/soc/codecs/alc5632.c
+++ b/sound/soc/codecs/alc5632.c
@@ -1109,7 +1109,7 @@ static __devinit int alc5632_i2c_probe(struct i2c_client *client,
return ret;
}
-static int alc5632_i2c_remove(struct i2c_client *client)
+static __devexit int alc5632_i2c_remove(struct i2c_client *client)
{
struct alc5632_priv *alc5632 = i2c_get_clientdata(client);
snd_soc_unregister_codec(&client->dev);
--
1.7.5.4
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places
2012-01-23 3:18 [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places Axel Lin
@ 2012-01-23 9:39 ` Leon Romanovsky
2012-01-23 10:21 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2012-01-23 9:39 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Andrey Danin, Liam Girdwood, Arnaud Patard,
Mark Brown
On Mon, Jan 23, 2012 at 05:18, Axel Lin <axel.lin@gmail.com> wrote:
> Fix below build warning when CONFIG_HOTPLUG is not set.
>
> CC sound/soc/codecs/alc5623.o
> sound/soc/codecs/alc5623.c:1062: warning: ‘alc5623_i2c_remove’ defined but not used
> CC sound/soc/codecs/alc5632.o
> sound/soc/codecs/alc5632.c:1112: warning: ‘alc5632_i2c_remove’ defined but not used
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/alc5623.c | 4 ++--
> sound/soc/codecs/alc5632.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
> index 3feee56..08f2419 100644
> --- a/sound/soc/codecs/alc5623.c
> +++ b/sound/soc/codecs/alc5623.c
> @@ -992,7 +992,7 @@ static struct snd_soc_codec_driver soc_codec_device_alc5623 = {
> * low = 0x1a
> * high = 0x1b
> */
> -static int alc5623_i2c_probe(struct i2c_client *client,
> +static __devinit int alc5623_i2c_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct alc5623_platform_data *pdata;
> @@ -1059,7 +1059,7 @@ static int alc5623_i2c_probe(struct i2c_client *client,
> return ret;
> }
>
> -static int alc5623_i2c_remove(struct i2c_client *client)
> +static __devexit int alc5623_i2c_remove(struct i2c_client *client)
> {
> snd_soc_unregister_codec(&client->dev);
> return 0;
> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
> index 390e437..af9c27a 100644
> --- a/sound/soc/codecs/alc5632.c
> +++ b/sound/soc/codecs/alc5632.c
> @@ -1109,7 +1109,7 @@ static __devinit int alc5632_i2c_probe(struct i2c_client *client,
> return ret;
> }
>
> -static int alc5632_i2c_remove(struct i2c_client *client)
> +static __devexit int alc5632_i2c_remove(struct i2c_client *client)
> {
> struct alc5632_priv *alc5632 = i2c_get_clientdata(client);
> snd_soc_unregister_codec(&client->dev);
> --
> 1.7.5.4
Thanks.
Acked-by: Leon Romanovsky <leon@leon.nu>
>
>
>
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon@leon.nu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places
2012-01-23 3:18 [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places Axel Lin
2012-01-23 9:39 ` Leon Romanovsky
@ 2012-01-23 10:21 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-01-23 10:21 UTC (permalink / raw)
To: Axel Lin
Cc: alsa-devel, Andrey Danin, Leon Romanovsky, Arnaud Patard,
Liam Girdwood
On Mon, Jan 23, 2012 at 11:18:17AM +0800, Axel Lin wrote:
> Fix below build warning when CONFIG_HOTPLUG is not set.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-23 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-23 3:18 [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places Axel Lin
2012-01-23 9:39 ` Leon Romanovsky
2012-01-23 10:21 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.