All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Jones <drjones@redhat.com>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps
Date: Mon, 23 Jan 2012 13:35:53 -0500	[thread overview]
Message-ID: <20120123183553.GB12542@phenom.dumpdata.com> (raw)
In-Reply-To: <1325842991-4404-3-git-send-email-drjones@redhat.com>

On Fri, Jan 06, 2012 at 10:43:09AM +0100, Andrew Jones wrote:
> PV-on-HVM guests may want to use the xen keyboard/mouse frontend, but
> they don't use the xen frame buffer frontend. For this case it doesn't
> make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on
> XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, i.e.
> if you're using xenfb, then you'll want xenkbd. Switch the dependencies.

This looks OK. Let me test this out to see if there is any silly
fallout.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  drivers/input/misc/Kconfig |    2 +-
>  drivers/video/Kconfig      |    1 +
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 22d875f..36c15bf 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C
>  
>  config INPUT_XEN_KBDDEV_FRONTEND
>  	tristate "Xen virtual keyboard and mouse support"
> -	depends on XEN_FBDEV_FRONTEND
> +	depends on XEN
>  	default y
>  	select XEN_XENBUS_FRONTEND
>  	help
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index d83e967..269b299 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -2269,6 +2269,7 @@ config XEN_FBDEV_FRONTEND
>  	select FB_SYS_IMAGEBLIT
>  	select FB_SYS_FOPS
>  	select FB_DEFERRED_IO
> +	select INPUT_XEN_KBDDEV_FRONTEND
>  	select XEN_XENBUS_FRONTEND
>  	default y
>  	help
> -- 
> 1.7.7.5

  parent reply	other threads:[~2012-01-23 18:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06  9:43 [PATCH 0/4] xen kconfig tweaks Andrew Jones
2012-01-06  9:43 ` [PATCH 1/4] xen kconfig: keep XEN_XENBUS_FRONTEND builtin Andrew Jones
2012-01-06  9:43 ` [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps Andrew Jones
2012-01-06 15:46   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-01-06 15:58     ` Andrew Jones
2012-01-09  7:59       ` [Xen-devel] " Dmitry Torokhov
2012-01-09  7:59       ` Dmitry Torokhov
2012-01-09 10:43         ` [Xen-devel] " Andrew Jones
2012-01-09 17:51           ` [PATCH 2/4 v2] " Andrew Jones
2012-01-11 16:11             ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-01-11 16:29               ` Andrew Jones
2012-03-15 17:23                 ` Konrad Rzeszutek Wilk
2012-03-16  6:24                   ` Dmitry Torokhov
2012-03-16 14:48                     ` Konrad Rzeszutek Wilk
2012-01-23 18:35   ` Konrad Rzeszutek Wilk [this message]
2012-01-06  9:43 ` [PATCH 3/4] xen kconfig: add dom0 support help text Andrew Jones
2012-01-09 18:07   ` [PATCH 3/4 v2] " Andrew Jones
2012-01-11 15:45     ` [Xen-devel] " Andrew Jones
2012-01-23 18:42   ` [PATCH 3/4] " Konrad Rzeszutek Wilk
2012-01-06  9:43 ` [PATCH 4/4] xen kconfig: describe xen tmem in the config menu Andrew Jones
2012-01-23 18:34   ` Konrad Rzeszutek Wilk
2012-01-23 18:34     ` Konrad Rzeszutek Wilk
2012-01-24  8:30     ` [Xen-devel] " Igor Mammedov
2012-01-24  8:30     ` Igor Mammedov
2012-01-24 17:38       ` [Xen-devel] " Konrad Rzeszutek Wilk
  -- strict thread matches above, loose matches on Subject: below --
2012-01-06  8:57 [PATCH 0/4] xen kconfig tweaks Andrew Jones
2012-01-06  8:57 ` [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps Andrew Jones
2012-01-06 10:38   ` Stefano Stabellini
2012-01-06 10:42     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120123183553.GB12542@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=drjones@redhat.com \
    --cc=jeremy@goop.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.