Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Thu, Mar 15, 2012 at 11:24:28PM -0700, Dmitry Torokhov wrote:
> On Thu, Mar 15, 2012 at 01:23:05PM -0400, Konrad Rzeszutek Wilk wrote:
> > On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote:
> > > 
> > > 
> > > ----- Original Message -----
> > > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote:
> > > > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend,
> > > > > but
> > > > > they don't use the xen frame buffer frontend. For this case it
> > > > > doesn't
> > > > 
> > > > Ok, but PV does?
> > > > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on
> > > > > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense,
> > > > > i.e.
> > > > > if you're using xenfb, then you'll want xenkbd. Switch the
> > > > > dependencies.
> > > > 
> > > > That sounds like it would be universal irregardless if it is
> > > > PV or PVonHVM?
> > > 
> > > This patch makes it such that if you want to use both, then you must
> > > select both. It also says that if you want FB, then you need the
> > > KBD. However, if you only want the KBD then you're fine with just
> > > that. So there isn't any risk of breaking configs designed to use
> > > FB, because FB should be manually selected for those configs anyway.
> > 
> > Dmitry,
> > 
> > I am OK with this patch. Should I pick it up on my tree for 3.4 or
> > are you OK doing it via your tree?
> 
> Konrad,
> 
> I don't have a good copy of the patch so it you could pick it up that
> would be great.

OK, will stick you Ack on it. Thx!
> 
> Thanks.
> 
> -- 
> Dmitry
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel