From: Wolfram Sang <w.sang@pengutronix.de>
To: "Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Cc: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Datta, Shubhrajyoti" <shubhrajyoti@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+
Date: Tue, 24 Jan 2012 10:33:18 +0100 [thread overview]
Message-ID: <20120124093318.GA2609@pengutronix.de> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D12143317902D6@DBDE01.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
> Just returning the register content does not help much and looking at other
> implementations, like Blackfin, I am guessing this IOCTL is supposed to give
> a yes/no sort of result.
It needs to return WDIOF_* flags as defined in include/linux/watchdog.h.
Check also Documentation/watchdog/watchdog-api.txt for further info.
Yes, not all drivers follow this style, sadly.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+
Date: Tue, 24 Jan 2012 10:33:18 +0100 [thread overview]
Message-ID: <20120124093318.GA2609@pengutronix.de> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D12143317902D6@DBDE01.ent.ti.com>
> Just returning the register content does not help much and looking at other
> implementations, like Blackfin, I am guessing this IOCTL is supposed to give
> a yes/no sort of result.
It needs to return WDIOF_* flags as defined in include/linux/watchdog.h.
Check also Documentation/watchdog/watchdog-api.txt for further info.
Yes, not all drivers follow this style, sadly.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/f1918c62/attachment.sig>
next prev parent reply other threads:[~2012-01-24 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 11:13 [PATCH RFC 0/2] watchdog boot status Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2012-01-23 11:13 ` [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+ Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2012-01-24 5:02 ` Bedia, Vaibhav
2012-01-24 5:02 ` Bedia, Vaibhav
2012-01-24 5:02 ` Bedia, Vaibhav
2012-01-24 6:10 ` Shubhrajyoti Datta
2012-01-24 6:10 ` Shubhrajyoti Datta
2012-01-24 6:10 ` Shubhrajyoti Datta
2012-01-24 6:29 ` Bedia, Vaibhav
2012-01-24 6:29 ` Bedia, Vaibhav
2012-01-24 6:29 ` Bedia, Vaibhav
2012-01-24 9:33 ` Wolfram Sang [this message]
2012-01-24 9:33 ` Wolfram Sang
2012-01-24 9:49 ` Shubhrajyoti
2012-01-24 9:49 ` Shubhrajyoti
2012-01-23 11:13 ` [PATCH 2/2] ARM: omap: Fix omap_prcm_get_reset_sources() for omap3/4 Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2012-01-23 11:13 ` Shubhrajyoti D
2014-02-20 8:02 ` [PATCH RFC 0/2] watchdog boot status Mandar Nandale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124093318.GA2609@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=omaplinuxkernel@gmail.com \
--cc=shubhrajyoti@ti.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.