From: Gleb Natapov <gleb@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com,
yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com,
mtosatti@redhat.com
Subject: Re: [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks
Date: Tue, 24 Jan 2012 12:17:21 +0200 [thread overview]
Message-ID: <20120124101721.GO9571@redhat.com> (raw)
In-Reply-To: <4F1E8345.7080901@redhat.com>
On Tue, Jan 24, 2012 at 11:09:09AM +0100, Kevin Wolf wrote:
> >> + } else if (reason != TASK_SWITCH_IRET) {
> >> + dpl = next_tss_desc.dpl;
> >> }
> > No need parentheses around one statement.
>
> Documentation/CodingStyle says:
>
> "This does not apply if only one branch of a conditional statement is a
> single statement; in the latter case use braces in both branches:"
>
Then you need to put parentheses around "if (reason != TASK_SWITCH_IRET)"
if you want to follow the letter of the CodingStyle :)
But I do not see this coding stile part widely used in core kernel code:
$ git grep "} else$" kernel | wc -l
122
Can't think of re to check when the rule is followed :(
--
Gleb.
next prev parent reply other threads:[~2012-01-24 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 16:10 [PATCH 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-23 16:10 ` [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-24 9:52 ` Gleb Natapov
2012-01-24 10:09 ` Kevin Wolf
2012-01-24 10:17 ` Gleb Natapov [this message]
2012-01-24 10:38 ` Kevin Wolf
2012-01-24 10:52 ` Gleb Natapov
2012-01-24 11:23 ` Kevin Wolf
2012-01-24 11:25 ` Gleb Natapov
2012-01-24 14:03 ` Joerg Roedel
2012-01-24 14:15 ` Kevin Wolf
2012-01-24 14:16 ` Gleb Natapov
2012-01-24 14:24 ` Kevin Wolf
2012-01-24 16:23 ` Gleb Natapov
2012-01-25 16:00 ` Joerg Roedel
2012-01-25 18:29 ` Gleb Natapov
2012-01-27 12:58 ` Kevin Wolf
2012-01-27 13:34 ` Joerg Roedel
2012-01-27 13:55 ` Kevin Wolf
2012-01-27 14:17 ` Joerg Roedel
2012-01-27 15:02 ` Kevin Wolf
2012-01-27 15:45 ` Gleb Natapov
2012-01-23 16:10 ` [PATCH 2/3] KVM: x86 emulator: VM86 segments must have DPL 3 Kevin Wolf
2012-01-23 16:10 ` [PATCH 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-24 10:57 ` Gleb Natapov
2012-01-24 11:31 ` Kevin Wolf
2012-01-24 11:37 ` Gleb Natapov
2012-01-24 11:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124101721.GO9571@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.