All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp,
	avi@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks
Date: Fri, 27 Jan 2012 16:02:30 +0100	[thread overview]
Message-ID: <4F22BC86.6090302@redhat.com> (raw)
In-Reply-To: <20120127141702.GO19255@amd.com>

Am 27.01.2012 15:17, schrieb Joerg Roedel:
> On Fri, Jan 27, 2012 at 02:55:12PM +0100, Kevin Wolf wrote:
>> Am 27.01.2012 14:34, schrieb Joerg Roedel:
>>> On Fri, Jan 27, 2012 at 01:58:38PM +0100, Kevin Wolf wrote:
>>>> Am 25.01.2012 17:00, schrieb Joerg Roedel:
>>>
>>>> I just retried. I use kvm-kmod and kvm.git with HEAD at ff92e9b5 plus
>>>> the tree patches of this series plus a printk to output exit_int_info in
>>>> task_switch_intercept(). I ran taskswitch2 from kvm-unittests and got
>>>> two failures and my VM86 unit test which hung when trying to return from
>>>> VM86. I also ran the kernel that made me aware of the issue initially.
>>>> All debug messages show exit_int_info = 0.
>>>
>>> Okay, you are testing on a K8 which has exactly this bug. As I just
>>> found out it is documented as erratum 701. The good news is that this
>>> only happens on K8 and Fam11h, any later AMD processor doesn't have this
>>> bug.
>>
>> Meh. Unless you give me a newer processor, this doesn't really help
>> me... Doesn't look like there's any way to get a workaround, is there? I
>> guess I'll have to hack it locally and possibly break other guests with
>> the hacked module.
> 
> No, unfortunatly there is no workaround for this problem. How do you
> plan to hack around it?

I know that my guest only uses iret and exceptions for task switches, so
I think in my case I can assume that any TASK_SWITCH_CALL is really a
TASK_SWITCH_GATE and I don't have to skip an instruction.

Not quite upstreamable, obviously.

Kevin

  reply	other threads:[~2012-01-27 14:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23 16:10 [PATCH 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-23 16:10 ` [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-24  9:52   ` Gleb Natapov
2012-01-24 10:09     ` Kevin Wolf
2012-01-24 10:17       ` Gleb Natapov
2012-01-24 10:38         ` Kevin Wolf
2012-01-24 10:52           ` Gleb Natapov
2012-01-24 11:23             ` Kevin Wolf
2012-01-24 11:25               ` Gleb Natapov
2012-01-24 14:03   ` Joerg Roedel
2012-01-24 14:15     ` Kevin Wolf
2012-01-24 14:16       ` Gleb Natapov
2012-01-24 14:24         ` Kevin Wolf
2012-01-24 16:23           ` Gleb Natapov
2012-01-25 16:00             ` Joerg Roedel
2012-01-25 18:29               ` Gleb Natapov
2012-01-27 12:58               ` Kevin Wolf
2012-01-27 13:34                 ` Joerg Roedel
2012-01-27 13:55                   ` Kevin Wolf
2012-01-27 14:17                     ` Joerg Roedel
2012-01-27 15:02                       ` Kevin Wolf [this message]
2012-01-27 15:45                         ` Gleb Natapov
2012-01-23 16:10 ` [PATCH 2/3] KVM: x86 emulator: VM86 segments must have DPL 3 Kevin Wolf
2012-01-23 16:10 ` [PATCH 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-24 10:57   ` Gleb Natapov
2012-01-24 11:31     ` Kevin Wolf
2012-01-24 11:37       ` Gleb Natapov
2012-01-24 11:44         ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F22BC86.6090302@redhat.com \
    --to=kwolf@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.