All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Pekka Enberg <penberg@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	leonid.moiseichuk@nokia.com, kamezawa.hiroyu@jp.fujitsu.com,
	mel@csn.ul.ie, rientjes@google.com,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ronen Hod <rhod@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC 1/3] /dev/low_mem_notify
Date: Tue, 24 Jan 2012 16:25:55 +0000	[thread overview]
Message-ID: <201201241625.55295.arnd@arndb.de> (raw)
In-Reply-To: <1327420880.13624.24.camel@jaguar>

On Tuesday 24 January 2012, Pekka Enberg wrote:
> On Tue, 2012-01-24 at 13:40 -0200, Marcelo Tosatti wrote:
> > What is the practical advantage of a syscall, again?
> 
> Why do you ask? The advantage for this particular case is not needing to
> add ioctls() for configuration and keeping the file read/write ABI
> simple.

The two are obviously equivalent and there is no reason to avoid
ioctl in general. However I agree that the syscall would be better
in this case, because that is what we tend to use for core kernel
functionality, while character devices tend to be used for I/O device
drivers that need stuff like enumeration and permission management.

	Arnd

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Pekka Enberg <penberg@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>,
	"linux-mm" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	leonid.moiseichuk@nokia.com, kamezawa.hiroyu@jp.fujitsu.com,
	mel@csn.ul.ie, rientjes@google.com,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ronen Hod <rhod@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC 1/3] /dev/low_mem_notify
Date: Tue, 24 Jan 2012 16:25:55 +0000	[thread overview]
Message-ID: <201201241625.55295.arnd@arndb.de> (raw)
In-Reply-To: <1327420880.13624.24.camel@jaguar>

On Tuesday 24 January 2012, Pekka Enberg wrote:
> On Tue, 2012-01-24 at 13:40 -0200, Marcelo Tosatti wrote:
> > What is the practical advantage of a syscall, again?
> 
> Why do you ask? The advantage for this particular case is not needing to
> add ioctls() for configuration and keeping the file read/write ABI
> simple.

The two are obviously equivalent and there is no reason to avoid
ioctl in general. However I agree that the syscall would be better
in this case, because that is what we tend to use for core kernel
functionality, while character devices tend to be used for I/O device
drivers that need stuff like enumeration and permission management.

	Arnd

  reply	other threads:[~2012-01-24 16:25 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-17  8:13 [RFC 0/3] low memory notify Minchan Kim
2012-01-17  8:13 ` Minchan Kim
2012-01-17  8:13 ` [RFC 1/3] /dev/low_mem_notify Minchan Kim
2012-01-17  8:13   ` Minchan Kim
2012-01-17  9:27   ` Pekka Enberg
2012-01-17  9:27     ` Pekka Enberg
2012-01-17 16:35     ` Rik van Riel
2012-01-17 16:35       ` Rik van Riel
2012-01-17 18:51       ` Pekka Enberg
2012-01-17 18:51         ` Pekka Enberg
2012-01-17 19:30         ` Rik van Riel
2012-01-17 19:30           ` Rik van Riel
2012-01-17 19:49           ` Pekka Enberg
2012-01-17 19:49             ` Pekka Enberg
2012-01-17 19:54             ` Pekka Enberg
2012-01-17 19:54               ` Pekka Enberg
2012-01-17 19:57             ` Pekka Enberg
2012-01-17 19:57               ` Pekka Enberg
2012-01-17 23:20         ` Minchan Kim
2012-01-17 23:20           ` Minchan Kim
2012-01-18  7:16           ` Pekka Enberg
2012-01-18  7:16             ` Pekka Enberg
2012-01-18  7:49             ` Minchan Kim
2012-01-18  7:49               ` Minchan Kim
2012-01-18  9:06         ` leonid.moiseichuk
2012-01-18  9:06           ` leonid.moiseichuk
2012-01-18  9:15           ` Pekka Enberg
2012-01-18  9:15             ` Pekka Enberg
2012-01-18  9:41             ` leonid.moiseichuk
2012-01-18  9:41               ` leonid.moiseichuk
2012-01-18 10:40               ` Pekka Enberg
2012-01-18 10:40                 ` Pekka Enberg
2012-01-18 10:44                 ` leonid.moiseichuk
2012-01-18 10:44                   ` leonid.moiseichuk
2012-01-18 23:34                   ` Ronen Hod
2012-01-18 23:34                     ` Ronen Hod
2012-01-19  7:25                     ` Pekka Enberg
2012-01-19  7:25                       ` Pekka Enberg
2012-01-19  9:05                       ` Ronen Hod
2012-01-19  9:05                         ` Ronen Hod
2012-01-19  9:10                         ` Pekka Enberg
2012-01-19  9:10                           ` Pekka Enberg
2012-01-19  9:20                           ` Ronen Hod
2012-01-19  9:20                             ` Ronen Hod
2012-01-19 10:53                             ` leonid.moiseichuk
2012-01-19 10:53                               ` leonid.moiseichuk
2012-01-19 11:07                               ` Pekka Enberg
2012-01-19 11:07                                 ` Pekka Enberg
2012-01-19 11:54                                 ` leonid.moiseichuk
2012-01-19 11:54                                   ` leonid.moiseichuk
2012-01-19 11:59                                   ` Pekka Enberg
2012-01-19 11:59                                     ` Pekka Enberg
2012-01-19 12:06                                   ` Pekka Enberg
2012-01-19 12:06                                     ` Pekka Enberg
2012-01-24 15:38                               ` Marcelo Tosatti
2012-01-24 15:38                                 ` Marcelo Tosatti
2012-01-24 16:08                                 ` Ronen Hod
2012-01-24 16:08                                   ` Ronen Hod
2012-01-24 18:10                                   ` Marcelo Tosatti
2012-01-24 18:10                                     ` Marcelo Tosatti
2012-01-25  8:52                                     ` Ronen Hod
2012-01-25  8:52                                       ` Ronen Hod
2012-01-25 10:12                                       ` Marcelo Tosatti
2012-01-25 10:12                                         ` Marcelo Tosatti
2012-01-25 10:48                                         ` Ronen Hod
2012-01-25 10:48                                           ` Ronen Hod
2012-01-26 16:17                                           ` Marcelo Tosatti
2012-01-26 16:17                                             ` Marcelo Tosatti
2012-01-24 16:10                                 ` Pekka Enberg
2012-01-24 16:10                                   ` Pekka Enberg
2012-01-24 18:29                                   ` Marcelo Tosatti
2012-01-24 18:29                                     ` Marcelo Tosatti
2012-01-25  8:19                                   ` leonid.moiseichuk
2012-01-25  8:19                                     ` leonid.moiseichuk
2012-01-19  7:34                   ` Pekka Enberg
2012-01-19  7:34                     ` Pekka Enberg
2012-01-24 16:22             ` Arnd Bergmann
2012-01-24 16:22               ` Arnd Bergmann
2012-01-18 14:30           ` Rik van Riel
2012-01-18 14:30             ` Rik van Riel
2012-01-18 15:29             ` Pekka Enberg
2012-01-18 15:29               ` Pekka Enberg
2012-01-24 15:40         ` Marcelo Tosatti
2012-01-24 15:40           ` Marcelo Tosatti
2012-01-24 16:01           ` Pekka Enberg
2012-01-24 16:01             ` Pekka Enberg
2012-01-24 16:25             ` Arnd Bergmann [this message]
2012-01-24 16:25               ` Arnd Bergmann
2012-01-24 18:32               ` Marcelo Tosatti
2012-01-24 18:32                 ` Marcelo Tosatti
2012-01-24 21:57         ` Jonathan Corbet
2012-01-24 21:57           ` Jonathan Corbet
2012-01-17  9:45   ` Pekka Enberg
2012-01-17  9:45     ` Pekka Enberg
2012-01-17  8:13 ` [RFC 2/3] vmscan hook Minchan Kim
2012-01-17  8:13   ` Minchan Kim
2012-01-17  8:39   ` KAMEZAWA Hiroyuki
2012-01-17  8:39     ` KAMEZAWA Hiroyuki
2012-01-17  9:13     ` Minchan Kim
2012-01-17  9:13       ` Minchan Kim
2012-01-17 10:05       ` KAMEZAWA Hiroyuki
2012-01-17 10:05         ` KAMEZAWA Hiroyuki
2012-01-17 23:08         ` Minchan Kim
2012-01-17 23:08           ` Minchan Kim
2012-01-18  0:18           ` KAMEZAWA Hiroyuki
2012-01-18  0:18             ` KAMEZAWA Hiroyuki
2012-01-18 14:17             ` Rik van Riel
2012-01-18 14:17               ` Rik van Riel
2012-01-19  2:25               ` KAMEZAWA Hiroyuki
2012-01-19  2:25                 ` KAMEZAWA Hiroyuki
2012-01-19 14:42                 ` Rik van Riel
2012-01-19 14:42                   ` Rik van Riel
2012-01-20  0:24                   ` KAMEZAWA Hiroyuki
2012-01-20  0:24                     ` KAMEZAWA Hiroyuki
2012-01-17  8:13 ` [RFC 3/3] test program Minchan Kim
2012-01-17  8:13   ` Minchan Kim
2012-01-17 14:38 ` [RFC 0/3] low memory notify Colin Walters
2012-01-17 14:38   ` Colin Walters
2012-01-17 15:04   ` Pekka Enberg
2012-01-17 15:04     ` Pekka Enberg
2012-01-17 16:44   ` Rik van Riel
2012-01-17 16:44     ` Rik van Riel
2012-01-17 17:16 ` Olof Johansson
2012-01-17 17:16   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201241625.55295.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=leonid.moiseichuk@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan@kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=penberg@kernel.org \
    --cc=rhod@redhat.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.