* [PATCH] max8997: Avoid spaces in regulator names
@ 2012-01-24 11:31 ` Karol Lewandowski
0 siblings, 0 replies; 4+ messages in thread
From: Karol Lewandowski @ 2012-01-24 11:31 UTC (permalink / raw)
To: myungjoo.ham
Cc: linux-kernel, rpurdie, rob.herring, grant.likely, kyungmin.park,
linux-arm-kernel, linux-samsung-soc, kgene.kim, rnayak,
m.szyprowski, s.nawrocki, Karol Lewandowski, Mark Brown,
Thomas Abraham
max8997-pmic instantiated from device tree uses names, not numerical
ids to distinguish between outputs.
Replace spaces with underscores in said names to make it possible to
describe these outputs as regulators in DTS.
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>
---
drivers/regulator/max8997.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index 053d0b7..4b572eb 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -910,13 +910,13 @@ static struct regulator_desc regulators[] = {
},
regulator_desc_buck(7),
{
- .name = "EN32KHz AP",
+ .name = "EN32KHz_AP",
.id = MAX8997_EN32KHZ_AP,
.ops = &max8997_fixedvolt_ops,
.type = REGULATOR_VOLTAGE,
.owner = THIS_MODULE,
}, {
- .name = "EN32KHz CP",
+ .name = "EN32KHz_CP",
.id = MAX8997_EN32KHZ_CP,
.ops = &max8997_fixedvolt_ops,
.type = REGULATOR_VOLTAGE,
@@ -940,7 +940,7 @@ static struct regulator_desc regulators[] = {
.type = REGULATOR_VOLTAGE,
.owner = THIS_MODULE,
}, {
- .name = "CHARGER CV",
+ .name = "CHARGER_CV",
.id = MAX8997_CHARGER_CV,
.ops = &max8997_fixedstate_ops,
.type = REGULATOR_VOLTAGE,
@@ -952,7 +952,7 @@ static struct regulator_desc regulators[] = {
.type = REGULATOR_CURRENT,
.owner = THIS_MODULE,
}, {
- .name = "CHARGER TOPOFF",
+ .name = "CHARGER_TOPOFF",
.id = MAX8997_CHARGER_TOPOFF,
.ops = &max8997_charger_fixedstate_ops,
.type = REGULATOR_CURRENT,
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] max8997: Avoid spaces in regulator names
@ 2012-01-24 11:31 ` Karol Lewandowski
0 siblings, 0 replies; 4+ messages in thread
From: Karol Lewandowski @ 2012-01-24 11:31 UTC (permalink / raw)
To: linux-arm-kernel
max8997-pmic instantiated from device tree uses names, not numerical
ids to distinguish between outputs.
Replace spaces with underscores in said names to make it possible to
describe these outputs as regulators in DTS.
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>
---
drivers/regulator/max8997.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index 053d0b7..4b572eb 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -910,13 +910,13 @@ static struct regulator_desc regulators[] = {
},
regulator_desc_buck(7),
{
- .name = "EN32KHz AP",
+ .name = "EN32KHz_AP",
.id = MAX8997_EN32KHZ_AP,
.ops = &max8997_fixedvolt_ops,
.type = REGULATOR_VOLTAGE,
.owner = THIS_MODULE,
}, {
- .name = "EN32KHz CP",
+ .name = "EN32KHz_CP",
.id = MAX8997_EN32KHZ_CP,
.ops = &max8997_fixedvolt_ops,
.type = REGULATOR_VOLTAGE,
@@ -940,7 +940,7 @@ static struct regulator_desc regulators[] = {
.type = REGULATOR_VOLTAGE,
.owner = THIS_MODULE,
}, {
- .name = "CHARGER CV",
+ .name = "CHARGER_CV",
.id = MAX8997_CHARGER_CV,
.ops = &max8997_fixedstate_ops,
.type = REGULATOR_VOLTAGE,
@@ -952,7 +952,7 @@ static struct regulator_desc regulators[] = {
.type = REGULATOR_CURRENT,
.owner = THIS_MODULE,
}, {
- .name = "CHARGER TOPOFF",
+ .name = "CHARGER_TOPOFF",
.id = MAX8997_CHARGER_TOPOFF,
.ops = &max8997_charger_fixedstate_ops,
.type = REGULATOR_CURRENT,
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] max8997: Avoid spaces in regulator names
2012-01-24 11:31 ` Karol Lewandowski
@ 2012-01-24 20:02 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-01-24 20:02 UTC (permalink / raw)
To: Karol Lewandowski
Cc: myungjoo.ham, linux-kernel, rpurdie, rob.herring, grant.likely,
kyungmin.park, linux-arm-kernel, linux-samsung-soc, kgene.kim,
rnayak, m.szyprowski, s.nawrocki, Thomas Abraham
On Tue, Jan 24, 2012 at 12:31:11PM +0100, Karol Lewandowski wrote:
> max8997-pmic instantiated from device tree uses names, not numerical
> ids to distinguish between outputs.
>
> Replace spaces with underscores in said names to make it possible to
> describe these outputs as regulators in DTS.
I went ahead and applied this since even if there's a better solution
out there this will work for now and the worst it's going to do is make
the log messages a bit less pretty.
Please when sending patches try to use subjects appropriate for the
subsystem - in this case a regulator: prefix.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] max8997: Avoid spaces in regulator names
@ 2012-01-24 20:02 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-01-24 20:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 24, 2012 at 12:31:11PM +0100, Karol Lewandowski wrote:
> max8997-pmic instantiated from device tree uses names, not numerical
> ids to distinguish between outputs.
>
> Replace spaces with underscores in said names to make it possible to
> describe these outputs as regulators in DTS.
I went ahead and applied this since even if there's a better solution
out there this will work for now and the worst it's going to do is make
the log messages a bit less pretty.
Please when sending patches try to use subjects appropriate for the
subsystem - in this case a regulator: prefix.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-24 20:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 11:31 [PATCH] max8997: Avoid spaces in regulator names Karol Lewandowski
2012-01-24 11:31 ` Karol Lewandowski
2012-01-24 20:02 ` Mark Brown
2012-01-24 20:02 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.