From: Will Deacon <will.deacon@arm.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
STEricsson <STEricsson_nomadik_linux@list.st.com>
Subject: Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer
Date: Wed, 25 Jan 2012 09:58:00 +0000 [thread overview]
Message-ID: <20120125095800.GC21709@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20120124214531.GB8517@n2100.arm.linux.org.uk>
On Tue, Jan 24, 2012 at 09:45:31PM +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 24, 2012 at 05:26:00PM +0000, Will Deacon wrote:
> > diff --git a/arch/arm/mach-realview/include/mach/irqs-pb1176.h b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > index 5c3c625..708f841 100644
> > --- a/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > +++ b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > @@ -40,6 +40,7 @@
> > #define IRQ_DC1176_L2CC (IRQ_DC1176_GIC_START + 13)
> > #define IRQ_DC1176_RTC (IRQ_DC1176_GIC_START + 14)
> > #define IRQ_DC1176_CLCD (IRQ_DC1176_GIC_START + 15) /* CLCD controller */
> > +#define IRQ_DC1176_GPIO0 (IRQ_DC1176_GIC_START + 16)
> > #define IRQ_DC1176_SSP (IRQ_DC1176_GIC_START + 17) /* SSP port */
> > #define IRQ_DC1176_UART0 (IRQ_DC1176_GIC_START + 18) /* UART 0 on development chip */
> > #define IRQ_DC1176_UART1 (IRQ_DC1176_GIC_START + 19) /* UART 1 on development chip */
> > @@ -73,7 +74,6 @@
> > #define IRQ_PB1176_DMAC (IRQ_PB1176_GIC_START + 24) /* DMA controller */
> > #define IRQ_PB1176_RTC (IRQ_PB1176_GIC_START + 25) /* Real Time Clock */
> >
> > -#define IRQ_PB1176_GPIO0 -1
> > #define IRQ_PB1176_SCTL -1
> >
> > #define NR_GIC_PB1176 2
> > diff --git a/arch/arm/mach-realview/realview_pb1176.c b/arch/arm/mach-realview/realview_pb1176.c
> > index 1b6e60c..b1d7caf 100644
> > --- a/arch/arm/mach-realview/realview_pb1176.c
> > +++ b/arch/arm/mach-realview/realview_pb1176.c
> > @@ -143,7 +143,7 @@ static struct pl022_ssp_controller ssp0_plat_data = {
> > #define PB1176_CLCD_IRQ { IRQ_DC1176_CLCD }
> > #define SCTL_IRQ { }
> > #define PB1176_WATCHDOG_IRQ { IRQ_DC1176_WATCHDOG }
> > -#define PB1176_GPIO0_IRQ { IRQ_PB1176_GPIO0 }
> > +#define PB1176_GPIO0_IRQ { IRQ_DC1176_GPIO0 }
> > #define GPIO1_IRQ { IRQ_PB1176_GPIO1 }
> > #define PB1176_RTC_IRQ { IRQ_DC1176_RTC }
> > #define SCI_IRQ { IRQ_PB1176_SCI }
>
> I guess we should believe the TRM on this - can you put this in the patch
> system please?
Sure. Which branch shall I take it against (before or after your amba
changes)?
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer
Date: Wed, 25 Jan 2012 09:58:00 +0000 [thread overview]
Message-ID: <20120125095800.GC21709@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20120124214531.GB8517@n2100.arm.linux.org.uk>
On Tue, Jan 24, 2012 at 09:45:31PM +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 24, 2012 at 05:26:00PM +0000, Will Deacon wrote:
> > diff --git a/arch/arm/mach-realview/include/mach/irqs-pb1176.h b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > index 5c3c625..708f841 100644
> > --- a/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > +++ b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> > @@ -40,6 +40,7 @@
> > #define IRQ_DC1176_L2CC (IRQ_DC1176_GIC_START + 13)
> > #define IRQ_DC1176_RTC (IRQ_DC1176_GIC_START + 14)
> > #define IRQ_DC1176_CLCD (IRQ_DC1176_GIC_START + 15) /* CLCD controller */
> > +#define IRQ_DC1176_GPIO0 (IRQ_DC1176_GIC_START + 16)
> > #define IRQ_DC1176_SSP (IRQ_DC1176_GIC_START + 17) /* SSP port */
> > #define IRQ_DC1176_UART0 (IRQ_DC1176_GIC_START + 18) /* UART 0 on development chip */
> > #define IRQ_DC1176_UART1 (IRQ_DC1176_GIC_START + 19) /* UART 1 on development chip */
> > @@ -73,7 +74,6 @@
> > #define IRQ_PB1176_DMAC (IRQ_PB1176_GIC_START + 24) /* DMA controller */
> > #define IRQ_PB1176_RTC (IRQ_PB1176_GIC_START + 25) /* Real Time Clock */
> >
> > -#define IRQ_PB1176_GPIO0 -1
> > #define IRQ_PB1176_SCTL -1
> >
> > #define NR_GIC_PB1176 2
> > diff --git a/arch/arm/mach-realview/realview_pb1176.c b/arch/arm/mach-realview/realview_pb1176.c
> > index 1b6e60c..b1d7caf 100644
> > --- a/arch/arm/mach-realview/realview_pb1176.c
> > +++ b/arch/arm/mach-realview/realview_pb1176.c
> > @@ -143,7 +143,7 @@ static struct pl022_ssp_controller ssp0_plat_data = {
> > #define PB1176_CLCD_IRQ { IRQ_DC1176_CLCD }
> > #define SCTL_IRQ { }
> > #define PB1176_WATCHDOG_IRQ { IRQ_DC1176_WATCHDOG }
> > -#define PB1176_GPIO0_IRQ { IRQ_PB1176_GPIO0 }
> > +#define PB1176_GPIO0_IRQ { IRQ_DC1176_GPIO0 }
> > #define GPIO1_IRQ { IRQ_PB1176_GPIO1 }
> > #define PB1176_RTC_IRQ { IRQ_DC1176_RTC }
> > #define SCI_IRQ { IRQ_PB1176_SCI }
>
> I guess we should believe the TRM on this - can you put this in the patch
> system please?
Sure. Which branch shall I take it against (before or after your amba
changes)?
Will
next prev parent reply other threads:[~2012-01-25 9:58 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 9:22 [PATCH 00/31] Clean up amba/primecell bus support Russell King - ARM Linux
2012-01-20 9:22 ` Russell King - ARM Linux
2012-01-20 9:22 ` [PATCH 01/31] ARM: amba: add amba_device allocation/add/put functions Russell King - ARM Linux
2012-01-20 9:22 ` Russell King - ARM Linux
2012-01-20 9:23 ` [PATCH 02/31] ARM: amba: of: convert to use amba_device_alloc Russell King - ARM Linux
2012-01-20 9:23 ` Russell King - ARM Linux
2012-01-20 13:58 ` Rob Herring
2012-01-20 13:58 ` Rob Herring
2012-01-20 9:23 ` [PATCH 03/31] ARM: amba: ux500: " Russell King - ARM Linux
2012-01-20 9:23 ` Russell King - ARM Linux
2012-01-21 16:21 ` Srinidhi KASAGAR
2012-01-21 16:21 ` Srinidhi KASAGAR
2012-01-23 19:03 ` Linus Walleij
2012-01-23 19:03 ` Linus Walleij
2012-01-20 9:23 ` [PATCH 04/31] ARM: amba: integrator: " Russell King - ARM Linux
2012-01-20 9:23 ` Russell King - ARM Linux
2012-01-20 9:24 ` [PATCH 05/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 9:24 ` Russell King - ARM Linux
2012-01-20 12:25 ` Shawn Guo
2012-01-20 12:25 ` Shawn Guo
2012-01-20 12:39 ` Russell King - ARM Linux
2012-01-20 12:39 ` Russell King - ARM Linux
2012-01-20 9:24 ` [PATCH 06/31] ARM: amba: make irq 0 invalid Russell King - ARM Linux
2012-01-20 9:24 ` Russell King - ARM Linux
2012-01-20 9:24 ` [PATCH 07/31] ARM: amba: ux500: get rid of NO_IRQ Russell King - ARM Linux
2012-01-20 9:24 ` Russell King - ARM Linux
2012-01-21 16:19 ` Srinidhi KASAGAR
2012-01-21 16:19 ` Srinidhi KASAGAR
[not found] ` <E1RoAiE-0005Eh-7i-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2012-01-23 19:04 ` Linus Walleij
2012-01-23 19:04 ` Linus Walleij
2012-01-20 9:25 ` [PATCH 08/31] ARM: amba: get rid of NO_IRQ initializers Russell King - ARM Linux
2012-01-20 9:25 ` Russell King - ARM Linux
2012-01-20 9:25 ` [PATCH 09/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-20 9:25 ` Russell King - ARM Linux
2012-01-21 0:28 ` Kukjin Kim
2012-01-21 0:28 ` Kukjin Kim
2012-01-20 9:25 ` [PATCH 10/31] ARM: amba: integrator/realview/versatile/vexpress: " Russell King - ARM Linux
2012-01-20 9:25 ` Russell King - ARM Linux
2012-01-20 9:26 ` [PATCH 11/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20 9:26 ` Russell King - ARM Linux
2012-01-20 9:26 ` [PATCH 12/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 9:26 ` Russell King - ARM Linux
2012-01-20 12:27 ` Shawn Guo
2012-01-20 12:27 ` Shawn Guo
2012-01-20 9:26 ` [PATCH 13/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-20 9:26 ` Russell King - ARM Linux
2012-01-20 22:33 ` Alessandro Rubini
2012-01-20 22:33 ` Alessandro Rubini
2012-01-23 19:02 ` Linus Walleij
2012-01-23 19:02 ` Linus Walleij
2012-01-20 9:27 ` [PATCH 14/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20 9:27 ` Russell King - ARM Linux
2012-01-20 9:27 ` [PATCH 15/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20 9:27 ` Russell King - ARM Linux
2012-01-20 9:30 ` Viresh Kumar
2012-01-20 9:30 ` Viresh Kumar
2012-01-20 9:28 ` [PATCH 18/31] ARM: amba: provide common initializers for static amba devices Russell King - ARM Linux
2012-01-20 9:28 ` Russell King - ARM Linux
2012-01-20 17:58 ` H Hartley Sweeten
2012-01-20 17:58 ` H Hartley Sweeten
2012-01-20 9:28 ` [PATCH 19/31] ARM: amba: vexpress: get rid of private platform amba_device initializer Russell King - ARM Linux
2012-01-20 9:28 ` Russell King - ARM Linux
2012-01-24 14:27 ` Will Deacon
2012-01-24 14:27 ` Will Deacon
2012-01-20 9:29 ` [PATCH 20/31] ARM: amba: versatile: " Russell King - ARM Linux
2012-01-20 9:29 ` Russell King - ARM Linux
2012-01-24 15:06 ` Will Deacon
2012-01-24 15:06 ` Will Deacon
2012-01-20 9:29 ` [PATCH 21/31] ARM: amba: realview: " Russell King - ARM Linux
2012-01-20 9:29 ` Russell King - ARM Linux
2012-01-24 16:00 ` Will Deacon
2012-01-24 16:00 ` Will Deacon
[not found] ` <20120124160044.GM19798-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2012-01-24 16:23 ` Russell King - ARM Linux
2012-01-24 16:23 ` Russell King - ARM Linux
2012-01-24 17:26 ` Will Deacon
2012-01-24 17:26 ` Will Deacon
2012-01-24 21:23 ` Linus Walleij
2012-01-24 21:23 ` Linus Walleij
2012-01-24 21:45 ` Russell King - ARM Linux
2012-01-24 21:45 ` Russell King - ARM Linux
2012-01-25 9:58 ` Will Deacon [this message]
2012-01-25 9:58 ` Will Deacon
2012-01-25 10:22 ` Russell King - ARM Linux
2012-01-25 10:22 ` Russell King - ARM Linux
2012-01-25 10:39 ` Will Deacon
2012-01-25 10:39 ` Will Deacon
2012-01-25 11:06 ` Russell King - ARM Linux
2012-01-25 11:06 ` Russell King - ARM Linux
2012-01-26 17:25 ` Russell King - ARM Linux
2012-01-26 17:25 ` Russell King - ARM Linux
[not found] ` <20120126172527.GA12731-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-01-26 17:37 ` Will Deacon
2012-01-26 17:37 ` Will Deacon
2012-01-26 17:41 ` Russell King - ARM Linux
2012-01-26 17:41 ` Russell King - ARM Linux
2012-01-20 9:29 ` [PATCH 22/31] ARM: amba: integrator: use common amba device initializers Russell King - ARM Linux
2012-01-20 9:29 ` Russell King - ARM Linux
2012-01-24 16:13 ` Will Deacon
2012-01-24 16:13 ` Will Deacon
2012-01-20 9:30 ` [PATCH 23/31] ARM: amba: omap2: " Russell King - ARM Linux
2012-01-20 9:30 ` Russell King - ARM Linux
2012-01-20 14:37 ` Tony Lindgren
2012-01-20 14:37 ` Tony Lindgren
[not found] ` <20120120092207.GD1068-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-01-20 9:27 ` [PATCH 16/31] ARM: amba: u300: get rid of NO_IRQ initializers Russell King - ARM Linux
2012-01-20 9:27 ` Russell King - ARM Linux
2012-01-23 19:04 ` Linus Walleij
2012-01-23 19:04 ` Linus Walleij
2012-01-20 9:28 ` [PATCH 17/31] ARM: amba: make use of -1 IRQs warn Russell King - ARM Linux
2012-01-20 9:28 ` Russell King - ARM Linux
2012-01-20 9:30 ` [PATCH 24/31] ARM: amba: ep93xx: use common amba device initializers Russell King - ARM Linux
2012-01-20 9:30 ` Russell King - ARM Linux
2012-01-20 16:56 ` H Hartley Sweeten
2012-01-20 16:56 ` H Hartley Sweeten
2012-01-21 0:59 ` [PATCH 00/31] Clean up amba/primecell bus support Kukjin Kim
2012-01-21 0:59 ` Kukjin Kim
2012-01-20 9:30 ` [PATCH 25/31] ARM: amba: bcmring: use common amba device initializers Russell King - ARM Linux
2012-01-20 9:30 ` Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 26/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20 9:31 ` Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 27/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20 9:31 ` Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 28/31] ARM: amba: u300: " Russell King - ARM Linux
2012-01-20 9:31 ` Russell King - ARM Linux
2012-01-23 19:05 ` Linus Walleij
2012-01-23 19:05 ` Linus Walleij
2012-01-20 9:32 ` [PATCH 29/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-20 9:32 ` Russell King - ARM Linux
2012-01-20 22:33 ` Alessandro Rubini
2012-01-20 22:33 ` Alessandro Rubini
2012-01-23 19:02 ` Linus Walleij
2012-01-23 19:02 ` Linus Walleij
2012-01-20 9:32 ` [PATCH 30/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20 9:32 ` Russell King - ARM Linux
2012-01-20 9:38 ` Viresh Kumar
2012-01-20 9:38 ` Viresh Kumar
2012-01-20 9:32 ` [PATCH 31/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-20 9:32 ` Russell King - ARM Linux
[not found] ` <E1RoAq3-0005GM-LI-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2012-01-21 0:45 ` Kukjin Kim
2012-01-21 0:45 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125095800.GC21709@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.