From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan.kim@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
Adrian Drzewieki <z@drze.net>
Subject: Re: [PATCH v4 -mm] make swapin readahead skip over holes
Date: Wed, 25 Jan 2012 17:30:36 -0800 [thread overview]
Message-ID: <20120125173036.ec0d3bac.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F20ABDF.8020604@redhat.com>
On Wed, 25 Jan 2012 20:26:55 -0500
Rik van Riel <riel@redhat.com> wrote:
> On 01/25/2012 08:23 PM, Andrew Morton wrote:
>
> > Just to show that I'm paying attention...
> >
> >> --- a/mm/swap_state.c
> >> +++ b/mm/swap_state.c
> >> @@ -382,25 +382,23 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
> >> struct page *swapin_readahead(swp_entry_t entry, gfp_t gfp_mask,
> >> struct vm_area_struct *vma, unsigned long addr)
> >> {
> >> - int nr_pages;
> >> struct page *page;
> >> - unsigned long offset;
> >> - unsigned long end_offset;
> >> + unsigned long offset = swp_offset(entry);
> >> + unsigned long start_offset, end_offset;
> >> + unsigned long mask = (1<< page_cluster) - 1;
> >
> > This is broken for page_cluster> 31. Fix:
>
> I don't know who would want to do their swapins in chunks
> of 8GB or large at a time,
Linux MM developers ;)
> but still a good catch.
>
> Want me to send in a v5, or do you prefer to merge a -fix
> patch in your tree?
I already queued the fix, thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan.kim@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
Adrian Drzewieki <z@drze.net>
Subject: Re: [PATCH v4 -mm] make swapin readahead skip over holes
Date: Wed, 25 Jan 2012 17:30:36 -0800 [thread overview]
Message-ID: <20120125173036.ec0d3bac.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F20ABDF.8020604@redhat.com>
On Wed, 25 Jan 2012 20:26:55 -0500
Rik van Riel <riel@redhat.com> wrote:
> On 01/25/2012 08:23 PM, Andrew Morton wrote:
>
> > Just to show that I'm paying attention...
> >
> >> --- a/mm/swap_state.c
> >> +++ b/mm/swap_state.c
> >> @@ -382,25 +382,23 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
> >> struct page *swapin_readahead(swp_entry_t entry, gfp_t gfp_mask,
> >> struct vm_area_struct *vma, unsigned long addr)
> >> {
> >> - int nr_pages;
> >> struct page *page;
> >> - unsigned long offset;
> >> - unsigned long end_offset;
> >> + unsigned long offset = swp_offset(entry);
> >> + unsigned long start_offset, end_offset;
> >> + unsigned long mask = (1<< page_cluster) - 1;
> >
> > This is broken for page_cluster> 31. Fix:
>
> I don't know who would want to do their swapins in chunks
> of 8GB or large at a time,
Linux MM developers ;)
> but still a good catch.
>
> Want me to send in a v5, or do you prefer to merge a -fix
> patch in your tree?
I already queued the fix, thanks.
next prev parent reply other threads:[~2012-01-26 1:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 18:13 [PATCH v3 -mm] make swapin readahead skip over holes Rik van Riel
2012-01-24 18:13 ` Rik van Riel
2012-01-24 19:14 ` [PATCH v4 " Rik van Riel
2012-01-24 19:14 ` Rik van Riel
2012-01-25 10:31 ` Johannes Weiner
2012-01-25 10:31 ` Johannes Weiner
2012-01-25 10:51 ` Mel Gorman
2012-01-25 10:51 ` Mel Gorman
2012-01-26 1:23 ` Andrew Morton
2012-01-26 1:23 ` Andrew Morton
2012-01-26 1:26 ` Rik van Riel
2012-01-26 1:26 ` Rik van Riel
2012-01-26 1:30 ` Andrew Morton [this message]
2012-01-26 1:30 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125173036.ec0d3bac.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=z@drze.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.