From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] target: handle empty string writes in sysfs
Date: Thu, 26 Jan 2012 12:19:59 +0000 [thread overview]
Message-ID: <20120126121959.GS3294@mwanda> (raw)
In-Reply-To: <4F1E8E31.1070507@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, Jan 24, 2012 at 11:55:45AM +0100, walter harms wrote:
>
>
> Am 24.01.2012 09:40, schrieb Dan Carpenter:
> > These are root only and we're not likely to hit the problem in practise,
> > but it makes a the static checkers happy.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> > index 0955bb8..9b86330 100644
> > --- a/drivers/target/target_core_configfs.c
> > +++ b/drivers/target/target_core_configfs.c
> > @@ -1707,6 +1707,8 @@ static ssize_t target_core_store_dev_alias(
> > se_dev->su_dev_flags |= SDF_USING_ALIAS;
> > read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,
> > "%s", page);
>
> Would it help to check page==NULL or *page==0 at start ?
> Now you have se_dev->su_dev_flags initialised.
It's a fair point. Let me redo it.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] target: handle empty string writes in sysfs
Date: Thu, 26 Jan 2012 15:19:59 +0300 [thread overview]
Message-ID: <20120126121959.GS3294@mwanda> (raw)
In-Reply-To: <4F1E8E31.1070507@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, Jan 24, 2012 at 11:55:45AM +0100, walter harms wrote:
>
>
> Am 24.01.2012 09:40, schrieb Dan Carpenter:
> > These are root only and we're not likely to hit the problem in practise,
> > but it makes a the static checkers happy.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> > index 0955bb8..9b86330 100644
> > --- a/drivers/target/target_core_configfs.c
> > +++ b/drivers/target/target_core_configfs.c
> > @@ -1707,6 +1707,8 @@ static ssize_t target_core_store_dev_alias(
> > se_dev->su_dev_flags |= SDF_USING_ALIAS;
> > read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,
> > "%s", page);
>
> Would it help to check page==NULL or *page==0 at start ?
> Now you have se_dev->su_dev_flags initialised.
It's a fair point. Let me redo it.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-26 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 8:40 [patch] target: handle empty string writes in sysfs Dan Carpenter
2012-01-24 8:40 ` Dan Carpenter
2012-01-24 10:55 ` walter harms
2012-01-24 10:55 ` walter harms
2012-01-26 12:19 ` Dan Carpenter [this message]
2012-01-26 12:19 ` Dan Carpenter
2012-01-27 12:50 ` [patch v2] " Dan Carpenter
2012-01-27 12:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126121959.GS3294@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.