All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Philip Prindeville <philipp@redfish-solutions.com>
Cc: platform-driver-x86@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Richard Purdie <rpurdie@rpsys.net>,
	Ed Wildgoose <kernel@wildgooses.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 1/1] alix2: supplement driver to include GPIO button support
Date: Thu, 26 Jan 2012 17:57:41 -0800	[thread overview]
Message-ID: <20120126175741.6aa4a9cd@queued.net> (raw)
In-Reply-To: <1327627902-18417-1-git-send-email-philipp@redfish-solutions.com>

On Thu, 26 Jan 2012 18:31:42 -0700
Philip Prindeville <philipp@redfish-solutions.com> wrote:

> From: "Philip A. Prindeville" <philipp@redfish-solutions.com>
> 
> GPIO 24 is used in reference designs as a soft-reset button, and
> the alix2 is no exception. Add it as a gpio-button.
> 
> Use symbolic values to describe BIOS addresses.
> 
> Record the model number.
> 
> Changes v2 and v3 per Andres:
> Use DMI to detect the board instead of proposed coreboot library;
> Don't make including <linux/dmi.h> conditional on CONFIG_DMI;
> Ditto for calling dmi_get_system_info() in alix_present_dmi();
> Make alix_present() and alix_present_dmi() return bool;
> 
> Changes v4 per Andrew:
> Remove alix_model as this can be patched downstream where it's needed
>   anyway (ultimately, RFFILL will be supported by a new generic gpio
>   class);
> 
> Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
> Acked-by: Ed Wildgoose <kernel@wildgooses.com>
> Acked-by: Andres Salomon <dilinger@queued.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
[...]
>  }
>  
> -static int __init alix_init(void)
> +static int  __init alix_init(void)

What's this about?

      reply	other threads:[~2012-01-27  1:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27  1:31 [PATCH v4 1/1] alix2: supplement driver to include GPIO button support Philip Prindeville
2012-01-27  1:57 ` Andres Salomon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120126175741.6aa4a9cd@queued.net \
    --to=dilinger@queued.net \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=kernel@wildgooses.com \
    --cc=philipp@redfish-solutions.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.