From: Greg KH <gregkh@suse.de>
To: Paul Walmsley <paul@pwsan.com>
Cc: govindraj.raja@ti.com, khilman@ti.com, tomi.valkeinen@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree
Date: Thu, 26 Jan 2012 11:16:04 -0800 [thread overview]
Message-ID: <20120126191604.GA15516@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1201252124470.11174@utopia.booyaka.com>
On Wed, Jan 25, 2012 at 09:31:53PM -0700, Paul Walmsley wrote:
> On Wed, 25 Jan 2012, Greg KH wrote:
>
> > On Wed, Jan 25, 2012 at 08:02:09PM -0700, Paul Walmsley wrote:
> > > On Tue, 24 Jan 2012, gregkh@suse.de wrote:
> > > >
> > > > This is a note to let you know that I've just added the patch titled
> > > >
> > > > tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA
> > > >
> > > > to my tty git tree which can be found at
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > > > in the tty-linus branch.
> > >
> > > If it's not too late, I was wondering if you could drop this patch and the
> > > subsequent one ("tty: serial: OMAP: transmit FIFO threshold interrupts
> > > don't wake the"), in favor of the second version of this series that was
> > > just posted at
> > >
> > > http://marc.info/?l=linux-arm-kernel&m=132754676814391&w=2
> > >
> > > If it is too late, we'll deal with it in 3.4.
> >
> > What is wrong with the patches that I applied?
>
> A new workaround is used that reduces the number of interrupts to normal.
> The commit messages are improved since we have a better idea of what was
> wrong. There is also a new patch (patch 3) for a power management
> regression in the driver.
>
> > How about a fix-up patch on top of what I have applied instead of whole
> > new ones?
>
> That's fine, if that's your preference. It will be several patches,
> though. And about 75% of the previous series would be reverted, since a
> different workaround would be used.
>
> Let me know if that is indeed what you'd like.
Ok, I've just reverted both of these patches for now, please send new
ones when you have them.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@suse.de (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree
Date: Thu, 26 Jan 2012 11:16:04 -0800 [thread overview]
Message-ID: <20120126191604.GA15516@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1201252124470.11174@utopia.booyaka.com>
On Wed, Jan 25, 2012 at 09:31:53PM -0700, Paul Walmsley wrote:
> On Wed, 25 Jan 2012, Greg KH wrote:
>
> > On Wed, Jan 25, 2012 at 08:02:09PM -0700, Paul Walmsley wrote:
> > > On Tue, 24 Jan 2012, gregkh at suse.de wrote:
> > > >
> > > > This is a note to let you know that I've just added the patch titled
> > > >
> > > > tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA
> > > >
> > > > to my tty git tree which can be found at
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > > > in the tty-linus branch.
> > >
> > > If it's not too late, I was wondering if you could drop this patch and the
> > > subsequent one ("tty: serial: OMAP: transmit FIFO threshold interrupts
> > > don't wake the"), in favor of the second version of this series that was
> > > just posted at
> > >
> > > http://marc.info/?l=linux-arm-kernel&m=132754676814391&w=2
> > >
> > > If it is too late, we'll deal with it in 3.4.
> >
> > What is wrong with the patches that I applied?
>
> A new workaround is used that reduces the number of interrupts to normal.
> The commit messages are improved since we have a better idea of what was
> wrong. There is also a new patch (patch 3) for a power management
> regression in the driver.
>
> > How about a fix-up patch on top of what I have applied instead of whole
> > new ones?
>
> That's fine, if that's your preference. It will be several patches,
> though. And about 75% of the previous series would be reverted, since a
> different workaround would be used.
>
> Let me know if that is indeed what you'd like.
Ok, I've just reverted both of these patches for now, please send new
ones when you have them.
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-26 19:16 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13274430881471@kroah.org>
2012-01-26 3:02 ` patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree Paul Walmsley
2012-01-26 3:02 ` Paul Walmsley
2012-01-26 4:21 ` Greg KH
2012-01-26 4:21 ` Greg KH
2012-01-26 4:31 ` Paul Walmsley
2012-01-26 4:31 ` Paul Walmsley
2012-01-26 19:16 ` Greg KH [this message]
2012-01-26 19:16 ` Greg KH
2012-01-26 19:34 ` Paul Walmsley
2012-01-26 19:34 ` Paul Walmsley
2012-02-02 20:03 ` Paul Walmsley
2012-02-02 20:03 ` Paul Walmsley
2012-02-02 20:22 ` Greg KH
2012-02-02 20:22 ` Greg KH
2012-02-03 4:07 ` NeilBrown
2012-02-03 4:07 ` NeilBrown
2012-02-03 5:45 ` Paul Walmsley
2012-02-03 5:45 ` Paul Walmsley
2012-02-03 9:54 ` NeilBrown
2012-02-03 9:54 ` NeilBrown
2012-02-03 11:42 ` Grazvydas Ignotas
2012-02-03 11:42 ` Grazvydas Ignotas
2012-02-03 12:11 ` NeilBrown
2012-02-03 12:11 ` NeilBrown
2012-02-03 19:49 ` Paul Walmsley
2012-02-03 19:49 ` Paul Walmsley
2012-02-03 20:34 ` Paul Walmsley
2012-02-03 20:34 ` Paul Walmsley
2012-02-03 21:42 ` Paul Walmsley
2012-02-03 21:42 ` Paul Walmsley
2012-02-03 22:10 ` NeilBrown
2012-02-03 22:10 ` NeilBrown
2012-02-03 22:30 ` Paul Walmsley
2012-02-03 22:30 ` Paul Walmsley
2012-02-04 0:23 ` Woodruff, Richard
2012-02-04 0:23 ` Woodruff, Richard
2012-02-04 0:59 ` Paul Walmsley
2012-02-04 0:59 ` Paul Walmsley
2012-02-04 1:46 ` Woodruff, Richard
2012-02-04 1:46 ` Woodruff, Richard
2012-02-04 2:39 ` Paul Walmsley
2012-02-04 2:39 ` Paul Walmsley
2012-02-04 2:31 ` NeilBrown
2012-02-04 2:31 ` NeilBrown
2012-02-07 1:00 ` Woodruff, Richard
2012-02-07 1:00 ` Woodruff, Richard
2012-02-03 19:42 ` Paul Walmsley
2012-02-03 19:42 ` Paul Walmsley
2012-02-03 20:44 ` NeilBrown
2012-02-03 20:44 ` NeilBrown
2012-02-03 21:04 ` Paul Walmsley
2012-02-03 21:04 ` Paul Walmsley
2012-02-04 16:00 ` Grazvydas Ignotas
2012-02-04 16:00 ` Grazvydas Ignotas
2012-02-04 16:31 ` Paul Walmsley
2012-02-04 16:31 ` Paul Walmsley
2012-02-04 16:57 ` Russell King - ARM Linux
2012-02-04 16:57 ` Russell King - ARM Linux
2012-02-04 17:32 ` Paul Walmsley
2012-02-04 17:32 ` Paul Walmsley
2012-02-04 17:55 ` Russell King - ARM Linux
2012-02-04 17:55 ` Russell King - ARM Linux
2012-02-04 19:37 ` Paul Walmsley
2012-02-04 19:37 ` Paul Walmsley
2012-02-05 12:16 ` Russell King - ARM Linux
2012-02-05 12:16 ` Russell King - ARM Linux
2012-02-08 15:50 ` Paul Walmsley
2012-02-08 15:50 ` Paul Walmsley
2012-02-04 16:39 ` Russell King - ARM Linux
2012-02-04 16:39 ` Russell King - ARM Linux
2012-02-04 16:49 ` Paul Walmsley
2012-02-04 16:49 ` Paul Walmsley
2012-02-04 16:55 ` Paul Walmsley
2012-02-04 16:55 ` Paul Walmsley
2012-02-04 17:01 ` Russell King - ARM Linux
2012-02-04 17:01 ` Russell King - ARM Linux
2012-02-04 17:22 ` Paul Walmsley
2012-02-04 17:22 ` Paul Walmsley
2012-02-04 17:47 ` Russell King - ARM Linux
2012-02-04 17:47 ` Russell King - ARM Linux
2012-02-04 18:59 ` Tony Lindgren
2012-02-04 18:59 ` Tony Lindgren
2012-02-04 19:24 ` Paul Walmsley
2012-02-04 19:24 ` Paul Walmsley
2012-02-04 20:07 ` Russell King - ARM Linux
2012-02-04 20:07 ` Russell King - ARM Linux
2012-02-05 15:37 ` Woodruff, Richard
2012-02-05 15:37 ` Woodruff, Richard
2012-02-05 16:03 ` Russell King - ARM Linux
2012-02-05 16:03 ` Russell King - ARM Linux
2012-02-05 17:57 ` Woodruff, Richard
2012-02-05 17:57 ` Woodruff, Richard
2012-02-06 23:58 ` NeilBrown
2012-02-06 23:58 ` NeilBrown
2012-02-07 1:13 ` Woodruff, Richard
2012-02-07 1:13 ` Woodruff, Richard
2012-02-03 19:34 ` Paul Walmsley
2012-02-03 19:34 ` Paul Walmsley
2012-02-03 20:10 ` Paul Walmsley
2012-02-03 20:10 ` Paul Walmsley
2012-02-03 21:59 ` NeilBrown
2012-02-03 21:59 ` NeilBrown
2012-02-03 23:02 ` Paul Walmsley
2012-02-03 23:02 ` Paul Walmsley
2012-02-04 0:01 ` NeilBrown
2012-02-04 0:01 ` NeilBrown
2012-02-04 2:06 ` Paul Walmsley
2012-02-04 2:06 ` Paul Walmsley
2012-02-04 2:12 ` Paul Walmsley
2012-02-04 2:12 ` Paul Walmsley
2012-02-04 3:09 ` NeilBrown
2012-02-04 3:09 ` NeilBrown
2012-02-04 3:16 ` Paul Walmsley
2012-02-04 3:16 ` Paul Walmsley
2012-02-04 3:43 ` NeilBrown
2012-02-04 3:43 ` NeilBrown
2012-02-04 3:56 ` Paul Walmsley
2012-02-04 3:56 ` Paul Walmsley
2012-02-04 4:17 ` NeilBrown
2012-02-04 4:17 ` NeilBrown
2012-02-03 6:56 ` Govindraj
2012-02-03 6:56 ` Govindraj
2012-02-03 12:07 ` NeilBrown
2012-02-03 12:07 ` NeilBrown
2012-02-03 12:20 ` Russell King - ARM Linux
2012-02-03 12:20 ` Russell King - ARM Linux
2012-02-03 19:54 ` Paul Walmsley
2012-02-03 19:54 ` Paul Walmsley
2012-02-03 12:12 ` Felipe Contreras
2012-02-03 12:12 ` Felipe Contreras
2012-02-02 21:02 ` Greg KH
2012-02-02 21:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126191604.GA15516@suse.de \
--to=gregkh@suse.de \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.