Re: [PATCH] spi: spi-sh: add IORESOURCE_MEM_TYPE_MASK decoding for access size

[Paul Mundt <lethal@linux-sh.org>]

On Fri, Jan 27, 2012 at 10:14:49AM +0900, Shimoda, Yoshihiro wrote:
> 2012/01/26 19:22, Paul Mundt wrote:
> > On Thu, Jan 26, 2012 at 05:43:57PM +0900, Shimoda, Yoshihiro wrote:
> [ snip ]
> >>  static void spi_sh_set_bit(struct spi_sh_data *ss, unsigned long val,
> >> @@ -464,6 +473,18 @@ static int __devinit spi_sh_probe(struct platform_device *pdev)
> >>  	ss = spi_master_get_devdata(master);
> >>  	dev_set_drvdata(&pdev->dev, ss);
> >>
> >> +	switch (res->flags & IORESOURCE_MEM_TYPE_MASK) {
> >> +	case IORESOURCE_MEM_8BIT:
> >> +		ss->width = 8;
> >> +		break;
> >> +	case IORESOURCE_MEM_32BIT:
> >> +		ss->width = 32;
> >> +		break;
> >> +	default:
> >> +		dev_err(&pdev->dev, "No support width\n");
> >> +		ret = -ENODEV;
> >> +		goto error1;
> > 
> > If the default up to this point has been 32-bit only then it makes sense
> > for 32 to still remain the default. The 8-bit user is presumably a new
> > one and therefore has no existing platform data configuration to worry
> > about, while this change would require existing users to be updated for
> > the new 32-bit flag to behave the same way they have up until now. 
> 
> Thank you for your comment.
> Unfortunately, the value of IORESOURCE_MEM_8BIT is (0<<3), so existing users
> will not enter to the default.
> 
Ah, ok, I missed that. In that case I suppose your original patch makes
the most sense. We should be able to roll in the platform update patch
early anyways.