From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir@xen.org>,
Andres Lagar-Cavilla <andres@lagarcavilla.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [xen-unstable bisection] complete build-amd64
Date: Fri, 27 Jan 2012 10:51:20 +0100 [thread overview]
Message-ID: <20120127095120.GA12283@aepfle.de> (raw)
In-Reply-To: <20257.36117.343474.863135@mariner.uk.xensource.com>
On Thu, Jan 26, Ian Jackson wrote:
> cc1: warnings being treated as errors
> xc_mem_paging.c: In function 'xc_mem_paging_load':
> xc_mem_paging.c:90: error: statement with no effect
> make[3]: *** [xc_mem_paging.o] Error 1
> make[3]: Leaving directory `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[2]: *** [build] Error 2
> make[2]: Leaving directory `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2
> make[1]: *** Waiting for unfinished jobs....
As Andrew Morton put it once: "We code in C, not in cpp".
extras/mini-os/include/posix/sys/mman.h:19:#define munlock(addr, len) ((void)(addr), (void)(len), 0)
As such, that define should be "static inline munlock(const void *addr, size_t len) { return 0; }".
And now that I actually look at that header, mlock should be changed as
well. All this "(void)fn()" mess is really confusing.
Olaf
next prev parent reply other threads:[~2012-01-27 9:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:23 [xen-unstable bisection] complete build-amd64 xen.org
2012-01-26 17:27 ` Ian Jackson
2012-01-26 17:38 ` Keir Fraser
2012-01-26 17:39 ` Ian Jackson
2012-01-27 9:51 ` Olaf Hering [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-11 16:46 xen.org
2012-11-30 22:01 xen.org
2012-01-14 0:43 xen.org
2011-12-02 20:35 xen.org
2011-11-23 0:24 xen.org
2011-09-13 15:27 xen.org
2010-12-03 17:29 xen.org
2010-12-03 17:40 ` Ian Jackson
2010-12-02 5:41 xen.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127095120.GA12283@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=andres@lagarcavilla.org \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.