Re: [xen-unstable bisection] complete build-amd64

[Keir Fraser <keir.xen@gmail.com>]

On 26/01/2012 17:27, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> xen.org writes ("[xen-unstable bisection] complete build-amd64"):
>> branch xen-unstable
>> xen branch xen-unstable
>> job build-amd64
>> test xen-build
>> 
>> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
>> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
>> 
>> *** Found and reproduced problem changeset ***
>> 
>>   Bug is in tree:  xen http://xenbits.xen.org/staging/xen-unstable.hg
>>   Bug introduced:  d5b706214616
>>   Bug not present: 1e27e827e6a8
>> 
>> 
>>   changeset:   24566:d5b706214616
>>   user:        Olaf Hering <olaf@aepfle.de>
>>   date:        Thu Jan 26 11:04:59 2012 +0000
>>       
>>       tools/libxc: fix error handling in xc_mem_paging_load
>>       
>>       xc_mem_paging_load() does not pass errors in errno and the actual
>>       errno from xc_mem_event_control() is overwritten by munlock().
>>       xenpaging_populate_page() needs to check errno, but with the switch to
>>       xc_mem_paging_load() it could not receive ENOMEM anymore.
>>       
>>       Update xc_mem_paging_load() to return -1 and preserve errno during
>>       munlock().
>>       
>>       Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>       Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
>>       Committed-by: Keir Fraser <keir@xen.org>
> 
> cc1: warnings being treated as errors
> xc_mem_paging.c: In function 'xc_mem_paging_load':
> xc_mem_paging.c:90: error: statement with no effect
> make[3]: *** [xc_mem_paging.o] Error 1
> make[3]: Leaving directory
> `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[2]: *** [build] Error 2
> make[2]: Leaving directory
> `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2
> make[1]: *** Waiting for unfinished jobs....

Tim already fixed it.

 -- Keir