From: Christoph Hellwig <hch@infradead.org>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Alex Elder <elder@kernel.org>,
yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers <bpm@sgi.com>,
Alex Elder <aelder@sgi.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans()
Date: Fri, 27 Jan 2012 05:52:53 -0500 [thread overview]
Message-ID: <20120127105253.GA23335@infradead.org> (raw)
In-Reply-To: <20120127063726.16227.681.stgit@ltc219.sdl.hitachi.co.jp>
On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote:
> The kmem_realloc() in xfs is given KM_* memory allocation flags. And it
> allocates memory using kmalloc() after they are converted to gfp_mask
> flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(),
> instead of them. I guess it is preferred to use them, and here memory must
> be allocated but don't have to be done with GFP_ATOMIC. So, this patch
> changes it to KM_SLEEP.
Looks good. I actually just noticed it when changing the kmem_realloc
implementation, but let's put your patch in before that and send it off
to Linus ASAP.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
xfs-masters@oss.sgi.com, yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans()
Date: Fri, 27 Jan 2012 05:52:53 -0500 [thread overview]
Message-ID: <20120127105253.GA23335@infradead.org> (raw)
In-Reply-To: <20120127063726.16227.681.stgit@ltc219.sdl.hitachi.co.jp>
On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote:
> The kmem_realloc() in xfs is given KM_* memory allocation flags. And it
> allocates memory using kmalloc() after they are converted to gfp_mask
> flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(),
> instead of them. I guess it is preferred to use them, and here memory must
> be allocated but don't have to be done with GFP_ATOMIC. So, this patch
> changes it to KM_SLEEP.
Looks good. I actually just noticed it when changing the kmem_realloc
implementation, but let's put your patch in before that and send it off
to Linus ASAP.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2012-01-27 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 6:37 [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans() Mitsuo Hayasaka
2012-01-27 6:37 ` Mitsuo Hayasaka
2012-01-27 10:52 ` Christoph Hellwig [this message]
2012-01-27 10:52 ` Christoph Hellwig
2012-01-31 17:50 ` Ben Myers
2012-01-31 17:50 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127105253.GA23335@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mitsuo.hayasaka.hu@hitachi.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.