* [PATCH v2] S3C24XX DMA resume regression fix
@ 2012-01-20 13:13 ` Gusakov Andrey
0 siblings, 0 replies; 6+ messages in thread
From: Gusakov Andrey @ 2012-01-20 13:13 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim, Rafael J. Wysocki, Sergei Shtylyov,
Sergey Lapin
Cc: linux-arm-kernel, linux-samsung-soc, Gusakov Andrey
In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
(Use struct syscore_ops for "core" power management)
suspend/resume hooks for each DMA channels were replaced with
hooks that suspend/resume all channels. s3c2410_dma_suspend
suspends channels from 0 to dma_channels. s3c2410_dma_resume
resumes channels in reverse order. So pointer should be
decremented insted of being incremented.
Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
---
arch/arm/plat-s3c24xx/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
v2: updated commit message with original commit summary
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
index 57abec9..16510d5 100644
--- a/arch/arm/plat-s3c24xx/dma.c
+++ b/arch/arm/plat-s3c24xx/dma.c
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
int channel;
- for (channel = dma_channels - 1; channel >= 0; cp++, channel--)
+ for (channel = dma_channels - 1; channel >= 0; cp--, channel--)
s3c2410_dma_resume_chan(cp);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] S3C24XX DMA resume regression fix
@ 2012-01-20 13:13 ` Gusakov Andrey
0 siblings, 0 replies; 6+ messages in thread
From: Gusakov Andrey @ 2012-01-20 13:13 UTC (permalink / raw)
To: linux-arm-kernel
In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
(Use struct syscore_ops for "core" power management)
suspend/resume hooks for each DMA channels were replaced with
hooks that suspend/resume all channels. s3c2410_dma_suspend
suspends channels from 0 to dma_channels. s3c2410_dma_resume
resumes channels in reverse order. So pointer should be
decremented insted of being incremented.
Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
---
arch/arm/plat-s3c24xx/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
v2: updated commit message with original commit summary
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
index 57abec9..16510d5 100644
--- a/arch/arm/plat-s3c24xx/dma.c
+++ b/arch/arm/plat-s3c24xx/dma.c
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
int channel;
- for (channel = dma_channels - 1; channel >= 0; cp++, channel--)
+ for (channel = dma_channels - 1; channel >= 0; cp--, channel--)
s3c2410_dma_resume_chan(cp);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] S3C24XX DMA resume regression fix
2012-01-20 13:13 ` Gusakov Andrey
@ 2012-01-27 12:25 ` Sergey Lapin
-1 siblings, 0 replies; 6+ messages in thread
From: Sergey Lapin @ 2012-01-27 12:25 UTC (permalink / raw)
To: Gusakov Andrey
Cc: Ben Dooks, Kukjin Kim, Rafael J. Wysocki, Sergei Shtylyov,
linux-samsung-soc, linux-arm-kernel
On Fri, Jan 20, 2012 at 05:13:04PM +0400, Gusakov Andrey wrote:
> In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
> (Use struct syscore_ops for "core" power management)
> suspend/resume hooks for each DMA channels were replaced with
> hooks that suspend/resume all channels. s3c2410_dma_suspend
> suspends channels from 0 to dma_channels. s3c2410_dma_resume
> resumes channels in reverse order. So pointer should be
> decremented insted of being incremented.
Any news regarding this patch?
>
> Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
> ---
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> v2: updated commit message with original commit summary
>
All the best,
S.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] S3C24XX DMA resume regression fix
@ 2012-01-27 12:25 ` Sergey Lapin
0 siblings, 0 replies; 6+ messages in thread
From: Sergey Lapin @ 2012-01-27 12:25 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2012 at 05:13:04PM +0400, Gusakov Andrey wrote:
> In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
> (Use struct syscore_ops for "core" power management)
> suspend/resume hooks for each DMA channels were replaced with
> hooks that suspend/resume all channels. s3c2410_dma_suspend
> suspends channels from 0 to dma_channels. s3c2410_dma_resume
> resumes channels in reverse order. So pointer should be
> decremented insted of being incremented.
Any news regarding this patch?
>
> Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
> ---
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> v2: updated commit message with original commit summary
>
All the best,
S.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] S3C24XX DMA resume regression fix
2012-01-27 12:25 ` Sergey Lapin
@ 2012-01-31 11:27 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2012-01-31 11:27 UTC (permalink / raw)
To: 'Sergey Lapin', 'Gusakov Andrey'
Cc: 'Ben Dooks', 'Rafael J. Wysocki',
'Sergei Shtylyov', linux-samsung-soc, linux-arm-kernel
Sergey Lapin wrote:
>
> On Fri, Jan 20, 2012 at 05:13:04PM +0400, Gusakov Andrey wrote:
> > In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
Just the first 12 hex digits of the commit id is enough now as Linus said?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> > (Use struct syscore_ops for "core" power management)
> > suspend/resume hooks for each DMA channels were replaced with
> > hooks that suspend/resume all channels. s3c2410_dma_suspend
> > suspends channels from 0 to dma_channels. s3c2410_dma_resume
> > resumes channels in reverse order. So pointer should be
> > decremented insted of being incremented.
> Any news regarding this patch?
> >
> > Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
> > ---
> > arch/arm/plat-s3c24xx/dma.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > v2: updated commit message with original commit summary
> >
>
> All the best,
> S.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] S3C24XX DMA resume regression fix
@ 2012-01-31 11:27 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2012-01-31 11:27 UTC (permalink / raw)
To: linux-arm-kernel
Sergey Lapin wrote:
>
> On Fri, Jan 20, 2012 at 05:13:04PM +0400, Gusakov Andrey wrote:
> > In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b
Just the first 12 hex digits of the commit id is enough now as Linus said?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> > (Use struct syscore_ops for "core" power management)
> > suspend/resume hooks for each DMA channels were replaced with
> > hooks that suspend/resume all channels. s3c2410_dma_suspend
> > suspends channels from 0 to dma_channels. s3c2410_dma_resume
> > resumes channels in reverse order. So pointer should be
> > decremented insted of being incremented.
> Any news regarding this patch?
> >
> > Signed-off-by: Gusakov Andrey <dron0gus@gmail.com>
> > ---
> > arch/arm/plat-s3c24xx/dma.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > v2: updated commit message with original commit summary
> >
>
> All the best,
> S.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-31 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-20 13:13 [PATCH v2] S3C24XX DMA resume regression fix Gusakov Andrey
2012-01-20 13:13 ` Gusakov Andrey
2012-01-27 12:25 ` Sergey Lapin
2012-01-27 12:25 ` Sergey Lapin
2012-01-31 11:27 ` Kukjin Kim
2012-01-31 11:27 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.