From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2] hwmon/mc13xxx-adc: add support for the MC13892 PMIC
Date: Sat, 28 Jan 2012 17:34:34 +0000 [thread overview]
Message-ID: <20120128173434.GD3861@ericsson.com> (raw)
In-Reply-To: <1317158169-25372-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Jan 27, 2012 at 04:35:29PM -0500, Jean Delvare wrote:
> On Fri, 27 Jan 2012 13:22:08 -0800, Guenter Roeck wrote:
> > I have been asked about adding support for ADC channels 0, 1, 3, 4, as
> > well as the non-GP usage of channels 5 to 7.
>
> I'm interested in temperature sensors too, i.e. channels 5 and 7 if I'm
> not mistaken.
>
> > Does anyone happen to know/recall why those are not supported in the
> > current driver ?
>
> No idea, maybe just starting simple, or lack of interest.
>
Maybe the perceived problem is that gain and offset are different and all over the place
for the various ADCs, so one either needs a whole bunch of functions, or a large
case statement, or a table with <gain, offset> per adc. I'd choose the latter,
to simplify runtime code. Also, the description of adc->temperature conversion
is really quite confusing.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-01-28 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 21:16 [lm-sensors] [PATCH v2] hwmon/mc13xxx-adc: add support for the Uwe Kleine-König
2011-09-29 16:38 ` Guenter Roeck
2011-09-29 18:59 ` Uwe Kleine-König
2012-01-05 13:44 ` Jean Delvare
2012-01-23 9:01 ` [lm-sensors] [PATCH v2] hwmon/mc13xxx-adc: add support for the MC13892 PMIC Uwe Kleine-König
2012-01-27 16:53 ` Jean Delvare
2012-01-27 19:48 ` Uwe Kleine-König
2012-01-27 21:22 ` Guenter Roeck
2012-01-27 21:28 ` Jean Delvare
2012-01-27 21:35 ` Jean Delvare
2012-01-28 17:34 ` Guenter Roeck [this message]
2012-01-28 18:15 ` Jean Delvare
2012-01-28 18:42 ` Guenter Roeck
2012-01-28 20:47 ` Jean Delvare
2012-01-30 7:27 ` David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128173434.GD3861@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.