From: Marek Lindner <lindner_marek@yahoo.de>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht should not override user supplied rts setting
Date: Sun, 29 Jan 2012 02:43:47 +0800 [thread overview]
Message-ID: <201201290243.47953.lindner_marek@yahoo.de> (raw)
In-Reply-To: <4F23F753.8070405@openwrt.org>
On Saturday, January 28, 2012 21:25:39 Felix Fietkau wrote:
> On 2012-01-28 8:17 AM, Marek Lindner wrote:
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
>
> NACK, minstrel_ht sets RTS/CTS only from the second rate retry slot on,
> to increase the success probability during retransmissions. For the
> first slot, it is unset. The user supplied rts setting is not suitable
> for configuring RTS/CTS usage this way, so if you want to disable it
> entirely, you'd need to add a new setting for that.
If you think it is unsuitable do you mind elaborating what this setting is
for? As far as I can tell minstrel_ht is the only rate control algorithm that
decides to be smarter than the user configuring the device. Without mentioning
this anywhere! IMHO it should be minstrel_ht explaining why this makes sense,
not the other way round.
Regards,
Marek
next prev parent reply other threads:[~2012-01-28 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 7:17 [RFC] minstrel_ht should not override user supplied rts Marek Lindner
2012-01-28 7:17 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Marek Lindner
2012-01-28 13:25 ` Felix Fietkau
2012-01-28 18:43 ` Marek Lindner [this message]
2012-01-28 18:51 ` Felix Fietkau
2012-01-28 19:17 ` Daniel Halperin
2012-01-28 19:28 ` Felix Fietkau
2012-01-28 19:58 ` Marek Lindner
2012-01-28 20:03 ` Daniel Halperin
2012-01-28 20:09 ` Marek Lindner
2012-01-28 20:26 ` Daniel Halperin
2012-01-28 20:35 ` Marek Lindner
2012-01-28 22:14 ` Simon Wunderlich
2012-01-29 2:36 ` Felix Fietkau
2012-01-28 20:20 ` Felix Fietkau
2012-01-28 20:23 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 9:52 iwlwifi updates for 3.6 Johannes Berg
2012-06-11 9:53 ` [PATCH 09/13] iwlwifi: comment that setting driver_data overrides info->control Johannes Berg
2014-09-23 10:10 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Guido Gavilanes
2014-09-23 11:44 Guido Gavilanes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201290243.47953.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.