From: Felix Fietkau <nbd@openwrt.org>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: Daniel Halperin <dhalperi@cs.washington.edu>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht should not override user supplied rts setting
Date: Sat, 28 Jan 2012 21:20:24 +0100 [thread overview]
Message-ID: <4F245888.2070202@openwrt.org> (raw)
In-Reply-To: <201201290358.35433.lindner_marek@yahoo.de>
On 2012-01-28 8:58 PM, Marek Lindner wrote:
>> I'm with Felix: I could see adding an option that means "force never
>> use RTS/CTS" but I think we're at the right operating point when
>> interpreting the standard "RTS/CTS threshold" option.
>
> Actually, this option exists already. It's just minstrel_ht overriding it:
> iw phy <phyname> set rts <rts threshold|off>
> Put special attention towards the "off" at the end.
>
> If we let the rate algorithm override our rts settings it should at least be
> communicated. I found no such mention anywhere.
>
> I'd like to further stress the point that no other rate algorithm does this.
> We create incoherent and hard to debug behavior.
Which rate algorithms did you check to come to that conclusion? I just
looked at the ath9k rate control algorithm and it does the same ;)
- Felix
next prev parent reply other threads:[~2012-01-28 20:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 7:17 [RFC] minstrel_ht should not override user supplied rts Marek Lindner
2012-01-28 7:17 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Marek Lindner
2012-01-28 13:25 ` Felix Fietkau
2012-01-28 18:43 ` Marek Lindner
2012-01-28 18:51 ` Felix Fietkau
2012-01-28 19:17 ` Daniel Halperin
2012-01-28 19:28 ` Felix Fietkau
2012-01-28 19:58 ` Marek Lindner
2012-01-28 20:03 ` Daniel Halperin
2012-01-28 20:09 ` Marek Lindner
2012-01-28 20:26 ` Daniel Halperin
2012-01-28 20:35 ` Marek Lindner
2012-01-28 22:14 ` Simon Wunderlich
2012-01-29 2:36 ` Felix Fietkau
2012-01-28 20:20 ` Felix Fietkau [this message]
2012-01-28 20:23 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 9:52 iwlwifi updates for 3.6 Johannes Berg
2012-06-11 9:53 ` [PATCH 09/13] iwlwifi: comment that setting driver_data overrides info->control Johannes Berg
2014-09-23 10:10 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Guido Gavilanes
2014-09-23 11:44 Guido Gavilanes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F245888.2070202@openwrt.org \
--to=nbd@openwrt.org \
--cc=dhalperi@cs.washington.edu \
--cc=lindner_marek@yahoo.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.