From: Olaf Hering <olaf@aepfle.de>
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] tools/libxc: make volatile keyword for bitmap operations optional
Date: Mon, 30 Jan 2012 10:10:02 +0100 [thread overview]
Message-ID: <20120130091002.GA29543@aepfle.de> (raw)
In-Reply-To: <CB4BF80F.29F55%keir.xen@gmail.com>
On Mon, Jan 30, Keir Fraser wrote:
> On 30/01/2012 00:36, "Olaf Hering" <olaf@aepfle.de> wrote:
>
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1327883694 -3600
> > # Node ID 5da4c273e819d5a1d42f3186f0829f8e00d83132
> > # Parent b06617b0398c73c63ce153f39464fd1edac788e5
> > tools/libxc: make volatile keyword for bitmap operations optional
> >
> > Except for xc_save, all bitmaps maintained by xc_bitops.h are used in single
> > threaded applications. So nothing will change the bitmaps content, adding
> > volatile adds just unneeded memory reloads.
>
> The bitops aren't threadsafe anyway, as none of them use atomic rmw
> instructions. I suspect the volatile declarations are completely pointless
> and can just be removed.
Will gcc use the right thing if the array is passed to the hyperviso,
and will it reload everything after the hypercall? If yes, the volatile
can indeed go.
Olaf
next prev parent reply other threads:[~2012-01-30 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 0:36 [PATCH] tools/libxc: make volatile keyword for bitmap operations optional Olaf Hering
2012-01-30 7:32 ` Keir Fraser
2012-01-30 9:10 ` Olaf Hering [this message]
2012-01-30 9:30 ` Keir Fraser
2012-01-30 10:26 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130091002.GA29543@aepfle.de \
--to=olaf@aepfle.de \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.