From: Olaf Hering <olaf@aepfle.de>
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] tools/libxc: make volatile keyword for bitmap operations optional
Date: Mon, 30 Jan 2012 11:26:21 +0100 [thread overview]
Message-ID: <20120130102621.GB9935@aepfle.de> (raw)
In-Reply-To: <CB4C13A9.29F65%keir.xen@gmail.com>
On Mon, Jan 30, Keir Fraser wrote:
> On 30/01/2012 09:10, "Olaf Hering" <olaf@aepfle.de> wrote:
> > Will gcc use the right thing if the array is passed to the hyperviso,
> > and will it reload everything after the hypercall? If yes, the volatile
> > can indeed go.
>
> Of course. Lots of things would fail to work if calls to outside the current
> linkage unit didn't flush/invalidate cached shared-data accesses. That's a
> fundamental C compiler thing.
You are right, after thinking about it I came to the same conclusion.
I will send an updated patch.
Olaf
prev parent reply other threads:[~2012-01-30 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 0:36 [PATCH] tools/libxc: make volatile keyword for bitmap operations optional Olaf Hering
2012-01-30 7:32 ` Keir Fraser
2012-01-30 9:10 ` Olaf Hering
2012-01-30 9:30 ` Keir Fraser
2012-01-30 10:26 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130102621.GB9935@aepfle.de \
--to=olaf@aepfle.de \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.