* [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC @ 2012-01-28 20:55 Uwe Kleine-König 2012-01-30 8:45 ` Jean Delvare 2012-01-30 13:20 ` Guenter Roeck 0 siblings, 2 replies; 3+ messages in thread From: Uwe Kleine-König @ 2012-01-28 20:55 UTC (permalink / raw) To: lm-sensors QmFzZWQgb24gYSBwYXRjaCBieSBEYXZpZCBKYW5kZXIgdGhhdCBtb3N0bHkgZGlkIHMvbWMxMzc4 My9tYzEzeHh4LwoKQ2M6IERhdmlkIEphbmRlciA8ZGF2aWQuamFuZGVyQHByb3RvbmljLm5sPgpT aWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJv bml4LmRlPgotLS0KSGVsbG8sCgpJIGRpZG4ndCBtYW5hZ2UgdG8gc2VuZCB0aGlzICJsYXRlciB0 b2RheSIgYXMgcHJvbWlzZWQgeWVzdGVyZGF5LiBTbyBpdApjb21lcyBvbmx5IHRvZGF5LgoKVGhh bmtzClV3ZQoKY2hhbmdlcyBzaW5jZSB2MjoKIC0gbWFrZSBjb2RlIGdlbmVyYXRpbmcgbmFtZSBh dHRyaWJ1dGUgbW9yZSByb2J1c3QgYW5kIHN0cmlwIFstX11hZGMKIC0gY29uc2lzdGVubHkgdXNl IE1DMTM3ODNfQURDXzE2Q0hBTlMgLyBtYzEzNzgzX2F0dHJfMTZjaGFucwoKIERvY3VtZW50YXRp b24vaHdtb24vbWMxMzc4My1hZGMgfCAgIDQ4ICsrKysrKysrKysrKy0tLS0KIGRyaXZlcnMvaHdt b24vS2NvbmZpZyAgICAgICAgICAgfCAgICA2ICstCiBkcml2ZXJzL2h3bW9uL21jMTM3ODMtYWRj LmMgICAgIHwgIDExNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDMg ZmlsZXMgY2hhbmdlZCwgMTI2IGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vaHdtb24vbWMxMzc4My1hZGMgYi9Eb2N1bWVudGF0aW9uL2h3 bW9uL21jMTM3ODMtYWRjCmluZGV4IDA0NDUzMWEuLjg2ZjZkYTUgMTAwNjQ0Ci0tLSBhL0RvY3Vt ZW50YXRpb24vaHdtb24vbWMxMzc4My1hZGMKKysrIGIvRG9jdW1lbnRhdGlvbi9od21vbi9tYzEz NzgzLWFkYwpAQCAtNSw2ICs1LDkgQEAgU3VwcG9ydGVkIGNoaXBzOgogICAqIEZyZWVzY2FsZSBB dGxhcyBNQzEzNzgzCiAgICAgUHJlZml4OiAnbWMxMzc4M19hZGMnCiAgICAgRGF0YXNoZWV0OiBo dHRwOi8vd3d3LmZyZWVzY2FsZS5jb20vZmlsZXMvcmZfaWYvZG9jL2RhdGFfc2hlZXQvTUMxMzc4 My5wZGY/ZnNyY2g9MQorICAqIEZyZWVzY2FsZSBBdGxhcyBNQzEzODkyCisgICAgUHJlZml4OiAn bWMxMzg5Ml9hZGMnCisgICAgRGF0YXNoZWV0OiBodHRwOi8vY2FjaGUuZnJlZXNjYWxlLmNvbS9m aWxlcy9hbmFsb2cvZG9jL2RhdGFfc2hlZXQvTUMxMzg5Mi5wZGY/ZnNyY2g9MSZzcj0xCiAKIEF1 dGhvcnM6CiAgICAgU2FzY2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJvbml4LmRlPgpAQCAtMTMs MjAgKzE2LDIxIEBAIEF1dGhvcnM6CiBEZXNjcmlwdGlvbgogLS0tLS0tLS0tLS0KIAotVGhlIEZy ZWVzY2FsZSBNQzEzNzgzIGlzIGEgUG93ZXIgTWFuYWdlbWVudCBhbmQgQXVkaW8gQ2lyY3VpdC4g QW1vbmcKLW90aGVyIHRoaW5ncyBpdCBjb250YWlucyBhIDEwLWJpdCBBL0QgY29udmVydGVyLiBU aGUgY29udmVydGVyIGhhcyAxNgotY2hhbm5lbHMgd2hpY2ggY2FuIGJlIHVzZWQgaW4gZGlmZmVy ZW50IG1vZGVzLgotVGhlIEEvRCBjb252ZXJ0ZXIgaGFzIGEgcmVzb2x1dGlvbiBvZiAyLjI1bVYu IENoYW5uZWxzIDAtNCBoYXZlCi1hIGRlZGljYXRlZCBtZWFuaW5nIHdpdGggY2hpcCBpbnRlcm5h bCBzY2FsaW5nIGFwcGxpZWQuIENoYW5uZWxzIDUtNwotY2FuIGJlIHVzZWQgYXMgZ2VuZXJhbCBw dXJwb3NlIGlucHV0cyBvciBhbHRlcm5hdGl2ZWx5IGluIGEgZGVkaWNhdGVkCi1tb2RlLiBDaGFu bmVscyAxMi0xNSBhcmUgb2NjdXBpZWQgYnkgdGhlIHRvdWNoc2NyZWVuIGlmIGl0J3MgYWN0aXZl LgorVGhlIEZyZWVzY2FsZSBNQzEzNzgzIGFuZCBNQzEzODkyIGFyZSBQb3dlciBNYW5hZ2VtZW50 IGFuZCBBdWRpbyBDaXJjdWl0cy4KK0Ftb25nIG90aGVyIHRoaW5ncyB0aGV5IGNvbnRhaW4gYSAx MC1iaXQgQS9EIGNvbnZlcnRlci4gVGhlIGNvbnZlcnRlciBoYXMgMTYKKyhNQzEzNzgzKSByZXNw LiAxMiAoTUMxMzg5MikgY2hhbm5lbHMgd2hpY2ggY2FuIGJlIHVzZWQgaW4gZGlmZmVyZW50IG1v ZGVzLiBUaGUKK0EvRCBjb252ZXJ0ZXIgaGFzIGEgcmVzb2x1dGlvbiBvZiAyLjI1bVYuCiAKLUN1 cnJlbnRseSB0aGUgZHJpdmVyIG9ubHkgc3VwcG9ydHMgY2hhbm5lbHMgMiBhbmQgNS0xNSB3aXRo IG5vIGFsdGVybmF0aXZlCi1tb2RlcyBmb3IgY2hhbm5lbHMgNS03LgorU29tZSBjaGFubmVscyBj YW4gYmUgdXNlZCBhcyBHZW5lcmFsIFB1cnBvc2UgaW5wdXRzIG9yIGluIGEgZGVkaWNhdGVkIG1v ZGUgd2l0aAorYSBjaGlwIGludGVybmFsIHNjYWxpbmcgYXBwbGllZCAuCiAKLVNlZSB0aGlzIHRh YmxlIGZvciB0aGUgbWVhbmluZyBvZiB0aGUgZGlmZmVyZW50IGNoYW5uZWxzIGFuZCB0aGVpciBj aGlwCi1pbnRlcm5hbCBzY2FsaW5nOgorQ3VycmVudGx5IHRoZSBkcml2ZXIgb25seSBzdXBwb3J0 cyB0aGUgQXBwbGljYXRpb24gU3VwcGx5IGNoYW5uZWwgKEJQIC8gQlBTTlMpLAordGhlIEdlbmVy YWwgUHVycG9zZSBpbnB1dHMgYW5kIHRvdWNoc2NyZWVuLgogCitTZWUgdGhlIGZvbGxvd2luZyB0 YWJsZXMgZm9yIHRoZSBtZWFuaW5nIG9mIHRoZSBkaWZmZXJlbnQgY2hhbm5lbHMgYW5kIHRoZWly CitjaGlwIGludGVybmFsIHNjYWxpbmc6CisKK01DMTM3ODM6CiBDaGFubmVsCVNpZ25hbAkJCQkJ CUlucHV0IFJhbmdlCVNjYWxpbmcKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDAJQmF0dGVyeSBW b2x0YWdlIChCQVRUKQkJCQkyLjUwIC0gNC42NVYJLTIuNDBWCkBAIC0zNCw3ICszOCw3IEBAIENo YW5uZWwJU2lnbmFsCQkJCQkJSW5wdXQgUmFuZ2UJU2NhbGluZwogMglBcHBsaWNhdGlvbiBTdXBw bHkgKEJQKQkJCQkyLjUwIC0gNC42NVYJLTIuNDBWCiAzCUNoYXJnZXIgVm9sdGFnZSAoQ0hSR1JB VykJCQkwIC0gMTBWIC8JLzUKIAkJCQkJCQkwIC0gMjBWCQkvMTAKLTQJQ2hhcmdlciBDdXJyZW50 IChDSFJHSVNOU1AtQ0hSR0lTTlNOKQkJLTAuMjVWIC0gMC4yNVYJeDQKKzQJQ2hhcmdlciBDdXJy ZW50IChDSFJHSVNOU1AtQ0hSR0lTTlNOKQkJLTAuMjUgLSAwLjI1Vgl4NAogNQlHZW5lcmFsIFB1 cnBvc2UgQURJTjUgLyBCYXR0ZXJ5IFBhY2sgVGhlcm1pc3RvcgkwIC0gMi4zMFYJTm8KIDYJR2Vu ZXJhbCBQdXJwb3NlIEFESU42IC8gQmFja3VwIFZvbHRhZ2UgKExJQ0VMTCkJMCAtIDIuMzBWIC8J Tm8gLwogCQkJCQkJCTEuNTAgLSAzLjUwVgktMS4yMFYKQEAgLTQ4LDMgKzUyLDIzIEBAIENoYW5u ZWwJU2lnbmFsCQkJCQkJSW5wdXQgUmFuZ2UJU2NhbGluZwogMTMJR2VuZXJhbCBQdXJwb3NlIFRT WDIgLyBUb3VjaHNjcmVlbiBYLXBsYXRlIDIJMCAtIDIuMzBWCU5vCiAxNAlHZW5lcmFsIFB1cnBv c2UgVFNZMSAvIFRvdWNoc2NyZWVuIFktcGxhdGUgMQkwIC0gMi4zMFYJTm8KIDE1CUdlbmVyYWwg UHVycG9zZSBUU1kyIC8gVG91Y2hzY3JlZW4gWS1wbGF0ZSAyCTAgLSAyLjMwVglObworCitNQzEz ODkyOgorQ2hhbm5lbAlTaWduYWwJCQkJCQlJbnB1dCBSYW5nZQlTY2FsaW5nCistLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiswCUJhdHRlcnkgVm9sdGFnZSAoQkFUVCkJCQkJMCAtIDQuOFYJLzIKKzEJ QmF0dGVyeSBDdXJyZW50IChCQVRUIC0gQkFUVElTTlNDQykJCS02MCAtIDYwIG1WCXgyMAorMglB cHBsaWNhdGlvbiBTdXBwbHkgKEJQU05TKQkJCTAgLSA0LjhWCS8yCiszCUNoYXJnZXIgVm9sdGFn ZSAoQ0hSR1JBVykJCQkwIC0gMTJWIC8JLzUKKwkJCQkJCQkwIC0gMjBWCQkvMTAKKzQJQ2hhcmdl ciBDdXJyZW50IChDSFJHSVNOUy1CUFNOUykgLwkJLTAuMyAtIDAuM1YgLwl4NCAvCisJVG91Y2hz Y3JlZW4gWC1wbGF0ZSAxCQkJCTAgLSAyLjRWCU5vCis1CUdlbmVyYWwgUHVycG9zZSBBRElONSAv CUJhdHRlcnkgUGFjayBUaGVybWlzdG9yCTAgLSAyLjRWCU5vCis2CUdlbmVyYWwgUHVycG9zZSBB RElONiAvIEJhY2t1cCBWb2x0YWdlIChMSUNFTEwpCTAgLSAyLjRWIC8JTm8KKwlCYWNrdXAgVm9s dGFnZSAoTElDRUxMKSAgICAgICAgICAgICAgICAgICAgICAgIAkwIC0gMy42Vgl4Mi8zCis3CUdl bmVyYWwgUHVycG9zZSBBRElONyAvIFVJRCAvIERpZSBUZW1wZXJhdHVyZQkwIC0gMi40ViAvCU5v IC8KKwkJCQkJCQkwIC0gNC44VgkvMgorMTIJVG91Y2hzY3JlZW4gWC1wbGF0ZSAxCQkJCTAgLSAy LjRWCU5vCisxMwlUb3VjaHNjcmVlbiBYLXBsYXRlIDIJCQkJMCAtIDIuNFYJTm8KKzE0CVRvdWNo c2NyZWVuIFktcGxhdGUgMQkJCQkwIC0gMi40VglObworMTUJVG91Y2hzY3JlZW4gWS1wbGF0ZSAy CQkJCTAgLSAyLjRWCU5vCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL0tjb25maWcgYi9kcml2 ZXJzL2h3bW9uL0tjb25maWcKaW5kZXggMDIyNjA0MC4uOWMwMjBiZCAxMDA2NDQKLS0tIGEvZHJp dmVycy9od21vbi9LY29uZmlnCisrKyBiL2RyaXZlcnMvaHdtb24vS2NvbmZpZwpAQCAtMTM1NSwx MCArMTM1NSwxMCBAQCBjb25maWcgU0VOU09SU19BUFBMRVNNQwogCSAgdGhlIGF3ZXNvbWUgcG93 ZXIgb2YgYXBwbGVzbWMuCiAKIGNvbmZpZyBTRU5TT1JTX01DMTM3ODNfQURDCi0gICAgICAgIHRy aXN0YXRlICJGcmVlc2NhbGUgTUMxMzc4MyBBREMiCi0gICAgICAgIGRlcGVuZHMgb24gTUZEX01D MTM3ODMKKyAgICAgICAgdHJpc3RhdGUgIkZyZWVzY2FsZSBNQzEzNzgzL01DMTM4OTIgQURDIgor ICAgICAgICBkZXBlbmRzIG9uIE1GRF9NQzEzWFhYCiAgICAgICAgIGhlbHAKLSAgICAgICAgICBT dXBwb3J0IGZvciB0aGUgQS9EIGNvbnZlcnRlciBvbiBNQzEzNzgzIFBNSUMuCisgICAgICAgICAg U3VwcG9ydCBmb3IgdGhlIEEvRCBjb252ZXJ0ZXIgb24gTUMxMzc4MyBhbmQgTUMxMzg5MiBQTUlD LgogCiBpZiBBQ1BJCiAKZGlmZiAtLWdpdCBhL2RyaXZlcnMvaHdtb24vbWMxMzc4My1hZGMuYyBi L2RyaXZlcnMvaHdtb24vbWMxMzc4My1hZGMuYwppbmRleCBlZjY1YWI1Li41ZDhkMjY1IDEwMDY0 NAotLS0gYS9kcml2ZXJzL2h3bW9uL21jMTM3ODMtYWRjLmMKKysrIGIvZHJpdmVycy9od21vbi9t YzEzNzgzLWFkYy5jCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIERyaXZlciBmb3IgdGhlIEZyZWVz Y2FsZSBTZW1pY29uZHVjdG9yIE1DMTM3ODMgYWRjLgorICogRHJpdmVyIGZvciB0aGUgQURDIG9u IEZyZWVzY2FsZSBTZW1pY29uZHVjdG9yIE1DMTM3ODMgYW5kIE1DMTM4OTIgUE1JQ3MuCiAgKgog ICogQ29weXJpZ2h0IDIwMDQtMjAwNyBGcmVlc2NhbGUgU2VtaWNvbmR1Y3RvciwgSW5jLiBBbGwg UmlnaHRzIFJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDA5IFNhc2NoYSBIYXVlciwgUGVu Z3V0cm9uaXgKQEAgLTE4LDcgKzE4LDcgQEAKICAqIEZyYW5rbGluIFN0LCBGaWZ0aCBGbG9vciwg Qm9zdG9uLCBNQSAwMjExMC0xMzAxIFVTQQogICovCiAKLSNpbmNsdWRlIDxsaW51eC9tZmQvbWMx Mzc4My5oPgorI2luY2x1ZGUgPGxpbnV4L21mZC9tYzEzeHh4Lmg+CiAjaW5jbHVkZSA8bGludXgv cGxhdGZvcm1fZGV2aWNlLmg+CiAjaW5jbHVkZSA8bGludXgvaHdtb24tc3lzZnMuaD4KICNpbmNs dWRlIDxsaW51eC9rZXJuZWwuaD4KQEAgLTI4LDE3ICsyOCwyNSBAQAogI2luY2x1ZGUgPGxpbnV4 L2luaXQuaD4KICNpbmNsdWRlIDxsaW51eC9lcnIuaD4KIAotI2RlZmluZSBNQzEzNzgzX0FEQ19O QU1FCSJtYzEzNzgzLWFkYyIKKyNkZWZpbmUgRFJJVkVSX05BTUUJIm1jMTM3ODMtYWRjIgorCisv KiBwbGF0Zm9ybSBkZXZpY2UgaWQgZHJpdmVyIGRhdGEgKi8KKyNkZWZpbmUgTUMxMzc4M19BRENf MTZDSEFOUwkxCisjZGVmaW5lIE1DMTM3ODNfQURDX0JQRElWMgkyCiAKIHN0cnVjdCBtYzEzNzgz X2FkY19wcml2IHsKIAlzdHJ1Y3QgbWMxM3h4eCAqbWMxM3h4eDsKIAlzdHJ1Y3QgZGV2aWNlICpo d21vbl9kZXY7CisJY2hhciBuYW1lWzEwXTsKIH07CiAKIHN0YXRpYyBzc2l6ZV90IG1jMTM3ODNf YWRjX3Nob3dfbmFtZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2VfYXR0cmlidXRl CiAJCQkgICAgICAqZGV2YXR0ciwgY2hhciAqYnVmKQogewotCXJldHVybiBzcHJpbnRmKGJ1Ziwg Im1jMTM3ODNfYWRjXG4iKTsKKwlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gdG9fcGxh dGZvcm1fZGV2aWNlKGRldik7CisJc3RydWN0IG1jMTM3ODNfYWRjX3ByaXYgKnByaXYgPSBwbGF0 Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKKworCXJldHVybiBzcHJpbnRmKGJ1ZiwgIiVzXG4iLCBw cml2LT5uYW1lKTsKIH0KIAogc3RhdGljIGludCBtYzEzNzgzX2FkY19yZWFkKHN0cnVjdCBkZXZp Y2UgKmRldiwKQEAgLTY4LDE2ICs3NiwyMSBAQCBzdGF0aWMgc3NpemVfdCBtYzEzNzgzX2FkY19y ZWFkX2JwKHN0cnVjdCBkZXZpY2UgKmRldiwKIAkJc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmRl dmF0dHIsIGNoYXIgKmJ1ZikKIHsKIAl1bnNpZ25lZCB2YWw7CisJc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldiA9IHRvX3BsYXRmb3JtX2RldmljZShkZXYpOworCWtlcm5lbF91bG9uZ190IGRy aXZlcl9kYXRhID0gcGxhdGZvcm1fZ2V0X2RldmljZV9pZChwZGV2KS0+ZHJpdmVyX2RhdGE7CiAJ aW50IHJldCA9IG1jMTM3ODNfYWRjX3JlYWQoZGV2LCBkZXZhdHRyLCAmdmFsKTsKIAogCWlmIChy ZXQpCiAJCXJldHVybiByZXQ7CiAKLQkvKgotCSAqIEJQIChjaGFubmVsIDIpIHJlcG9ydHMgd2l0 aCBvZmZzZXQgMi40ViB0byB0aGUgYWN0dWFsIHZhbHVlIHRvIGZpdAotCSAqIHRoZSBpbnB1dCBy YW5nZSBvZiB0aGUgQURDLiAgdW5pdCA9IDIuMjVtViA9IDkvNCBtVi4KLQkgKi8KLQl2YWwgPSBE SVZfUk9VTkRfQ0xPU0VTVCh2YWwgKiA5LCA0KSArIDI0MDA7CisJaWYgKGRyaXZlcl9kYXRhICYg TUMxMzc4M19BRENfQlBESVYyKQorCQl2YWwgPSBESVZfUk9VTkRfQ0xPU0VTVCh2YWwgKiA5LCAy KTsKKwllbHNlCisJCS8qCisJCSAqIEJQIChjaGFubmVsIDIpIHJlcG9ydHMgd2l0aCBvZmZzZXQg Mi40ViB0byB0aGUgYWN0dWFsIHZhbHVlCisJCSAqIHRvIGZpdCB0aGUgaW5wdXQgcmFuZ2Ugb2Yg dGhlIEFEQy4gIHVuaXQgPSAyLjI1bVYgPSA5LzQgbVYuCisJCSAqLworCQl2YWwgPSBESVZfUk9V TkRfQ0xPU0VTVCh2YWwgKiA5LCA0KSArIDI0MDA7CiAKIAlyZXR1cm4gc3ByaW50ZihidWYsICIl dVxuIiwgdmFsKTsKIH0KQEAgLTExNCwxMiArMTI3LDIxIEBAIHN0YXRpYyBTRU5TT1JfREVWSUNF X0FUVFIoaW4xM19pbnB1dCwgU19JUlVHTywgbWMxMzc4M19hZGNfcmVhZF9ncCwgTlVMTCwgMTMp Owogc3RhdGljIFNFTlNPUl9ERVZJQ0VfQVRUUihpbjE0X2lucHV0LCBTX0lSVUdPLCBtYzEzNzgz X2FkY19yZWFkX2dwLCBOVUxMLCAxNCk7CiBzdGF0aWMgU0VOU09SX0RFVklDRV9BVFRSKGluMTVf aW5wdXQsIFNfSVJVR08sIG1jMTM3ODNfYWRjX3JlYWRfZ3AsIE5VTEwsIDE1KTsKIAotc3RhdGlj IHN0cnVjdCBhdHRyaWJ1dGUgKm1jMTM3ODNfYXR0cltdID0geworc3RhdGljIHN0cnVjdCBhdHRy aWJ1dGUgKm1jMTM3ODNfYXR0cl9iYXNlW10gPSB7CiAJJmRldl9hdHRyX25hbWUuYXR0ciwKIAkm c2Vuc29yX2Rldl9hdHRyX2luMl9pbnB1dC5kZXZfYXR0ci5hdHRyLAogCSZzZW5zb3JfZGV2X2F0 dHJfaW41X2lucHV0LmRldl9hdHRyLmF0dHIsCiAJJnNlbnNvcl9kZXZfYXR0cl9pbjZfaW5wdXQu ZGV2X2F0dHIuYXR0ciwKIAkmc2Vuc29yX2Rldl9hdHRyX2luN19pbnB1dC5kZXZfYXR0ci5hdHRy LAorCU5VTEwKK307CisKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwIG1jMTM3 ODNfZ3JvdXBfYmFzZSA9IHsKKwkuYXR0cnMgPSBtYzEzNzgzX2F0dHJfYmFzZSwKK307CisKKy8q IHRoZXNlIGFyZSBvbmx5IHVzZWQgaWYgTUMxMzc4M19BRENfMTZDSEFOUyBpcyBwcm92aWRlZCBp biBkcml2ZXIgZGF0YSAqLworc3RhdGljIHN0cnVjdCBhdHRyaWJ1dGUgKm1jMTM3ODNfYXR0cl8x NmNoYW5zW10gPSB7CiAJJnNlbnNvcl9kZXZfYXR0cl9pbjhfaW5wdXQuZGV2X2F0dHIuYXR0ciwK IAkmc2Vuc29yX2Rldl9hdHRyX2luOV9pbnB1dC5kZXZfYXR0ci5hdHRyLAogCSZzZW5zb3JfZGV2 X2F0dHJfaW4xMF9pbnB1dC5kZXZfYXR0ci5hdHRyLApAQCAtMTI3LDggKzE0OSw4IEBAIHN0YXRp YyBzdHJ1Y3QgYXR0cmlidXRlICptYzEzNzgzX2F0dHJbXSA9IHsKIAlOVUxMCiB9OwogCi1zdGF0 aWMgY29uc3Qgc3RydWN0IGF0dHJpYnV0ZV9ncm91cCBtYzEzNzgzX2dyb3VwID0gewotCS5hdHRy cyA9IG1jMTM3ODNfYXR0ciwKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwIG1j MTM3ODNfZ3JvdXBfMTZjaGFucyA9IHsKKwkuYXR0cnMgPSBtYzEzNzgzX2F0dHJfMTZjaGFucywK IH07CiAKIC8qIGxhc3QgZm91ciBjaGFubmVscyBtYXkgYmUgb2NjdXBpZWQgYnkgdGhlIHRvdWNo c2NyZWVuICovCkBAIC0xNTYsMjQgKzE3OCwzOCBAQCBzdGF0aWMgaW50IF9faW5pdCBtYzEzNzgz X2FkY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogewogCXN0cnVjdCBtYzEz NzgzX2FkY19wcml2ICpwcml2OwogCWludCByZXQ7CisJY29uc3Qgc3RydWN0IHBsYXRmb3JtX2Rl dmljZV9pZCAqaWQgPSBwbGF0Zm9ybV9nZXRfZGV2aWNlX2lkKHBkZXYpOworCWNoYXIgKmRhc2g7 CiAKIAlwcml2ID0ga3phbGxvYyhzaXplb2YoKnByaXYpLCBHRlBfS0VSTkVMKTsKIAlpZiAoIXBy aXYpCiAJCXJldHVybiAtRU5PTUVNOwogCiAJcHJpdi0+bWMxM3h4eCA9IGRldl9nZXRfZHJ2ZGF0 YShwZGV2LT5kZXYucGFyZW50KTsKKwlzbnByaW50Zihwcml2LT5uYW1lLCBBUlJBWV9TSVpFKHBy aXYtPm5hbWUpLCAiJXMiLCBpZC0+bmFtZSk7CisJZGFzaCA9IHN0cmNocihwcml2LT5uYW1lLCAn LScpOworCWlmIChkYXNoKQorCQkqZGFzaCA9ICdcMCc7CiAKIAlwbGF0Zm9ybV9zZXRfZHJ2ZGF0 YShwZGV2LCBwcml2KTsKIAogCS8qIFJlZ2lzdGVyIHN5c2ZzIGhvb2tzICovCi0JcmV0ID0gc3lz ZnNfY3JlYXRlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgJm1jMTM3ODNfZ3JvdXApOworCXJldCA9 IHN5c2ZzX2NyZWF0ZV9ncm91cCgmcGRldi0+ZGV2LmtvYmosICZtYzEzNzgzX2dyb3VwX2Jhc2Up OwogCWlmIChyZXQpCi0JCWdvdG8gb3V0X2Vycl9jcmVhdGUxOworCQlnb3RvIG91dF9lcnJfY3Jl YXRlX2Jhc2U7CiAKLQlpZiAoIW1jMTM3ODNfYWRjX3VzZV90b3VjaHNjcmVlbihwZGV2KSkgewot CQlyZXQgPSBzeXNmc19jcmVhdGVfZ3JvdXAoJnBkZXYtPmRldi5rb2JqLCAmbWMxMzc4M19ncm91 cF90cyk7CisJaWYgKGlkLT5kcml2ZXJfZGF0YSAmIE1DMTM3ODNfQURDXzE2Q0hBTlMpIHsKKwkJ cmV0ID0gc3lzZnNfY3JlYXRlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwKKwkJCQkmbWMxMzc4M19n cm91cF8xNmNoYW5zKTsKIAkJaWYgKHJldCkKLQkJCWdvdG8gb3V0X2Vycl9jcmVhdGUyOworCQkJ Z290byBvdXRfZXJyX2NyZWF0ZV8xNmNoYW5zOworCisJCWlmICghbWMxMzc4M19hZGNfdXNlX3Rv dWNoc2NyZWVuKHBkZXYpKSB7CisJCQlyZXQgPSBzeXNmc19jcmVhdGVfZ3JvdXAoJnBkZXYtPmRl di5rb2JqLAorCQkJCQkmbWMxMzc4M19ncm91cF90cyk7CisJCQlpZiAocmV0KQorCQkJCWdvdG8g b3V0X2Vycl9jcmVhdGVfdHM7CisJCX0KIAl9CiAKIAlwcml2LT5od21vbl9kZXYgPSBod21vbl9k ZXZpY2VfcmVnaXN0ZXIoJnBkZXYtPmRldik7CkBAIC0xODQsMTcgKzIyMCwyMSBAQCBzdGF0aWMg aW50IF9faW5pdCBtYzEzNzgzX2FkY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQogCQlnb3RvIG91dF9lcnJfcmVnaXN0ZXI7CiAJfQogCi0KIAlyZXR1cm4gMDsKIAogb3V0X2Vy cl9yZWdpc3RlcjoKIAotCWlmICghbWMxMzc4M19hZGNfdXNlX3RvdWNoc2NyZWVuKHBkZXYpKQot CQlzeXNmc19yZW1vdmVfZ3JvdXAoJnBkZXYtPmRldi5rb2JqLCAmbWMxMzc4M19ncm91cF90cyk7 Ci1vdXRfZXJyX2NyZWF0ZTI6CisJaWYgKGlkLT5kcml2ZXJfZGF0YSAmIE1DMTM3ODNfQURDXzE2 Q0hBTlMpIHsKKwkJaWYgKCFtYzEzNzgzX2FkY191c2VfdG91Y2hzY3JlZW4ocGRldikpCisJCQlz eXNmc19yZW1vdmVfZ3JvdXAoJnBkZXYtPmRldi5rb2JqLCAmbWMxMzc4M19ncm91cF90cyk7Citv dXRfZXJyX2NyZWF0ZV90czoKKworCQlzeXNmc19yZW1vdmVfZ3JvdXAoJnBkZXYtPmRldi5rb2Jq LCAmbWMxMzc4M19ncm91cF8xNmNoYW5zKTsKKwl9CitvdXRfZXJyX2NyZWF0ZV8xNmNoYW5zOgog Ci0Jc3lzZnNfcmVtb3ZlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgJm1jMTM3ODNfZ3JvdXApOwot b3V0X2Vycl9jcmVhdGUxOgorCXN5c2ZzX3JlbW92ZV9ncm91cCgmcGRldi0+ZGV2LmtvYmosICZt YzEzNzgzX2dyb3VwX2Jhc2UpOworb3V0X2Vycl9jcmVhdGVfYmFzZToKIAogCXBsYXRmb3JtX3Nl dF9kcnZkYXRhKHBkZXYsIE5VTEwpOwogCWtmcmVlKHByaXYpOwpAQCAtMjA1LDEzICsyNDUsMTgg QEAgb3V0X2Vycl9jcmVhdGUxOgogc3RhdGljIGludCBfX2RldmV4aXQgbWMxMzc4M19hZGNfcmVt b3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB7CiAJc3RydWN0IG1jMTM3ODNfYWRj X3ByaXYgKnByaXYgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKKwlrZXJuZWxfdWxvbmdf dCBkcml2ZXJfZGF0YSA9IHBsYXRmb3JtX2dldF9kZXZpY2VfaWQocGRldiktPmRyaXZlcl9kYXRh OwogCiAJaHdtb25fZGV2aWNlX3VucmVnaXN0ZXIocHJpdi0+aHdtb25fZGV2KTsKIAotCWlmICgh bWMxMzc4M19hZGNfdXNlX3RvdWNoc2NyZWVuKHBkZXYpKQotCQlzeXNmc19yZW1vdmVfZ3JvdXAo JnBkZXYtPmRldi5rb2JqLCAmbWMxMzc4M19ncm91cF90cyk7CisJaWYgKGRyaXZlcl9kYXRhICYg TUMxMzc4M19BRENfMTZDSEFOUykgeworCQlpZiAoIW1jMTM3ODNfYWRjX3VzZV90b3VjaHNjcmVl bihwZGV2KSkKKwkJCXN5c2ZzX3JlbW92ZV9ncm91cCgmcGRldi0+ZGV2LmtvYmosICZtYzEzNzgz X2dyb3VwX3RzKTsKIAotCXN5c2ZzX3JlbW92ZV9ncm91cCgmcGRldi0+ZGV2LmtvYmosICZtYzEz NzgzX2dyb3VwKTsKKwkJc3lzZnNfcmVtb3ZlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgJm1jMTM3 ODNfZ3JvdXBfMTZjaGFucyk7CisJfQorCisJc3lzZnNfcmVtb3ZlX2dyb3VwKCZwZGV2LT5kZXYu a29iaiwgJm1jMTM3ODNfZ3JvdXBfYmFzZSk7CiAKIAlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2 LCBOVUxMKTsKIAlrZnJlZShwcml2KTsKQEAgLTIxOSwxMiArMjY0LDI2IEBAIHN0YXRpYyBpbnQg X19kZXZleGl0IG1jMTM3ODNfYWRjX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQogCXJldHVybiAwOwogfQogCitzdGF0aWMgY29uc3Qgc3RydWN0IHBsYXRmb3JtX2RldmljZV9p ZCBtYzEzNzgzX2FkY19pZHRhYmxlW10gPSB7CisJeworCQkubmFtZSA9ICJtYzEzNzgzLWFkYyIs CisJCS5kcml2ZXJfZGF0YSA9IE1DMTM3ODNfQURDXzE2Q0hBTlMsCisJfSwgeworCQkubmFtZSA9 ICJtYzEzODkyLWFkYyIsCisJCS5kcml2ZXJfZGF0YSA9IE1DMTM3ODNfQURDX0JQRElWMiwKKwl9 LCB7CisJCS8qIHNlbnRpbmVsICovCisJfQorfTsKK01PRFVMRV9ERVZJQ0VfVEFCTEUocGxhdGZv cm0sIG1jMTM3ODNfYWRjX2lkdGFibGUpOworCiBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZl ciBtYzEzNzgzX2FkY19kcml2ZXIgPSB7Ci0JLnJlbW92ZSAJPSBfX2RldmV4aXRfcChtYzEzNzgz X2FkY19yZW1vdmUpLAorCS5yZW1vdmUJCT0gX19kZXZleGl0X3AobWMxMzc4M19hZGNfcmVtb3Zl KSwKIAkuZHJpdmVyCQk9IHsKIAkJLm93bmVyCT0gVEhJU19NT0RVTEUsCi0JCS5uYW1lCT0gTUMx Mzc4M19BRENfTkFNRSwKKwkJLm5hbWUJPSBEUklWRVJfTkFNRSwKIAl9LAorCS5pZF90YWJsZQk9 IG1jMTM3ODNfYWRjX2lkdGFibGUsCiB9OwogCiBzdGF0aWMgaW50IF9faW5pdCBtYzEzNzgzX2Fk Y19pbml0KHZvaWQpCkBAIC0yNDMsNCArMzAyLDMgQEAgbW9kdWxlX2V4aXQobWMxMzc4M19hZGNf ZXhpdCk7CiBNT0RVTEVfREVTQ1JJUFRJT04oIk1DMTM3ODMgQURDIGRyaXZlciIpOwogTU9EVUxF X0FVVEhPUigiTHVvdGFvIEZ1IDxsLmZ1QHBlbmd1dHJvbml4LmRlPiIpOwogTU9EVUxFX0xJQ0VO U0UoIkdQTCIpOwotTU9EVUxFX0FMSUFTKCJwbGF0Zm9ybToiIE1DMTM3ODNfQURDX05BTUUpOwot LSAKMS43LjguMwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0 cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC 2012-01-28 20:55 [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC Uwe Kleine-König @ 2012-01-30 8:45 ` Jean Delvare 2012-01-30 13:20 ` Guenter Roeck 1 sibling, 0 replies; 3+ messages in thread From: Jean Delvare @ 2012-01-30 8:45 UTC (permalink / raw) To: lm-sensors SGkgVXdlLAoKT24gU2F0LCAyOCBKYW4gMjAxMiAyMTo1NTowNyArMDEwMCwgVXdlIEtsZWluZS1L w7ZuaWcgd3JvdGU6Cj4gQmFzZWQgb24gYSBwYXRjaCBieSBEYXZpZCBKYW5kZXIgdGhhdCBtb3N0 bHkgZGlkIHMvbWMxMzc4My9tYzEzeHh4Lwo+IAo+IENjOiBEYXZpZCBKYW5kZXIgPGRhdmlkLmph bmRlckBwcm90b25pYy5ubD4KPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+IEhlbGxvLAo+IAo+IEkgZGlkbid0 IG1hbmFnZSB0byBzZW5kIHRoaXMgImxhdGVyIHRvZGF5IiBhcyBwcm9taXNlZCB5ZXN0ZXJkYXku IFNvIGl0Cj4gY29tZXMgb25seSB0b2RheS4KCk5vIHByb2JsZW0gOikKCj4gY2hhbmdlcyBzaW5j ZSB2MjoKPiAgLSBtYWtlIGNvZGUgZ2VuZXJhdGluZyBuYW1lIGF0dHJpYnV0ZSBtb3JlIHJvYnVz dCBhbmQgc3RyaXAgWy1fXWFkYwo+ICAtIGNvbnNpc3Rlbmx5IHVzZSBNQzEzNzgzX0FEQ18xNkNI QU5TIC8gbWMxMzc4M19hdHRyXzE2Y2hhbnMKClRoYW5rcyBmb3IgdGhlIHVwZGF0ZS4gSSBoYXZl IGEgZmV3IG1vcmUgY29tbWVudHMsIGJ1dCB0aGVzZSBhcmUgb25seQptaW5vciB0aGluZ3MuCgo+ ICBEb2N1bWVudGF0aW9uL2h3bW9uL21jMTM3ODMtYWRjIHwgICA0OCArKysrKysrKysrKystLS0t Cj4gIGRyaXZlcnMvaHdtb24vS2NvbmZpZyAgICAgICAgICAgfCAgICA2ICstCj4gIGRyaXZlcnMv aHdtb24vbWMxMzc4My1hZGMuYyAgICAgfCAgMTE2ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDEyNiBpbnNlcnRpb25zKCspLCA0NCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9od21vbi9tYzEzNzgz LWFkYyBiL0RvY3VtZW50YXRpb24vaHdtb24vbWMxMzc4My1hZGMKPiBpbmRleCAwNDQ1MzFhLi44 NmY2ZGE1IDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vaHdtb24vbWMxMzc4My1hZGMKPiAr KysgYi9Eb2N1bWVudGF0aW9uL2h3bW9uL21jMTM3ODMtYWRjCj4gQEAgLTUsNiArNSw5IEBAIFN1 cHBvcnRlZCBjaGlwczoKPiAgICAqIEZyZWVzY2FsZSBBdGxhcyBNQzEzNzgzCj4gICAgICBQcmVm aXg6ICdtYzEzNzgzX2FkYycKPiAgICAgIERhdGFzaGVldDogaHR0cDovL3d3dy5mcmVlc2NhbGUu Y29tL2ZpbGVzL3JmX2lmL2RvYy9kYXRhX3NoZWV0L01DMTM3ODMucGRmP2ZzcmNoPTEKPiArICAq IEZyZWVzY2FsZSBBdGxhcyBNQzEzODkyCj4gKyAgICBQcmVmaXg6ICdtYzEzODkyX2FkYycKPiAr ICAgIERhdGFzaGVldDogaHR0cDovL2NhY2hlLmZyZWVzY2FsZS5jb20vZmlsZXMvYW5hbG9nL2Rv Yy9kYXRhX3NoZWV0L01DMTM4OTIucGRmP2ZzcmNoPTEmc3I9MQoKVGhlIF9hZGMgaXMgZ29uZSBm cm9tIHRoZSBwcmVmaXhlcyB3aXRoIHRoaXMgdmVyc2lvbiwgc28gdGhlCmRvY3VtZW50YXRpb24g c2hvdWxkIGJlIHVwZGF0ZWQgdG8gcmVmbGVjdCB0aGF0LgoKPiAgc3RhdGljIHNzaXplX3QgbWMx Mzc4M19hZGNfc2hvd19uYW1lKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9hdHRy aWJ1dGUKPiAgCQkJICAgICAgKmRldmF0dHIsIGNoYXIgKmJ1ZikKPiAgewo+IC0JcmV0dXJuIHNw cmludGYoYnVmLCAibWMxMzc4M19hZGNcbiIpOwo+ICsJc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldiA9IHRvX3BsYXRmb3JtX2RldmljZShkZXYpOwo+ICsJc3RydWN0IG1jMTM3ODNfYWRjX3By aXYgKnByaXYgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKCldoZW4geW91IGRvbid0IG5l ZWQgcGRldiBpdHNlbGYsIHRoZSBhYm92ZSBjYW4gYmUgYWJicmV2aWF0ZWQgYXM6CgoJc3RydWN0 IG1jMTM3ODNfYWRjX3ByaXYgKnByaXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKClNhbWUgaW4g ZnVuY3Rpb24gbWMxMzc4M19hZGNfcmVhZCgpLiBUaGlzIGNhbiBiZSBjbGVhbmVkIHVwIGxhdGVy LCBnY2MKaXMgYXBwYXJlbnRseSBzbWFydCBlbm91Z2ggdG8gb3B0aW1pemUgaXQgYW55d2F5LgoK QWxsIHRoZSByZXN0IGxvb2tzIGdvb2QsIHNvIGFzc3VtaW5nIHRoZSBwcmVmaXhlcyBnZXQgZml4 ZWQgaW4gdGhlIGRvY3VtZW50YXRpb24sCgpBY2tlZC1ieTogSmVhbiBEZWx2YXJlIDxraGFsaUBs aW51eC1mci5vcmc+CgpHdWVudGVyLCBob3cgZG8gd2UgcHJvY2VlZD8gSSBzZWUgeW91IGhhdmUg YSBzbWFsbCBjbGVhbnVwIHBhdGNoIHRvIHRoZQptYzEzNzgzLWFkYyBkcml2ZXIgaW4geW91ciB0 cmVlLCB0aGUgc2FtZSBjbGVhbnVwIGlzIGluY2x1ZGVkIGluIFV3ZSdzCnBhdGNoIHNvIHRoZXkg d2lsbCBjb25mbGljdC4gTGV0IG1lIGtub3cgaWYgeW91IHdhbnQgdG8gdGFrZSBVd2UncwpwYXRj aCBhbmQgaGFuZGxlIHRoZSBjb25mbGljdCwgb3IgcHJlZmVyIHRvIGRyb3AgdGhlIGNsZWFudXAg cGF0Y2ggZnJvbQp5b3UgdHJlZSBhbmQgbGV0IG1lIGhhbmRsZSB0aGF0IGRyaXZlciBmb3IgdGhp cyBjeWNsZS4gRWl0aGVyIHdheSBpcwpmaW5lIHdpdGggbWUsIGFzIGxvbmcgYXMgaXQgYWN0dWFs bHkgaGFwcGVucy4KCi0tIApKZWFuIERlbHZhcmUKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNA bG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGlu Zm8vbG0tc2Vuc29ycw= ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC 2012-01-28 20:55 [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC Uwe Kleine-König 2012-01-30 8:45 ` Jean Delvare @ 2012-01-30 13:20 ` Guenter Roeck 1 sibling, 0 replies; 3+ messages in thread From: Guenter Roeck @ 2012-01-30 13:20 UTC (permalink / raw) To: lm-sensors On Mon, Jan 30, 2012 at 03:45:02AM -0500, Jean Delvare wrote: > Hi Uwe, > > On Sat, 28 Jan 2012 21:55:07 +0100, Uwe Kleine-König wrote: > > Based on a patch by David Jander that mostly did s/mc13783/mc13xxx/ > > > > Cc: David Jander <david.jander@protonic.nl> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > I didn't manage to send this "later today" as promised yesterday. So it > > comes only today. > > No problem :) > > > changes since v2: > > - make code generating name attribute more robust and strip [-_]adc > > - consistenly use MC13783_ADC_16CHANS / mc13783_attr_16chans > > Thanks for the update. I have a few more comments, but these are only > minor things. > > > Documentation/hwmon/mc13783-adc | 48 ++++++++++++---- > > drivers/hwmon/Kconfig | 6 +- > > drivers/hwmon/mc13783-adc.c | 116 +++++++++++++++++++++++++++++---------- > > 3 files changed, 126 insertions(+), 44 deletions(-) > > > > diff --git a/Documentation/hwmon/mc13783-adc b/Documentation/hwmon/mc13783-adc > > index 044531a..86f6da5 100644 > > --- a/Documentation/hwmon/mc13783-adc > > +++ b/Documentation/hwmon/mc13783-adc > > @@ -5,6 +5,9 @@ Supported chips: > > * Freescale Atlas MC13783 > > Prefix: 'mc13783_adc' > > Datasheet: http://www.freescale.com/files/rf_if/doc/data_sheet/MC13783.pdf?fsrch=1 > > + * Freescale Atlas MC13892 > > + Prefix: 'mc13892_adc' > > + Datasheet: http://cache.freescale.com/files/analog/doc/data_sheet/MC13892.pdf?fsrch=1&sr=1 > > The _adc is gone from the prefixes with this version, so the > documentation should be updated to reflect that. > > > static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attribute > > *devattr, char *buf) > > { > > - return sprintf(buf, "mc13783_adc\n"); > > + struct platform_device *pdev = to_platform_device(dev); > > + struct mc13783_adc_priv *priv = platform_get_drvdata(pdev); > > When you don't need pdev itself, the above can be abbreviated as: > > struct mc13783_adc_priv *priv = dev_get_drvdata(dev); > > Same in function mc13783_adc_read(). This can be cleaned up later, gcc > is apparently smart enough to optimize it anyway. > > All the rest looks good, so assuming the prefixes get fixed in the documentation, > > Acked-by: Jean Delvare <khali@linux-fr.org> > > Guenter, how do we proceed? I see you have a small cleanup patch to the > mc13783-adc driver in your tree, the same cleanup is included in Uwe's > patch so they will conflict. Let me know if you want to take Uwe's > patch and handle the conflict, or prefer to drop the cleanup patch from > you tree and let me handle that driver for this cycle. Either way is > fine with me, as long as it actually happens. > I'll drop the cleanup patch. Isn't much anyway. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-30 13:20 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-28 20:55 [lm-sensors] [PATCH v3] hwmon/mc13xxx-adc: add support for the MC13892 PMIC Uwe Kleine-König 2012-01-30 8:45 ` Jean Delvare 2012-01-30 13:20 ` Guenter Roeck
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.