All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [RFC 2/2] regmap: make use of cached entries in debugfs
Date: Mon, 30 Jan 2012 14:56:28 +0000	[thread overview]
Message-ID: <20120130145627.GJ4882@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327932497-28319-2-git-send-email-w.sang@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

On Mon, Jan 30, 2012 at 03:08:17PM +0100, Wolfram Sang wrote:

> -		if (!regmap_readable(map, i))
> +		if (map->cache_type == REGCACHE_NONE && !regmap_readable(map, i))

This isn't quite what you said in the changelog and isn't going to play
nicely with sparse register maps - it should be

	if (regmap_cached(map, i) || regmap_readable(map, i))

or so (regmap_cached() doesn't exist at present but it seems reasonable
that it should).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-01-30 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 14:08 [RFC 1/2] regmap: if format_write is used, declare all registers as "unreadable" Wolfram Sang
2012-01-30 14:08 ` [RFC 2/2] regmap: make use of cached entries in debugfs Wolfram Sang
2012-01-30 14:56   ` Mark Brown [this message]
2012-01-30 15:34     ` Wolfram Sang
2012-01-30 16:11       ` Mark Brown
2012-01-30 16:25 ` [RFC 1/2] regmap: if format_write is used, declare all registers as "unreadable" Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130145627.GJ4882@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.