From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [RFC 1/2] regmap: if format_write is used, declare all registers as "unreadable"
Date: Mon, 30 Jan 2012 16:25:29 +0000 [thread overview]
Message-ID: <20120130162529.GL4882@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327932497-28319-1-git-send-email-w.sang@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Mon, Jan 30, 2012 at 03:08:16PM +0100, Wolfram Sang wrote:
> Using .format_write means, we have a custom function to write to the
> chip, but not to read back. Also, mark registers as "not precious" and
> "not volatile" which is implicit because we cannot read them. Make those
> functions use 'regmap_readable' to reuse the checks done there.
Applied, thanks.
There are actually some chips that manage to implement read support in
conjunction with odd register formats but none of these are using regmap
right now and it's not altogether clear to me that it's a good idea for
them to do so as they tend to be doing entertaining things that would at
least need some framework additions. Anyone doing that work can worry
about it then.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-30 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 14:08 [RFC 1/2] regmap: if format_write is used, declare all registers as "unreadable" Wolfram Sang
2012-01-30 14:08 ` [RFC 2/2] regmap: make use of cached entries in debugfs Wolfram Sang
2012-01-30 14:56 ` Mark Brown
2012-01-30 15:34 ` Wolfram Sang
2012-01-30 16:11 ` Mark Brown
2012-01-30 16:25 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130162529.GL4882@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.