* [PATCH -next] cpufreq: fix gx-suspmod.c build
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
@ 2012-01-30 19:40 ` Randy Dunlap
2012-01-30 18:55 ` Dave Jones
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
` (5 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Randy Dunlap @ 2012-01-30 19:40 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, Hiroshi Miura, Dave Jones, cpufreq
From: Randy Dunlap <rdunlap@xenotime.net>
Fix build error & warnings:
drivers/cpufreq/gx-suspmod.c:175:35: error: macro "MODULE_DEVICE_TABLE" requires 2 arguments, but only 1 given
drivers/cpufreq/gx-suspmod.c:175:1: warning: data definition has no type or storage class
drivers/cpufreq/gx-suspmod.c:175:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Hiroshi Miura <miura@da-cha.org>
Cc: Dave Jones <davej@redhat.com>
Cc: cpufreq@vger.kernel.org
---
drivers/cpufreq/gx-suspmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120130.orig/drivers/cpufreq/gx-suspmod.c
+++ linux-next-20120130/drivers/cpufreq/gx-suspmod.c
@@ -172,7 +172,7 @@ static struct pci_device_id gx_chipset_t
{ PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5510), },
{ 0, },
};
-MODULE_DEVICE_TABLE(gx_chipset_tbl);
+MODULE_DEVICE_TABLE(x86cpu, gx_chipset_tbl);
static void gx_write_byte(int reg, int value)
{
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH -next] cpufreq: fix gx-suspmod.c build
2012-01-30 19:40 ` [PATCH -next] cpufreq: fix gx-suspmod.c build Randy Dunlap
@ 2012-01-30 18:55 ` Dave Jones
0 siblings, 0 replies; 17+ messages in thread
From: Dave Jones @ 2012-01-30 18:55 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, Hiroshi Miura, cpufreq
On Mon, Jan 30, 2012 at 11:40:50AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build error & warnings:
Needs to go through Andi, or Greg, or whoever is carrying those
cpu device autoload patches now. (I lost track)
Dave
> drivers/cpufreq/gx-suspmod.c:175:35: error: macro "MODULE_DEVICE_TABLE" requires 2 arguments, but only 1 given
> drivers/cpufreq/gx-suspmod.c:175:1: warning: data definition has no type or storage class
> drivers/cpufreq/gx-suspmod.c:175:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Hiroshi Miura <miura@da-cha.org>
> Cc: Dave Jones <davej@redhat.com>
> Cc: cpufreq@vger.kernel.org
> ---
> drivers/cpufreq/gx-suspmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120130.orig/drivers/cpufreq/gx-suspmod.c
> +++ linux-next-20120130/drivers/cpufreq/gx-suspmod.c
> @@ -172,7 +172,7 @@ static struct pci_device_id gx_chipset_t
> { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5510), },
> { 0, },
> };
> -MODULE_DEVICE_TABLE(gx_chipset_tbl);
> +MODULE_DEVICE_TABLE(x86cpu, gx_chipset_tbl);
>
> static void gx_write_byte(int reg, int value)
> {
---end quoted text---
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH -next] sound: fix include/sound/core.h warning
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
2012-01-30 19:40 ` [PATCH -next] cpufreq: fix gx-suspmod.c build Randy Dunlap
@ 2012-01-30 19:42 ` Randy Dunlap
2012-01-30 20:15 ` Takashi Iwai
2012-01-30 19:43 ` [PATCH -next] vgaarb.h: fix build warnings Randy Dunlap
` (4 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Randy Dunlap @ 2012-01-30 19:42 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Jaroslav Kysela, Takashi Iwai, alsa-devel,
Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix build warning by providing a struct stub since no fields of
the struct are used:
include/sound/core.h:454:56: warning: 'struct pci_dev' declared inside parameter list
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
---
include/sound/core.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20120130.orig/include/sound/core.h
+++ linux-next-20120130/include/sound/core.h
@@ -450,6 +450,8 @@ struct snd_pci_quirk {
{_SND_PCI_QUIRK_ID_MASK(vend, 0, 0), .value = (val)}
#endif
+struct pci_dev;
+
const struct snd_pci_quirk *
snd_pci_quirk_lookup(struct pci_dev *pci, const struct snd_pci_quirk *list);
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH -next] sound: fix include/sound/core.h warning
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
@ 2012-01-30 20:15 ` Takashi Iwai
0 siblings, 0 replies; 17+ messages in thread
From: Takashi Iwai @ 2012-01-30 20:15 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Jaroslav Kysela, alsa-devel,
Andrew Morton
At Mon, 30 Jan 2012 11:42:51 -0800,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build warning by providing a struct stub since no fields of
> the struct are used:
>
> include/sound/core.h:454:56: warning: 'struct pci_dev' declared inside parameter list
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: alsa-devel@alsa-project.org
Thanks, but it's been already fixed today in sound git tree.
Takashi
> ---
> include/sound/core.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20120130.orig/include/sound/core.h
> +++ linux-next-20120130/include/sound/core.h
> @@ -450,6 +450,8 @@ struct snd_pci_quirk {
> {_SND_PCI_QUIRK_ID_MASK(vend, 0, 0), .value = (val)}
> #endif
>
> +struct pci_dev;
> +
> const struct snd_pci_quirk *
> snd_pci_quirk_lookup(struct pci_dev *pci, const struct snd_pci_quirk *list);
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH -next] vgaarb.h: fix build warnings
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
2012-01-30 19:40 ` [PATCH -next] cpufreq: fix gx-suspmod.c build Randy Dunlap
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
@ 2012-01-30 19:43 ` Randy Dunlap
2012-03-13 21:25 ` Randy Dunlap
2012-01-31 3:08 ` Randy Dunlap
` (3 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Randy Dunlap @ 2012-01-30 19:43 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, David Airlie, dri-devel, Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix build warnings by providing a struct stub since no fields of
the struct are used:
include/linux/vgaarb.h:66:9: warning: 'struct pci_dev' declared inside parameter list
include/linux/vgaarb.h:66:9: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/vgaarb.h:99:34: warning: 'struct pci_dev' declared inside parameter list
include/linux/vgaarb.h:109:6: warning: 'struct pci_dev' declared inside parameter list
include/linux/vgaarb.h:121:8: warning: 'struct pci_dev' declared inside parameter list
include/linux/vgaarb.h:140:37: warning: 'struct pci_dev' declared inside parameter list
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
---
include/linux/vgaarb.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20120130.orig/include/linux/vgaarb.h
+++ linux-next-20120130/include/linux/vgaarb.h
@@ -47,6 +47,8 @@
*/
#define VGA_DEFAULT_DEVICE (NULL)
+struct pci_dev;
+
/* For use by clients */
/**
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH -next] vgaarb.h: fix build warnings
2012-01-30 19:43 ` [PATCH -next] vgaarb.h: fix build warnings Randy Dunlap
@ 2012-03-13 21:25 ` Randy Dunlap
0 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-03-13 21:25 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, David Airlie, dri-devel,
Andrew Morton
On 01/30/2012 11:43 AM, Randy Dunlap wrote:
This patch is still needed in linux-next of 20120313.
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build warnings by providing a struct stub since no fields of
> the struct are used:
>
> include/linux/vgaarb.h:66:9: warning: 'struct pci_dev' declared inside parameter list
> include/linux/vgaarb.h:66:9: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/vgaarb.h:99:34: warning: 'struct pci_dev' declared inside parameter list
> include/linux/vgaarb.h:109:6: warning: 'struct pci_dev' declared inside parameter list
> include/linux/vgaarb.h:121:8: warning: 'struct pci_dev' declared inside parameter list
> include/linux/vgaarb.h:140:37: warning: 'struct pci_dev' declared inside parameter list
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> ---
> include/linux/vgaarb.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20120130.orig/include/linux/vgaarb.h
> +++ linux-next-20120130/include/linux/vgaarb.h
> @@ -47,6 +47,8 @@
> */
> #define VGA_DEFAULT_DEVICE (NULL)
>
> +struct pci_dev;
> +
> /* For use by clients */
>
> /**
>
--
~Randy
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH -next] mtd: fix nand/docg4.c printk format warnings
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
@ 2012-01-31 3:08 ` Randy Dunlap
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
` (5 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:08 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, David Woodhouse, linux-mtd, Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warnings for resource_size_t:
drivers/mtd/nand/docg4.c:1277:4: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
drivers/mtd/nand/docg4.c:1277:4: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/nand/docg4.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20120130.orig/drivers/mtd/nand/docg4.c
+++ linux-next-20120130/drivers/mtd/nand/docg4.c
@@ -1273,8 +1273,9 @@ static int __init probe_docg4(struct pla
virtadr = ioremap(r->start, resource_size(r));
if (!virtadr) {
dev_err(dev, "Diskonchip ioremap failed: "
- "0x%x bytes at 0x%x\n",
- resource_size(r), r->start);
+ "0x%llx bytes at 0x%llx\n",
+ (unsigned long long)resource_size(r),
+ (unsigned long long)r->start);
return -EIO;
}
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH -next] mtd: fix nand/docg4.c printk format warnings
@ 2012-01-31 3:08 ` Randy Dunlap
0 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:08 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-mtd, Andrew Morton, linux-next, David Woodhouse, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warnings for resource_size_t:
drivers/mtd/nand/docg4.c:1277:4: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
drivers/mtd/nand/docg4.c:1277:4: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/nand/docg4.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20120130.orig/drivers/mtd/nand/docg4.c
+++ linux-next-20120130/drivers/mtd/nand/docg4.c
@@ -1273,8 +1273,9 @@ static int __init probe_docg4(struct pla
virtadr = ioremap(r->start, resource_size(r));
if (!virtadr) {
dev_err(dev, "Diskonchip ioremap failed: "
- "0x%x bytes at 0x%x\n",
- resource_size(r), r->start);
+ "0x%llx bytes at 0x%llx\n",
+ (unsigned long long)resource_size(r),
+ (unsigned long long)r->start);
return -EIO;
}
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH -next] ext4: fix balloc.c printk format warning
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
` (3 preceding siblings ...)
2012-01-31 3:08 ` Randy Dunlap
@ 2012-01-31 3:09 ` Randy Dunlap
2012-01-31 3:49 ` [PATCH -next] ramoops: fix printk format warnings Randy Dunlap
[not found] ` <20120130144102.8d202c7d8eccd503a86b3053-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
6 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:09 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Theodore Ts'o, Andreas Dilger, linux-ext4,
Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warning for a sector_t value:
fs/ext4/balloc.c:405:3: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
---
fs/ext4/balloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120130.orig/fs/ext4/balloc.c
+++ linux-next-20120130/fs/ext4/balloc.c
@@ -404,7 +404,7 @@ int ext4_wait_block_bitmap(struct super_
if (!buffer_uptodate(bh)) {
ext4_error(sb, "Cannot read block bitmap - "
"block_group = %u, block_bitmap = %llu",
- block_group, bh->b_blocknr);
+ block_group, (unsigned long long)bh->b_blocknr);
return 1;
}
/* Panic or remount fs read-only if block bitmap is invalid */
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH -next] ramoops: fix printk format warnings
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
` (4 preceding siblings ...)
2012-01-31 3:09 ` [PATCH -next] ext4: fix balloc.c printk format warning Randy Dunlap
@ 2012-01-31 3:49 ` Randy Dunlap
[not found] ` <20120130144102.8d202c7d8eccd503a86b3053-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
6 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:49 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, Greg KH, Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warnings for phys_addr_t type variables:
drivers/char/ramoops.c:246:3: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'phys_addr_t'
drivers/char/ramoops.c:273:2: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'phys_addr_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Greg K-H <gregkh@suse.de>
---
drivers/char/ramoops.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20120130.orig/drivers/char/ramoops.c
+++ linux-next-20120130/drivers/char/ramoops.c
@@ -244,7 +244,7 @@ static int __init ramoops_probe(struct p
if (!request_mem_region(cxt->phys_addr, cxt->size, "ramoops")) {
pr_err("request mem region (0x%lx@0x%llx) failed\n",
- cxt->size, cxt->phys_addr);
+ cxt->size, (unsigned long long)cxt->phys_addr);
err = -EINVAL;
goto fail_buf;
}
@@ -271,7 +271,8 @@ static int __init ramoops_probe(struct p
dump_oops = pdata->dump_oops;
pr_info("attached 0x%lx@0x%llx (%ux0x%zx)\n",
- cxt->size, cxt->phys_addr, cxt->max_count, cxt->record_size);
+ cxt->size, (unsigned long long)cxt->phys_addr,
+ cxt->max_count, cxt->record_size);
return 0;
^ permalink raw reply [flat|nested] 17+ messages in thread[parent not found: <20120130144102.8d202c7d8eccd503a86b3053-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>]
* [PATCH -next] cifs: fix printk format warnings
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
@ 2012-01-31 3:50 ` Randy Dunlap
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
` (5 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next-u79uwXL29TY76Z2rM5mHXA, LKML, Andrew Morton,
Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA
From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Fix printk format warnings for ssize_t variables:
fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
fs/cifs/connect.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-next-20120130.orig/fs/cifs/connect.c
+++ linux-next-20120130/fs/cifs/connect.c
@@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
len = delim - payload;
if (len > MAX_USERNAME_SIZE || len <= 0) {
- cFYI(1, "Bad value from username search (len=%ld)", len);
+ cFYI(1, "Bad value from username search (len=%zd)", len);
rc = -EINVAL;
goto out_key_put;
}
vol->username = kstrndup(payload, len, GFP_KERNEL);
if (!vol->username) {
- cFYI(1, "Unable to allocate %ld bytes for username", len);
+ cFYI(1, "Unable to allocate %zd bytes for username", len);
rc = -ENOMEM;
goto out_key_put;
}
@@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
len = key->datalen - (len + 1);
if (len > MAX_PASSWORD_SIZE || len <= 0) {
- cFYI(1, "Bad len for password search (len=%ld)", len);
+ cFYI(1, "Bad len for password search (len=%zd)", len);
rc = -EINVAL;
kfree(vol->username);
vol->username = NULL;
@@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
++delim;
vol->password = kstrndup(delim, len, GFP_KERNEL);
if (!vol->password) {
- cFYI(1, "Unable to allocate %ld bytes for password", len);
+ cFYI(1, "Unable to allocate %zd bytes for password", len);
rc = -ENOMEM;
kfree(vol->username);
vol->username = NULL;
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH -next] cifs: fix printk format warnings
@ 2012-01-31 3:50 ` Randy Dunlap
0 siblings, 0 replies; 17+ messages in thread
From: Randy Dunlap @ 2012-01-31 3:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Andrew Morton, Steve French, linux-cifs
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warnings for ssize_t variables:
fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Steve French <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org
---
fs/cifs/connect.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-next-20120130.orig/fs/cifs/connect.c
+++ linux-next-20120130/fs/cifs/connect.c
@@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
len = delim - payload;
if (len > MAX_USERNAME_SIZE || len <= 0) {
- cFYI(1, "Bad value from username search (len=%ld)", len);
+ cFYI(1, "Bad value from username search (len=%zd)", len);
rc = -EINVAL;
goto out_key_put;
}
vol->username = kstrndup(payload, len, GFP_KERNEL);
if (!vol->username) {
- cFYI(1, "Unable to allocate %ld bytes for username", len);
+ cFYI(1, "Unable to allocate %zd bytes for username", len);
rc = -ENOMEM;
goto out_key_put;
}
@@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
len = key->datalen - (len + 1);
if (len > MAX_PASSWORD_SIZE || len <= 0) {
- cFYI(1, "Bad len for password search (len=%ld)", len);
+ cFYI(1, "Bad len for password search (len=%zd)", len);
rc = -EINVAL;
kfree(vol->username);
vol->username = NULL;
@@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
++delim;
vol->password = kstrndup(delim, len, GFP_KERNEL);
if (!vol->password) {
- cFYI(1, "Unable to allocate %ld bytes for password", len);
+ cFYI(1, "Unable to allocate %zd bytes for password", len);
rc = -ENOMEM;
kfree(vol->username);
vol->username = NULL;
^ permalink raw reply [flat|nested] 17+ messages in thread[parent not found: <4F2764E9.4010506-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>]
* Re: [PATCH -next] cifs: fix printk format warnings
2012-01-31 3:50 ` Randy Dunlap
@ 2012-01-31 10:42 ` Jeff Layton
-1 siblings, 0 replies; 17+ messages in thread
From: Jeff Layton @ 2012-01-31 10:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
Andrew Morton, Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA
On Mon, 30 Jan 2012 19:50:01 -0800
Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>
> Fix printk format warnings for ssize_t variables:
>
> fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>
> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
> Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> fs/cifs/connect.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20120130.orig/fs/cifs/connect.c
> +++ linux-next-20120130/fs/cifs/connect.c
> @@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
>
> len = delim - payload;
> if (len > MAX_USERNAME_SIZE || len <= 0) {
> - cFYI(1, "Bad value from username search (len=%ld)", len);
> + cFYI(1, "Bad value from username search (len=%zd)", len);
> rc = -EINVAL;
> goto out_key_put;
> }
>
> vol->username = kstrndup(payload, len, GFP_KERNEL);
> if (!vol->username) {
> - cFYI(1, "Unable to allocate %ld bytes for username", len);
> + cFYI(1, "Unable to allocate %zd bytes for username", len);
> rc = -ENOMEM;
> goto out_key_put;
> }
> @@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>
> len = key->datalen - (len + 1);
> if (len > MAX_PASSWORD_SIZE || len <= 0) {
> - cFYI(1, "Bad len for password search (len=%ld)", len);
> + cFYI(1, "Bad len for password search (len=%zd)", len);
> rc = -EINVAL;
> kfree(vol->username);
> vol->username = NULL;
> @@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
> ++delim;
> vol->password = kstrndup(delim, len, GFP_KERNEL);
> if (!vol->password) {
> - cFYI(1, "Unable to allocate %ld bytes for password", len);
> + cFYI(1, "Unable to allocate %zd bytes for password", len);
> rc = -ENOMEM;
> kfree(vol->username);
> vol->username = NULL;
Looks correct.
Acked-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH -next] cifs: fix printk format warnings
@ 2012-01-31 10:42 ` Jeff Layton
0 siblings, 0 replies; 17+ messages in thread
From: Jeff Layton @ 2012-01-31 10:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton, Steve French,
linux-cifs
On Mon, 30 Jan 2012 19:50:01 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warnings for ssize_t variables:
>
> fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
> fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Steve French <sfrench@samba.org>
> Cc: linux-cifs@vger.kernel.org
> ---
> fs/cifs/connect.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20120130.orig/fs/cifs/connect.c
> +++ linux-next-20120130/fs/cifs/connect.c
> @@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
>
> len = delim - payload;
> if (len > MAX_USERNAME_SIZE || len <= 0) {
> - cFYI(1, "Bad value from username search (len=%ld)", len);
> + cFYI(1, "Bad value from username search (len=%zd)", len);
> rc = -EINVAL;
> goto out_key_put;
> }
>
> vol->username = kstrndup(payload, len, GFP_KERNEL);
> if (!vol->username) {
> - cFYI(1, "Unable to allocate %ld bytes for username", len);
> + cFYI(1, "Unable to allocate %zd bytes for username", len);
> rc = -ENOMEM;
> goto out_key_put;
> }
> @@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>
> len = key->datalen - (len + 1);
> if (len > MAX_PASSWORD_SIZE || len <= 0) {
> - cFYI(1, "Bad len for password search (len=%ld)", len);
> + cFYI(1, "Bad len for password search (len=%zd)", len);
> rc = -EINVAL;
> kfree(vol->username);
> vol->username = NULL;
> @@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
> ++delim;
> vol->password = kstrndup(delim, len, GFP_KERNEL);
> if (!vol->password) {
> - cFYI(1, "Unable to allocate %ld bytes for password", len);
> + cFYI(1, "Unable to allocate %zd bytes for password", len);
> rc = -ENOMEM;
> kfree(vol->username);
> vol->username = NULL;
Looks correct.
Acked-by: Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 17+ messages in thread[parent not found: <20120131054231.66669e41-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>]
* Re: [PATCH -next] cifs: fix printk format warnings
2012-01-31 10:42 ` Jeff Layton
@ 2012-01-31 13:43 ` Steve French
-1 siblings, 0 replies; 17+ messages in thread
From: Steve French @ 2012-01-31 13:43 UTC (permalink / raw)
To: Jeff Layton
Cc: Randy Dunlap, Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA,
LKML, Andrew Morton, Steve French,
linux-cifs-u79uwXL29TY76Z2rM5mHXA
Merged to cifs-2.6.git
On Tue, Jan 31, 2012 at 4:42 AM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, 30 Jan 2012 19:50:01 -0800
> Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
>
>> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>>
>> Fix printk format warnings for ssize_t variables:
>>
>> fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>>
>> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>> Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>> Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> fs/cifs/connect.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> --- linux-next-20120130.orig/fs/cifs/connect.c
>> +++ linux-next-20120130/fs/cifs/connect.c
>> @@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = delim - payload;
>> if (len > MAX_USERNAME_SIZE || len <= 0) {
>> - cFYI(1, "Bad value from username search (len=%ld)", len);
>> + cFYI(1, "Bad value from username search (len=%zd)", len);
>> rc = -EINVAL;
>> goto out_key_put;
>> }
>>
>> vol->username = kstrndup(payload, len, GFP_KERNEL);
>> if (!vol->username) {
>> - cFYI(1, "Unable to allocate %ld bytes for username", len);
>> + cFYI(1, "Unable to allocate %zd bytes for username", len);
>> rc = -ENOMEM;
>> goto out_key_put;
>> }
>> @@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = key->datalen - (len + 1);
>> if (len > MAX_PASSWORD_SIZE || len <= 0) {
>> - cFYI(1, "Bad len for password search (len=%ld)", len);
>> + cFYI(1, "Bad len for password search (len=%zd)", len);
>> rc = -EINVAL;
>> kfree(vol->username);
>> vol->username = NULL;
>> @@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>> ++delim;
>> vol->password = kstrndup(delim, len, GFP_KERNEL);
>> if (!vol->password) {
>> - cFYI(1, "Unable to allocate %ld bytes for password", len);
>> + cFYI(1, "Unable to allocate %zd bytes for password", len);
>> rc = -ENOMEM;
>> kfree(vol->username);
>> vol->username = NULL;
>
> Looks correct.
>
> Acked-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH -next] cifs: fix printk format warnings
@ 2012-01-31 13:43 ` Steve French
0 siblings, 0 replies; 17+ messages in thread
From: Steve French @ 2012-01-31 13:43 UTC (permalink / raw)
To: Jeff Layton
Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML, Andrew Morton,
Steve French, linux-cifs
Merged to cifs-2.6.git
On Tue, Jan 31, 2012 at 4:42 AM, Jeff Layton <jlayton@redhat.com> wrote:
> On Mon, 30 Jan 2012 19:50:01 -0800
> Randy Dunlap <rdunlap@xenotime.net> wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Fix printk format warnings for ssize_t variables:
>>
>> fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Steve French <sfrench@samba.org>
>> Cc: linux-cifs@vger.kernel.org
>> ---
>> fs/cifs/connect.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> --- linux-next-20120130.orig/fs/cifs/connect.c
>> +++ linux-next-20120130/fs/cifs/connect.c
>> @@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = delim - payload;
>> if (len > MAX_USERNAME_SIZE || len <= 0) {
>> - cFYI(1, "Bad value from username search (len=%ld)", len);
>> + cFYI(1, "Bad value from username search (len=%zd)", len);
>> rc = -EINVAL;
>> goto out_key_put;
>> }
>>
>> vol->username = kstrndup(payload, len, GFP_KERNEL);
>> if (!vol->username) {
>> - cFYI(1, "Unable to allocate %ld bytes for username", len);
>> + cFYI(1, "Unable to allocate %zd bytes for username", len);
>> rc = -ENOMEM;
>> goto out_key_put;
>> }
>> @@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = key->datalen - (len + 1);
>> if (len > MAX_PASSWORD_SIZE || len <= 0) {
>> - cFYI(1, "Bad len for password search (len=%ld)", len);
>> + cFYI(1, "Bad len for password search (len=%zd)", len);
>> rc = -EINVAL;
>> kfree(vol->username);
>> vol->username = NULL;
>> @@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>> ++delim;
>> vol->password = kstrndup(delim, len, GFP_KERNEL);
>> if (!vol->password) {
>> - cFYI(1, "Unable to allocate %ld bytes for password", len);
>> + cFYI(1, "Unable to allocate %zd bytes for password", len);
>> rc = -ENOMEM;
>> kfree(vol->username);
>> vol->username = NULL;
>
> Looks correct.
>
> Acked-by: Jeff Layton <jlayton@redhat.com>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 17+ messages in thread