* micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless
@ 2012-01-30 19:28 John W. Linville
2012-01-30 21:43 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2012-01-30 19:28 UTC (permalink / raw)
To: linux-wireless
Anyone looking for a little "janitorial" project to do under the
drivers/net/wireless tree?
find drivers/net/wireless/ -type f -exec grep -H WARN_ON {} \; | \
grep -v WARN_ON_ONCE | wc -l
653
That looks like an awful lot of "WARN_ON" calls. Do all of them
really need to SPAM the log files every single time they are hit?
Couldn't a lot of them be WARN_ON_ONCE instead?
Patches welcome...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless
2012-01-30 19:28 micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless John W. Linville
@ 2012-01-30 21:43 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2012-01-30 21:43 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On Mon, 2012-01-30 at 14:28 -0500, John W. Linville wrote:
> Anyone looking for a little "janitorial" project to do under the
> drivers/net/wireless tree?
>
> find drivers/net/wireless/ -type f -exec grep -H WARN_ON {} \; | \
> grep -v WARN_ON_ONCE | wc -l
> 653
>
> That looks like an awful lot of "WARN_ON" calls. Do all of them
> really need to SPAM the log files every single time they are hit?
> Couldn't a lot of them be WARN_ON_ONCE instead?
>
> Patches welcome...
>
> John
$ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \
wc -l
280
There are also:
$ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \
grep "define"
drivers/net/wireless/b43legacy/b43legacy.h:# define B43legacy_WARN_ON(x) WARN_ON(x)
drivers/net/wireless/b43/b43.h:# define B43_WARN_ON(x) WARN_ON(x)
Any reason anyone can think of this
shouldn't be a sed conversion?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-30 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 19:28 micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless John W. Linville
2012-01-30 21:43 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.