From: Wu Fengguang <wfg@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Herbert Poetzl <herbert@13thfloor.at>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] fix readahead pipeline break caused by block plug
Date: Tue, 31 Jan 2012 18:57:54 +0800 [thread overview]
Message-ID: <20120131105754.GA3867@localhost> (raw)
In-Reply-To: <20120131104621.GA27003@infradead.org>
On Tue, Jan 31, 2012 at 05:46:21AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 06:34:16PM +0800, Wu Fengguang wrote:
> > }
> >
> > + blk_start_plug(&plug);
> > written = mapping->a_ops->direct_IO(WRITE, iocb, iov, pos, *nr_segs);
> > + blk_finish_plug(&plug);
>
> Please move the plugging into ->direct_IO for both read and write, as
> that is the boundary between generic highlevel code, and low-level block
> code that should know about plugs.
The problem is, there are a dozen of ->direct_IO callback functions.
While there are only two ->direct_IO() callers, one for READ and
another for WRITE, which are much easier to deal with.
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <wfg@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Herbert Poetzl <herbert@13thfloor.at>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] fix readahead pipeline break caused by block plug
Date: Tue, 31 Jan 2012 18:57:54 +0800 [thread overview]
Message-ID: <20120131105754.GA3867@localhost> (raw)
In-Reply-To: <20120131104621.GA27003@infradead.org>
On Tue, Jan 31, 2012 at 05:46:21AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 06:34:16PM +0800, Wu Fengguang wrote:
> > }
> >
> > + blk_start_plug(&plug);
> > written = mapping->a_ops->direct_IO(WRITE, iocb, iov, pos, *nr_segs);
> > + blk_finish_plug(&plug);
>
> Please move the plugging into ->direct_IO for both read and write, as
> that is the boundary between generic highlevel code, and low-level block
> code that should know about plugs.
The problem is, there are a dozen of ->direct_IO callback functions.
While there are only two ->direct_IO() callers, one for READ and
another for WRITE, which are much easier to deal with.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-01-31 11:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 7:59 [PATCH] fix readahead pipeline break caused by block plug Shaohua Li
2012-01-31 7:59 ` Shaohua Li
2012-01-31 8:36 ` Christoph Hellwig
2012-01-31 8:36 ` Christoph Hellwig
2012-01-31 8:48 ` Eric Dumazet
2012-01-31 8:48 ` Eric Dumazet
2012-01-31 8:50 ` Herbert Poetzl
2012-01-31 8:50 ` Herbert Poetzl
2012-01-31 8:53 ` Shaohua Li
2012-01-31 8:53 ` Shaohua Li
2012-01-31 9:17 ` Eric Dumazet
2012-01-31 9:17 ` Eric Dumazet
2012-01-31 10:20 ` Wu Fengguang
2012-01-31 10:20 ` Wu Fengguang
2012-01-31 10:34 ` Wu Fengguang
2012-01-31 10:34 ` Wu Fengguang
2012-01-31 10:46 ` Christoph Hellwig
2012-01-31 10:46 ` Christoph Hellwig
2012-01-31 10:57 ` Wu Fengguang [this message]
2012-01-31 10:57 ` Wu Fengguang
2012-01-31 11:34 ` Christoph Hellwig
2012-01-31 11:34 ` Christoph Hellwig
2012-01-31 11:42 ` Wu Fengguang
2012-01-31 11:42 ` Wu Fengguang
2012-01-31 11:57 ` Christoph Hellwig
2012-01-31 11:57 ` Christoph Hellwig
2012-01-31 12:20 ` Wu Fengguang
2012-01-31 12:20 ` Wu Fengguang
2012-02-01 2:25 ` Shaohua Li
2012-02-01 2:25 ` Shaohua Li
2012-01-31 14:47 ` Vivek Goyal
2012-01-31 14:47 ` Vivek Goyal
2012-01-31 20:23 ` Vivek Goyal
2012-01-31 20:23 ` Vivek Goyal
2012-01-31 22:03 ` Vivek Goyal
2012-01-31 22:03 ` Vivek Goyal
2012-01-31 22:13 ` Andrew Morton
2012-01-31 22:13 ` Andrew Morton
2012-01-31 22:22 ` Vivek Goyal
2012-01-31 22:22 ` Vivek Goyal
2012-02-01 3:36 ` Vivek Goyal
2012-02-01 3:36 ` Vivek Goyal
2012-02-01 7:10 ` Wu Fengguang
2012-02-01 7:10 ` Wu Fengguang
2012-02-01 16:01 ` Vivek Goyal
2012-02-01 16:01 ` Vivek Goyal
2012-02-01 9:18 ` Christoph Hellwig
2012-02-01 9:18 ` Christoph Hellwig
2012-02-01 20:10 ` Vivek Goyal
2012-02-01 20:10 ` Vivek Goyal
2012-02-01 20:13 ` Jeff Moyer
2012-02-01 20:13 ` Jeff Moyer
2012-02-01 20:22 ` Andrew Morton
2012-02-01 20:22 ` Andrew Morton
2012-02-01 7:02 ` Wu Fengguang
2012-02-01 7:02 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131105754.GA3867@localhost \
--to=wfg@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=eric.dumazet@gmail.com \
--cc=hch@infradead.org \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.