All of lore.kernel.org
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
Date: Tue, 31 Jan 2012 11:46:59 +0000	[thread overview]
Message-ID: <20120131114659.GE2085@linaro.org> (raw)
In-Reply-To: <20120131032022.GC24681@S2101-09.ap.freescale.net>

On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > Compiled device tree blobs shouldn't be committed in the kernel
> > tree, so ideally git should ignore them.
> > 
> > This patch will enable ignoring of any .dtb files which appear in
> > arch/arm/boot/
> > 
> > Signed-off-by: Dave Martin <dave.martin@linaro.org>
> 
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> 
> I added my ack tag on the same patch below, but it died in the end?
> 
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

I don't mind too much which patch goes in -- do we care about whether
other .dtb files can be included in the kernel?


I would suggest that it is just plain wrong for _binary_ devicetree
blobs to appear in the kernel tree, since there is a readily usable
source form for the same thing (this isn't firmware)

Do we think that the '.dtb' filename extension might get used foro
something else?

Cheers
---Dave

> 
> Regards,
> Shawn
> 
> > ---
> >  arch/arm/boot/.gitignore |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> > index ce1c5ff..3c79f85 100644
> > --- a/arch/arm/boot/.gitignore
> > +++ b/arch/arm/boot/.gitignore
> > @@ -3,3 +3,4 @@ zImage
> >  xipImage
> >  bootpImage
> >  uImage
> > +*.dtb
> > -- 
> > 1.7.4.1

WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Uwe Kleine-Konig
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
Date: Tue, 31 Jan 2012 11:46:59 +0000	[thread overview]
Message-ID: <20120131114659.GE2085@linaro.org> (raw)
In-Reply-To: <20120131032022.GC24681-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>

On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > Compiled device tree blobs shouldn't be committed in the kernel
> > tree, so ideally git should ignore them.
> > 
> > This patch will enable ignoring of any .dtb files which appear in
> > arch/arm/boot/
> > 
> > Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> I added my ack tag on the same patch below, but it died in the end?
> 
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

I don't mind too much which patch goes in -- do we care about whether
other .dtb files can be included in the kernel?


I would suggest that it is just plain wrong for _binary_ devicetree
blobs to appear in the kernel tree, since there is a readily usable
source form for the same thing (this isn't firmware)

Do we think that the '.dtb' filename extension might get used foro
something else?

Cheers
---Dave

> 
> Regards,
> Shawn
> 
> > ---
> >  arch/arm/boot/.gitignore |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> > index ce1c5ff..3c79f85 100644
> > --- a/arch/arm/boot/.gitignore
> > +++ b/arch/arm/boot/.gitignore
> > @@ -3,3 +3,4 @@ zImage
> >  xipImage
> >  bootpImage
> >  uImage
> > +*.dtb
> > -- 
> > 1.7.4.1

  reply	other threads:[~2012-01-31 11:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 17:46 [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore Dave Martin
2012-01-30 17:46 ` Dave Martin
2012-01-31  3:20 ` Shawn Guo
2012-01-31  3:20   ` Shawn Guo
2012-01-31 11:46   ` Dave Martin [this message]
2012-01-31 11:46     ` Dave Martin
2012-01-31 11:52     ` Dave Martin
2012-01-31 11:52       ` Dave Martin
  -- strict thread matches above, loose matches on Subject: below --
2012-01-30 16:15 Dave Martin
     [not found] ` <1327940122-7674-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-01-30 18:47   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120131114659.GE2085@linaro.org \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.