All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Elder <elder@kernel.org>,
	kernel-janitors@vger.kernel.org, xfs@oss.sgi.com,
	xfs-masters@oss.sgi.com, Ben Myers <bpm@sgi.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] xfs: remove an unneeded NULL check
Date: Wed, 01 Feb 2012 21:13:26 +0000	[thread overview]
Message-ID: <20120201211326.GU9090@dastard> (raw)
In-Reply-To: <20120201104500.GA13672@infradead.org>

On Wed, Feb 01, 2012 at 05:45:01AM -0500, Christoph Hellwig wrote:
> On Wed, Feb 01, 2012 at 09:56:01AM +1100, Dave Chinner wrote:
> > >  	/* lock out background commit */
> > >  	down_read(&log->l_cilp->xc_ctx_lock);
> > > -	if (commit_lsn)
> > > -		*commit_lsn = log->l_cilp->xc_ctx->sequence;
> > > +	*commit_lsn = log->l_cilp->xc_ctx->sequence;
> > >  
> > >  	xlog_cil_insert_items(log, log_vector, tp->t_ticket);
> > 
> > There's a set of reviewed patches (for 3.3) that change all this
> > code. The null check might still be there, but that needs to be
> > checked.
> 
> Which series is that?  I mut have to admit I've lost track by now.

The removal of all the old log code.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Elder <elder@kernel.org>,
	kernel-janitors@vger.kernel.org, xfs@oss.sgi.com,
	xfs-masters@oss.sgi.com, Ben Myers <bpm@sgi.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] xfs: remove an unneeded NULL check
Date: Thu, 2 Feb 2012 08:13:26 +1100	[thread overview]
Message-ID: <20120201211326.GU9090@dastard> (raw)
In-Reply-To: <20120201104500.GA13672@infradead.org>

On Wed, Feb 01, 2012 at 05:45:01AM -0500, Christoph Hellwig wrote:
> On Wed, Feb 01, 2012 at 09:56:01AM +1100, Dave Chinner wrote:
> > >  	/* lock out background commit */
> > >  	down_read(&log->l_cilp->xc_ctx_lock);
> > > -	if (commit_lsn)
> > > -		*commit_lsn = log->l_cilp->xc_ctx->sequence;
> > > +	*commit_lsn = log->l_cilp->xc_ctx->sequence;
> > >  
> > >  	xlog_cil_insert_items(log, log_vector, tp->t_ticket);
> > 
> > There's a set of reviewed patches (for 3.3) that change all this
> > code. The null check might still be there, but that needs to be
> > checked.
> 
> Which series is that?  I mut have to admit I've lost track by now.

The removal of all the old log code.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-02-01 21:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-28 10:55 [patch] xfs: remove an unneeded NULL check Dan Carpenter
2012-01-28 10:55 ` Dan Carpenter
2012-01-31 22:04 ` [NOTES] " Phil White
2012-01-31 22:56 ` Dave Chinner
2012-01-31 22:56   ` Dave Chinner
2012-01-31 23:08   ` Ben Myers
2012-01-31 23:08     ` Ben Myers
2012-02-01 10:45   ` Christoph Hellwig
2012-02-01 10:45     ` Christoph Hellwig
2012-02-01 21:13     ` Dave Chinner [this message]
2012-02-01 21:13       ` Dave Chinner
2012-02-01 21:15       ` Christoph Hellwig
2012-02-01 21:15         ` Christoph Hellwig
2012-02-01 23:16         ` Dave Chinner
2012-02-01 23:16           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120201211326.GU9090@dastard \
    --to=david@fromorbit.com \
    --cc=bpm@sgi.com \
    --cc=dan.carpenter@oracle.com \
    --cc=elder@kernel.org \
    --cc=hch@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.