From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>, Dmitry Torokhov <dtor@mail.ru>,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core
Date: Thu, 2 Feb 2012 13:27:50 +0000 [thread overview]
Message-ID: <20120202132750.GM7428@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F2A8912.4070701@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 615 bytes --]
On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote:
> On 02/02/2012 02:48 PM, Mark Brown wrote:
> > The calling convention here seems a bit weird too, you've got value then
> > register but normally we have register then value for I2C/SPI devices.
> I have based these part on the twl-core's implementation. I should not
> have done that, I know.. Let's see how it will look like with regmap.
Yeah, like I say...
> > Except when we don't :(
...it's not like we've been consistent so far. I'm not that fussed
either way, I probably wouldn't have mentioned it if I hadn't otherwise
been commenting.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core
Date: Thu, 2 Feb 2012 13:27:50 +0000 [thread overview]
Message-ID: <20120202132750.GM7428@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F2A8912.4070701@ti.com>
On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote:
> On 02/02/2012 02:48 PM, Mark Brown wrote:
> > The calling convention here seems a bit weird too, you've got value then
> > register but normally we have register then value for I2C/SPI devices.
> I have based these part on the twl-core's implementation. I should not
> have done that, I know.. Let's see how it will look like with regmap.
Yeah, like I say...
> > Except when we don't :(
...it's not like we've been consistent so far. I'm not that fussed
either way, I probably wouldn't have mentioned it if I hadn't otherwise
been commenting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120202/f81919fa/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Liam Girdwood <lrg@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core
Date: Thu, 2 Feb 2012 13:27:50 +0000 [thread overview]
Message-ID: <20120202132750.GM7428@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F2A8912.4070701@ti.com>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote:
> On 02/02/2012 02:48 PM, Mark Brown wrote:
> > The calling convention here seems a bit weird too, you've got value then
> > register but normally we have register then value for I2C/SPI devices.
> I have based these part on the twl-core's implementation. I should not
> have done that, I know.. Let's see how it will look like with regmap.
Yeah, like I say...
> > Except when we don't :(
...it's not like we've been consistent so far. I'm not that fussed
either way, I probably wouldn't have mentioned it if I hadn't otherwise
been commenting.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-02 13:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:16 [RFC 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-02 12:16 ` Peter Ujfalusi
2012-02-02 12:16 ` [RFC 1/7] MFD: twl-core: Detach twl6040 from the pmic mfd driver Peter Ujfalusi
2012-02-02 12:16 ` Peter Ujfalusi
2012-02-02 12:16 ` Peter Ujfalusi
2012-02-02 12:16 ` [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core Peter Ujfalusi
2012-02-02 12:16 ` Peter Ujfalusi
2012-02-02 12:48 ` Mark Brown
2012-02-02 12:48 ` Mark Brown
2012-02-02 13:01 ` Peter Ujfalusi
2012-02-02 13:01 ` Peter Ujfalusi
2012-02-02 13:27 ` Mark Brown [this message]
2012-02-02 13:27 ` Mark Brown
2012-02-02 13:27 ` Mark Brown
2012-02-02 12:16 ` [RFC 3/7] ASoC: twl6040: Remove dependency on twl4030 from Kconfig Peter Ujfalusi
2012-02-02 12:42 ` Mark Brown
2012-02-02 12:42 ` Mark Brown
2012-02-02 12:42 ` Mark Brown
2012-02-02 12:16 ` [RFC 4/7] OMAP: 4430sdp: Correct fixed regulator device ID Peter Ujfalusi
2012-02-02 12:16 ` Peter Ujfalusi
2012-02-02 12:38 ` Mark Brown
2012-02-02 12:38 ` Mark Brown
2012-02-02 12:38 ` Mark Brown
2012-02-02 12:16 ` [RFC 5/7] OMAP: sdp4430: Add fixed regulator for twl6040 needs Peter Ujfalusi
2012-02-02 12:40 ` Mark Brown
2012-02-02 12:40 ` Mark Brown
2012-02-02 12:40 ` Mark Brown
2012-02-02 13:03 ` Peter Ujfalusi
2012-02-02 13:03 ` Peter Ujfalusi
2012-02-02 12:16 ` [RFC 6/7] OMAP: omap4panda: " Peter Ujfalusi
2012-02-02 12:41 ` Mark Brown
2012-02-02 12:41 ` Mark Brown
2012-02-02 12:41 ` Mark Brown
2012-02-02 12:16 ` [RFC 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies Peter Ujfalusi
2012-02-02 12:52 ` Mark Brown
2012-02-02 12:52 ` Mark Brown
2012-02-02 12:52 ` Mark Brown
2012-02-02 13:18 ` Peter Ujfalusi
2012-02-02 13:18 ` Peter Ujfalusi
2012-02-02 13:18 ` Peter Ujfalusi
2012-02-02 13:32 ` Mark Brown
2012-02-02 13:32 ` Mark Brown
2012-02-02 13:32 ` Mark Brown
2012-02-02 13:59 ` Peter Ujfalusi
2012-02-02 13:59 ` Peter Ujfalusi
2012-02-02 13:59 ` Peter Ujfalusi
2012-02-02 14:19 ` Mark Brown
2012-02-02 14:19 ` Mark Brown
2012-02-02 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202132750.GM7428@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dtor@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.